[issue13411] Hashable memoryviews

[Stefan Krah]

Changes by Stefan Krah :


--
resolution: remind -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Stefan Krah]

Stefan Krah  added the comment:

Done in: http://hg.python.org/features/pep-3118/rev/508d5e3c579c

--
dependencies:  -Problems with Py_buffer management in memoryobject.c (and 
elsewhere?)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Stefan Krah]

Stefan Krah  added the comment:

Reopening as a reminder that it isn't fixed yet in 
http://hg.python.org/features/pep-3118 .

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Stefan Krah]

Changes by Stefan Krah :


--
dependencies: +Problems with Py_buffer management in memoryobject.c (and 
elsewhere?)
resolution: fixed -> remind
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Fixed, thanks.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 215690b782f8 by Antoine Pitrou in branch 'default':
Issue #13411: memoryview objects are now hashable when the underlying object is 
hashable.
http://hg.python.org/cpython/rev/215690b782f8

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> I'm not sure that the "register" storage class specifier is still
> relevant with modern compilers: I'm pretty sure gcc ignores it unless
> -O0, and I think I've read somewhere Microsoft's compiler ignores it
> too.

I don't think so either. I was lazily moving the original code, but I
could remove those bits.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Charles-François Natali]

Charles-François Natali  added the comment:

I'm not sure that the "register" storage class specifier is still relevant with 
modern compilers: I'm pretty sure gcc ignores it unless -O0, and I think I've 
read somewhere Microsoft's compiler ignores it too.

--
nosy: +neologix

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Does memory_hash() reject non-contiguous memory?

It should, since it checks the strides array.

> _Py_HashBytes() might be reused by unicode_hash() for PyUnicode_1BYTE_KIND.

I don't really see how unicode hashing should be related to bytes
hashing (even though apparently an (outdated?) test checks for that).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[STINNER Victor]

STINNER Victor  added the comment:

Except these two minor nits, the patch looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[STINNER Victor]

STINNER Victor  added the comment:

Does memory_hash() reject non-contiguous memory?

_Py_HashBytes() might be reused by unicode_hash() for PyUnicode_1BYTE_KIND.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Eric Snow]

Changes by Eric Snow :


--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Meador Inge]

Changes by Meador Inge :


--
nosy: +meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13411] Hashable memoryviews

[Antoine Pitrou]

New submission from Antoine Pitrou :

This patch allows hashing of memoryviews, as discussed on python-dev.

--
components: Interpreter Core
files: memhash.patch
keywords: patch
messages: 147714
nosy: ncoghlan, pitrou, skrah
priority: normal
severity: normal
stage: patch review
status: open
title: Hashable memoryviews
type: feature request
versions: Python 3.3
Added file: http://bugs.python.org/file23697/memhash.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com