[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I am not sure what to do with this.  The addition of squeezer to Shell and 
ability to expand into textview makes this a bit less needed.  It would have to 
be rewritten.  It seems big, but a large part is revision of tests, which have 
since been moved to unittests in separate test files.

--
nosy:  -Saimadhav.Heblikar, gpolo, kbk, markroseman
priority: normal -> low
versions: +Python 3.10 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Change by Tal Einat :


--
nosy:  -taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Mark Roseman]

Changes by Mark Roseman :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:


--
nosy: +sahutd

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Terry J. Reedy]

Terry J. Reedy added the comment:

Calltips will be rewritten for 3.5, maybe 3.4 in #19903, to use 
inspect.signature. Once that is done, I would like to revisit this issue, as I 
agree that it would be useful, and it should be fairly easy. I though of being 
able to rightclick on the calltip box to ask for more but a key would be fine 
to start. The current code uses .__doc__ but only after checking that it exists.
if isinstance(ob_call, types.MethodType):
doc = ob_call.__doc__
else:
doc = getattr(ob, __doc__, )
if doc:
I would not start this until the new code is in place.

--
assignee: kbk - terry.reedy
dependencies: +Idle: Use inspect.signature for calltips
priority: low - normal
resolution: rejected - 
stage: committed/rejected - test needed
status: closed - open
versions: +Python 3.5 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Kurt B. Kaiser]

Kurt B. Kaiser k...@shore.net added the comment:

Rejecting for now, out of date, doesn't apply, not single topic.

--
resolution: out of date - rejected
stage: test needed - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

From msg84550 The added functionality is useful, but this patch is not the 
way to go.  Can this be closed as rejected, would the OP like to supply an 
updated patch, or what?

--
nosy: +BreamoreBoy, terry.reedy
versions: +Python 3.2 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Daniel Diniz]

Changes by Daniel Diniz aja...@gmail.com:


--
nosy: +gpolo
stage:  - test needed
type:  - feature request

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Changes by Tal Einat [EMAIL PROTECTED]:


Removed file: http://bugs.python.org/file8641/IDLE_CallTips.071028.patch

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Changes by Tal Einat [EMAIL PROTECTED]:


Removed file: 
http://bugs.python.org/file8960/IDLE_CallTips.071214.incremental.patch

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Tal Einat added the comment:

I had a working version which also used inspect before I saw your 3.0
version, but they both use inspect similarly, very straightforward. I
seem to recall only one of the version used inspect to get the doc
string, but I don't remember which one...

Depending on how you divide things, this patch includes more than just
two different developments. But they are interrelated to some extent.
And one of the developments is more rigorous testing, which this version
passes with flying colors.

If you wish, I can try to get another developer or two to test and
review this patch, if that will help somehow. Or anything else that will
help...

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Kurt B. Kaiser]

Kurt B. Kaiser added the comment:

I deleted the extra files.

You aren't making this easy!  I was expecting a relatively small update to 
the original patch.

Did you backport my 3.0 revision of CallTips.py or did you come up with 
your own version which uses inspect.py?

Right now, the patch includes two unrelated developments, which 
(following 
our normal procedures) wouldn't be combined as you have done.

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Kurt B. Kaiser]

Changes by Kurt B. Kaiser:


Removed file: 
http://bugs.python.org/file8958/IDLE_CallTips.071214.incremental.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Kurt B. Kaiser]

Changes by Kurt B. Kaiser:


Removed file: http://bugs.python.org/file8957/IDLE_CallTips.071214.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Tal Einat added the comment:

Alrighty then!

Since I had also done some work on CallTips.py since the previous patch,
I've worked up a merged version, including stuff from the py3k version
and better tests.

Changes since the first patch:
* add support for callable instances (e.g. __call__)
* use inspect, which does the hackish stuff for us, such as using
object.im_func where needed and formatting doc-strings appropriately
* use isinstance instead of type checking, like in the py3k branch
* rename get_arg_text to get_arg_text_and_doc
* add test cases for callable instances, classmethods, staticmethods and
old-style classes
* rework testing code
* tested extensively (only on WinXP, Python2.5)

I'm attaching a patch relative to the current SVN head, and another one
relative to the current SVN head with the previous patch applied.

Added file: http://bugs.python.org/file8957/IDLE_CallTips.071214.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__

IDLE_CallTips.071214.patch
Description: Binary data
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Changes by Tal Einat:


Added file: 
http://bugs.python.org/file8958/IDLE_CallTips.071214.incremental.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Tal Einat added the comment:

Now for CallTipWindow.py:

* split conditionals into two lines as requested
* changed the test (took me a while to understand what controversy you
were referring to...)

I couldn't find anything wrong with the first line. It is the
function/method signature if it was found, or just the beginning of the
doc-string otherwise. Unless you think the adding the signature (when
possible) is unnecessary/confusing...

The above changes are included in both new patches.

Added file: http://bugs.python.org/file8959/IDLE_CallTips.071214.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__

IDLE_CallTips.071214.patch
Description: Binary data
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Changes by Tal Einat:


Added file: 
http://bugs.python.org/file8960/IDLE_CallTips.071214.incremental.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Tal Einat added the comment:

(bah, sorry for the mess, use the patch files from the later hour)

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

Tal Einat added the comment:

Yes, I admit I haven't tested this very thoroughly. I'll give this some
more time this weekend and submit another patch.

As for 3.0, I'll have to see what you've changed, but I'll gladly work
up a patch based on the newer version.

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Kurt B. Kaiser]

Kurt B. Kaiser added the comment:

This is very useful!

However, it isn't fully baked.  Please test more
before submitting patches.  Try to break them on
corner cases.

import CallTips
CallTips.CallTips(

AttributeError: 'NoneType' object has no attribute 
'splitlines'

def foo():
pass

foo(

same error.

There are two conditional blocks which need to go
on separate lines.

The jocular test in CallTipWindow needs to be changed
to avoid needless controversy.  Also, the doc window's
first line isn't quite right.

There may be other issues, but that's as far as I got.

I would like to get this into 2.6a1.  However, I
completely rewrote CallTips.py for 3.0.  I will need
another version of the patch for the latter, can you
supply it once we get 2.6 put to bed?

--
assignee:  - kbk

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Martin v. Löwis]

Changes by Martin v. Löwis:


--
keywords: +patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1350] IDLE - CallTips enhancement - show full doc-string in new window

[Tal Einat]

New submission from Tal Einat:

This (relatively speaking) simple patch allows the full doc-string of a
callable to be displayed in a textView window. Once a call-tip is being
displayed, hitting one of the keys which is bound to the
force-open-calltip virtual event (Control-backslash by default) opens
the new window. If there is no extra documentation to be shown (in
addition to what is already shown in the call-tip), the window is not
displayed.

--
components: IDLE
files: IDLE_CallTips.071028.patch
messages: 56876
nosy: kbk, taleinat
severity: minor
status: open
title: IDLE - CallTips enhancement - show full doc-string in new window
versions: Python 2.5, Python 2.6
Added file: http://bugs.python.org/file8641/IDLE_CallTips.071028.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1350
__

IDLE_CallTips.071028.patch
Description: Binary data
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com