[issue13586] IDLE: Replace selected not working/consistent with find

[Zackery Spytz]

Zackery Spytz  added the comment:

I've created a pull request for this issue.  Please take a look.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +17065
pull_request: https://github.com/python/cpython/pull/17593

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Mark Roseman]

Changes by Mark Roseman :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
versions: +Python 3.3, Python 3.4 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Marco Scataglini]

Marco Scataglini atlant...@gmx.com added the comment:

Thank you Roger
find_keep_open.patch works, but now that brings me to issue13630 that I thought 
was existing, and now this confirms it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Roger Serwy]

Roger Serwy roger.se...@gmail.com added the comment:

On Linux using 2.7.1 and 3.2, the Replace dialog does not contain the selected 
text in the Find field.

The find functionality that copies the selected text was introduced in 
868ff0dfabd2 on 2002-11-06. Unfortunately it wasn't added to the Replace Dialog 
code. The attached patch (against 3.3a0) adds this functionality to Replace 
Dialog and also removes some non-functional (arguably broken) code.

--
keywords: +patch
nosy: +serwy
Added file: http://bugs.python.org/file24003/issue13586.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Marco Scataglini]

Marco Scataglini atlant...@gmx.com added the comment:

To check on 3.2 I installed a fresh Python 3.2.1.1 on Win7 x86 32bit and it has 
the same problem.
So this issues is valid on 2.7.2.1 and 3.2.1.1
I --dry-run Roger patch on both 2.7 and 3.2 with no errors or warnings messages 
and after patching it fixes the issue on both versions.

--
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Terry J. Reedy]

Terry J. Reedy tjre...@udel.edu added the comment:

I am running 3.2.2 on 64-bit Win7Pro, which should not make a difference. So 
why did ^H work right for me yesterday and not for Marco today.

Retrying with fresh IDLEs I discovered the following: selections do not 
initially appear in the find part of a Replace box (^H). But after selecting 
and opening a Find box (^F) with something selected, the same text appears in 
Replace boxes regardless of the actual selection, even if there is no selection 
-- until another Find box is opened.

So I was fooled yesterday because I tried ^F first to see what the 'correct' 
behavior was and then did ^H with the same selection. And I did the same in 
both Shell and Edit windows. When testing, order matters ;-).

I discovered something else I am not sure is what we want. Clicking Find in a 
Replace box leaves the box open so one can Find again. Clicking Find in a Find 
box closes it. So you need ^F and Find to re-search.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Marco Scataglini]

Marco Scataglini atlant...@gmx.com added the comment:

To follow on Terry thought, I think find dialog box should stay open when 
'Find' button is pressed, since there is a 'close' button to close it.
That would also be a more accepted behavior similar to all the other editors I 
know.

And on silly UI design notes:
The 'close' button should be at the bottom instead of the top (and have a 
capital C)
ctrl+f 'Find' button should say 'Find Next' like most other editors and also 
since that is what it does.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Roger Serwy]

Changes by Roger Serwy roger.se...@gmail.com:


Added file: http://bugs.python.org/file24016/find_keep_open.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
title: Replace selected not working/consistent with find - IDLE: Replace 
selected not working/consistent with find

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13586] IDLE: Replace selected not working/consistent with find

[Marco Scataglini]

Marco Scataglini atlant...@gmx.com added the comment:

Win 7 Pro 32bit.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13586
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com