[issue13670] Increase test coverage for pstats.py

[Irit Katriel]

Irit Katriel  added the comment:

The patch needs to be reviewed. If the tests are still relevant and increase 
coverage, it needs to be converted to a GitHub PR. Otherwise this issue can be 
closed.

--
keywords: +easy, newcomer friendly -patch
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[andrea crotti]

andrea crotti  added the comment:

It has been a long time but if it's still useful sure.

I can see some tests have been added in commit 
863b1e4d0e95036bca4e97c1b8b2ca72c19790fb
but if these are still relevant I'm happy to go ahead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[Mark Lawrence]

Mark Lawrence added the comment:

@Andrea assuming that you get an answer to the question you posed in msg150292, 
will you follow up on this?

--
nosy: +BreamoreBoy
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13670
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[andrea crotti]

New submission from andrea crotti andrea.crott...@gmail.com:

This patch increases test coverage for pstats.py from 25 to 36%.

It's my first proposed patch so sorry in advance if there are problems. Much 
more can be done for pstats.py (which is also not much commented) but I want to 
get some feedback on this first..

--
components: Tests
files: test_pstats.diff
keywords: patch
messages: 150290
nosy: andrea.crotti
priority: normal
severity: normal
status: open
title: Increase test coverage for pstats.py
type: enhancement
versions: Python 3.3
Added file: http://bugs.python.org/file24098/test_pstats.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy: +brian.curtin
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[Georg Brandl]

Georg Brandl ge...@python.org added the comment:

I don't understand this comment:
+#TODO: add more complicated tests, which might almost compile

Also, please don't use docstrings for the test methods because of unittest's 
feature to display them instead of the test method names.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13670] Increase test coverage for pstats.py

[andrea crotti]

andrea crotti andrea.crott...@gmail.com added the comment:

It's really hard to understand true, and if should not go in the patch in 
general of course.

The sense was that the only test I added is trivial, but I haven't produced 
something better yet.

And ok I will remove the docstrings, I was actually doing it on purpose 
thinking about the unittest feature, but if the name is clear enough than is 
better to leave the docstring out...

Another thing, I didn't want to use tempfile.mktemp to generate a temporary 
file, but dump_stats doesn't accept anything else, is it in general safe to use 
it in this case?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com