[issue13681] Aifc read compressed frames fix

[Irit Katriel]

Irit Katriel  added the comment:

aifc is deprecated as per PEP 594, so there won't be further enhancements to it.

--
nosy: +iritkatriel
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Mark Lawrence]

Mark Lawrence added the comment:

@Oleg #13806 has been closed as fixed so can you take this issue forward?

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Oleg Plakhotnyuk]

Changes by Oleg Plakhotnyuk oleg...@gmail.com:


Removed file: http://bugs.python.org/file24112/aifc_compression.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Oleg Plakhotnyuk]

Oleg Plakhotnyuk oleg...@gmail.com added the comment:

Ok, I have opened issue 13806 with audioop fix alone. However, I cannot change 
current issue's dependencies to reflect that current issue depends on issue 
13806. Could anyone do this for me please?

--
Added file: http://bugs.python.org/file24261/aifc_compression.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
dependencies: +Audioop decompression frames size check fix

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Sandro Tosi]

Sandro Tosi sandro.t...@gmail.com added the comment:

Hi Oleg,
thanks for your interest in aifc module!

I think that if the fix for audioop has a reason for itself to exists, then 
another issue (for that only) has to be filed and set the accordingly 
dependency on this one.

--
nosy: +sandro.tosi

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Oleg Plakhotnyuk]

New submission from Oleg Plakhotnyuk oleg...@gmail.com:

This patch resolves two issues:

1. ADPCM compressed audio files reading. Such files have frame size of 4 bits. 
Aifc lib cannot represent 4 bits frame size because it uses integer bytes count 
variable. I have replaced it with bits count.

2. ALAW/ULAW/ADPCM audio data decompression. According to documentation 
(http://docs.python.org/library/audioop.html), adpcm2lin, alaw2lin and ulaw2lin 
are using 'width' argument to represent output frames width. However, in 
audioop.c module there are checks that are raising exceptions if input frames 
length is not multiple of 'width'. I have replaced checking of 'len' to match 
'size' with checking of 'len*size' to match 'size' in order to retain only 
basic length validity checks.

--
components: Library (Lib), Tests
files: aifc_compression.patch
keywords: patch
messages: 150373
nosy: Oleg.Plakhotnyuk, ezio.melotti, r.david.murray
priority: normal
severity: normal
status: open
title: Aifc read compressed frames fix
type: behavior
versions: Python 3.2, Python 3.3
Added file: http://bugs.python.org/file24112/aifc_compression.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13681] Aifc read compressed frames fix

[Oleg Plakhotnyuk]

Oleg Plakhotnyuk oleg...@gmail.com added the comment:

I have put changes to both aifc and audioop module in this single patch. The 
reason is that aifc test reading compressed frames will work properly only 
after audioop fix has been applied.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com