[issue14125] Windows: failures in refleak mode

[Stefan Krah]

Stefan Krah  added the comment:

Test suite is OK also on 3.2. Closing.

--
components: +Tests
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Roundup Robot]

Roundup Robot  added the comment:

New changeset b4321f93e3f2 by Stefan Krah in branch '3.2':
Issue #14125: backport refleak fix (d4adbf908983).
http://hg.python.org/cpython/rev/b4321f93e3f2

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Stefan Krah]

Stefan Krah  added the comment:

sbt, thanks again! I chose a different approach because on non-Windows
the unused 'error' label produced compiler warnings.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Roundup Robot]

Roundup Robot  added the comment:

New changeset d4adbf908983 by Stefan Krah in branch 'default':
Issue #14125: Fix refleak in timemodule.c on Windows. Thanks sbt for pointing
http://hg.python.org/cpython/rev/d4adbf908983

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[sbt]

sbt  added the comment:

Ah.  Forgot the patch.

--
Added file: http://bugs.python.org/file24662/time_strftime_leak.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[sbt]

sbt  added the comment:

The attached patch fixes the time related refleaks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Roundup Robot]

Roundup Robot  added the comment:

New changeset ba51573fcf90 by Stefan Krah in branch 'default':
Issue #14125: Fix multiprocessing refleak on Windows. Patch by sbt.
http://hg.python.org/cpython/rev/ba51573fcf90

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Stefan Krah]

Stefan Krah  added the comment:

Nice! This also fixes the leak in test_concurrent_futures. The
time-related test failures probably also have a single source.


I ran the whole test suite on x64 with no (new) failures.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[sbt]

sbt  added the comment:

The failures for test_multiprocessing and test_concurrent_futures seem to be 
caused by a leak in _multiprocessing.win32.WaitForMultipleObjects().

The attached patch fixes those leaks for me (on a 32 bit build).

--
keywords: +patch
nosy: +sbt
Added file: http://bugs.python.org/file24655/mp_wfmo_leak.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14125] Windows: failures in refleak mode

[Stefan Krah]

New submission from Stefan Krah :

The following tests fail on Windows in refleak mode. I used
24ca28cc9c9c as a reference point. Build is x64. Summary:

test_concurrent_futures, test_datetime, test_multiprocessing, test_strftime and 
test_time are leaking.



C:\Users\stefan\hg\master\PCbuild>amd64\python_d.exe -m test -uall -R :: 
test_multiprocessing  
[1/1] test_multiprocessing  
   
beginning 9 repetitions 
   
123456789   
   
.   
   
test_multiprocessing leaked [3, 3, 3, 3] references, sum=12 
   
Warning -- multiprocessing.process._dangling was modified by 
test_multiprocessing  
1 test failed:  
   
test_multiprocessing
   
[172456 refs]


C:\Users\stefan\hg\master\PCbuild>amd64\python_d.exe -m test -uall -R :: 
test_concurrent_futures   
[1/1] test_concurrent_futures   
   
beginning 9 repetitions 
   
123456789   
   
.   
   
test_concurrent_futures leaked [1524, 1518, 1524, 1524] references, sum=6090
   
1 test failed:  
   
test_concurrent_futures 
   
[170398 refs]   
   
 

C:\Users\stefan\hg\master\PCbuild>amd64\python_d.exe -m test -uall -R :: 
test_datetime 
[1/1] test_datetime 
   
beginning 9 repetitions 
   
123456789   
   
.   
   
test_datetime leaked [20, 20, 20, 20] references, sum=80
   
1 test failed:  
   
test_datetime   
   
[191763 refs]   
 



C:\Users\stefan\hg\master\PCbuild>amd64\python_d.exe -m test -uall -R :: 
test_strftime 
[1/1] test_strftime 
   
beginning 9 repetitions 
   
123456789   
   
.   
   
test_strftime leaked [2761, 2761, 2761, 2761] references, sum=11044 
   
1 test failed:  
   
test_strftime   
   
[170275 refs]   
   


C:\Users\stefan\hg\master\PCbuild>amd64\python_d.exe -m test -uall -R :: 
test_time 
[1/1] test_time 
   
beginning 9 repetitions 
   
123456789   
   
.   
   
test_time leaked [1, 1, 1, 1] references, sum=4 
   
1 test failed:  
   
test_tim