[issue14151] multiprocessing.connection.Listener fails with invalid address

[Popa Claudiu]

New submission from Popa Claudiu :

In multiprocessing.connection, when using a Windows named pipe on a Unix 
platform, the following error will occur. This should not happen, the format of 
the address should be validated somehow before. The following error will occur 
because PipeListener is not defined under any platform different than win32. 

Python 3.2.2 (default, Oct 14 2011, 21:46:49)
[GCC 4.2.2 20070831 prerelease [FreeBSD]] on freebsd8
Type "help", "copyright", "credits" or "license" for more information.
>>> from multiprocessing.connection import Listener
>>> Listener(r'\\.\test')
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/local/lib/python3.2/multiprocessing/connection.py", line 130, in 
__init__
self._listener = PipeListener(address, backlog)
NameError: global name 'PipeListener' is not defined
>>>


I've attached a small patch for this issue.

--
components: Library (Lib)
files: connection.patch
keywords: patch
messages: 154552
nosy: Popa.Claudiu
priority: normal
severity: normal
status: open
title: multiprocessing.connection.Listener fails with invalid address
type: behavior
versions: Python 3.2
Added file: http://bugs.python.org/file24671/connection.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Thanks for the patch. I don't think it deserves to be a public API (it could be 
a private function, i.e. starting with an underscore).
Also, it's better if you can add a test (to Lib/test/test_multiprocessing.py) 
checking that ValueError is raised when applicable.

--
nosy: +pitrou
versions: +Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Popa Claudiu]

Popa Claudiu  added the comment:

Here are the two diffs. Hope they are good this time.

--
Added file: http://bugs.python.org/file25090/connection.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Popa Claudiu]

Changes by Popa Claudiu :


Added file: http://bugs.python.org/file25091/test_multiprocessing.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 273d7502ced1 by Antoine Pitrou in branch '3.2':
Issue #14151: Raise a ValueError, not a NameError, when trying to create
http://hg.python.org/cpython/rev/273d7502ced1

New changeset 42b29aea1c98 by Antoine Pitrou in branch 'default':
Issue #14151: Raise a ValueError, not a NameError, when trying to create
http://hg.python.org/cpython/rev/42b29aea1c98

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Thank you!
For the record, the recommended workflow to produce patches is to use 
Mercurial: see 
http://docs.python.org/devguide/setup.html#getting-the-source-code
so that you only have to type e.g. "hg diff" to get a diff of all your local 
changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14151] multiprocessing.connection.Listener fails with invalid address

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com