[issue1429] FD leak in SocketServer when request handler throws exception

[Martin Panter]

Martin Panter added the comment:

Jeff has tried many times over two years to produce the originally reported bug 
without success. By code inspection, I cannot see how a request handler 
exception could cause a leak. Therefore I am closing this as “works for me”.

Working backwards from all the spurious version changes (I wish people wouldn’t 
do that!), I figure that this was originally opened against Python 2.4 only. It 
is possible that the bug got fixed in the meantime.

For the question of coping with exceptions from handle_error(), the change 
proposed in Issue 25139 should cover that.

--
resolution:  -> works for me
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer when request handler throws exception

[Martin Panter]

Martin Panter added the comment:

I think calling shutdown_request(), or at least close_request(), should be done 
regardless of whether handle_error() fails or not.

--
nosy: +vadmium

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer when request handler throws exception

[Martin Panter]

Changes by Martin Panter :


--
title: FD leak in SocketServer -> FD leak in SocketServer when request handler 
throws exception

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Jeff McNeil]

Jeff McNeil  added the comment:

In an effort to walk through bugs in my nosy list, I dug into this and tried to 
reproduce it to no avail. 

Also, as the handle_error method is supposed to handle problems gracefully, 
calling shutdown on handle_error exception is probably questionable. I'd be 
happy to submit a patch to do just that if those smarter than I think it is 
worthwhile, but I don't so much believe it is.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
versions: +Python 3.3 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Jeff McNeil]

Jeff McNeil  added the comment:

I entirely forgot I had signed up to look, my apologies. 

I'm going through this w/ what's lying on Mercurial's tip, I can't reproduce it 
at all. I can raise exceptions of various flavors from within the handle method 
of a StreamRequestHandler and there are no leaking file descriptors.  

The only thing worthy of discusion, IMO, is the fact that raising an exception 
in a handle_error method of a subclass of BaseServer *does* cause the the 
self.shutdown_request to not run.  

Unless I'm mistaken, that does then leave the cleanup of that open socket to GC 
(but, at that point, anyone overriding handle_error method should know that). 
Does it make sense to run shutdown_request, even if handle_error throws an 
Exception?  

If anyone thinks that's worthwhile, I can do that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Jeff McNeil]

Jeff McNeil  added the comment:

I'll see if I can get it to reproduce and put a patch together.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Mark Lawrence]

Mark Lawrence  added the comment:

This will go nowhere unless a patch is provided that contains code, doc and 
unit test changes.

--
nosy: +BreamoreBoy
stage:  -> unit test needed
type:  -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Jeff McNeil]

Jeff McNeil  added the comment:

I was toying with adding Unix Socket support for one of our internal tools and 
I thought I ran into a leak in my own code. Searched the bug tracker and found 
this.

I tried to reproduce, but wasn't able to. Though, if you look at the 
ThreadingMixIn class, you'll see this:

self.handle_error(request, client_address)
self.close_request(request)

An exception in handle_error, most likely from a subclass, would cause 
close_request to never fire. Though, the socket.accept'd channel would probably 
be shut down implicitly when leaving _handle_request_nonblock.

--
nosy: +mcjeff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Giampaolo Rodola']

Changes by Giampaolo Rodola' <[EMAIL PROTECTED]>:


--
nosy: +giampaolo.rodola

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Christian Heimes]

Changes by Christian Heimes:


--
priority:  -> high
versions: +Python 2.6 -Python 2.4

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Raghuram Devarakonda]

Raghuram Devarakonda added the comment:

Please provide a small test code that manifests the problem. It is
always the best way to get quick response.

--
nosy: +draghuram

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1429] FD leak in SocketServer

[Luke-Jr]

New submission from Luke-Jr:

SocketServer.ThreadingUnixStreamServer leaks file descriptors when a 
request handler throws an exception.

--
components: Library (Lib)
messages: 57396
nosy: luke-jr
severity: normal
status: open
title: FD leak in SocketServer
versions: Python 2.4

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com