[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-24 Thread Eli Bendersky 

Changes by Eli Bendersky :


--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-24 Thread Roundup Robot 

Roundup Robot  added the comment:

New changeset 242d3f8e8c50 by Eli Bendersky in branch 'default':
Issue #14349: Fix the doc of the MAKE_FUNCTION opcode in Doc/library/dis.rst to
http://hg.python.org/cpython/rev/242d3f8e8c50

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-24 Thread Georg Brandl 

Georg Brandl  added the comment:

Looks good to me.

--
nosy: +georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-23 Thread Eli Bendersky 

Eli Bendersky  added the comment:

Patch attached.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file25002/issue14349.1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-17 Thread Georg Brandl 

Changes by Georg Brandl :


--
assignee: docs@python -> pitrou
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14349] The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

2012-03-17 Thread Eli Bendersky 

New submission from Eli Bendersky :

The documentation of the MAKE_FUNCTION opcode in 'dis' says:

"Pushes a new function object on the stack. TOS is the code associated with the 
function. "

Which doesn't appear to be true. In Python/ceval.c:

[...]
TARGET_WITH_IMPL(MAKE_CLOSURE, _make_function)
TARGET(MAKE_FUNCTION)
_make_function:
{
int posdefaults = oparg & 0xff;
int kwdefaults = (oparg>>8) & 0xff;
int num_annotations = (oparg >> 16) & 0x7fff;

w = POP(); /* qualname */
v = POP(); /* code object */
x = PyFunction_NewWithQualName(v, f->f_globals, w);
[...]

--
assignee: docs@python
components: Documentation
messages: 156161
nosy: docs@python, eli.bendersky, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly
type: behavior
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com