[issue14660] Implement PEP 420: Implicit Namespace Packages

[Roundup Robot]

Roundup Robot  added the comment:

New changeset f26721ab3476 by Ned Deily in branch 'default':
Issue #14660: Install namespace_pkgs test directories and files.
http://hg.python.org/cpython/rev/f26721ab3476

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

I'm closing this issue. I'll open new issues as needed.

--
resolution:  -> fixed
stage: test needed -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 702009f3c0b1 by Eric V. Smith in branch 'default':
issue 14660: Implement PEP 420, namespace packages.
http://hg.python.org/cpython/rev/702009f3c0b1

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

I've modified zipimport to support namespace packages, and checked it in to the 
feature branch. This completes all of the functionality I think needs to be 
added. Next up is adding tests.

--
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Brett Cannon]

Brett Cannon  added the comment:

The joys of trying to shoehorn into an existing API. I mean short of adding a 
new sys.namespace_loader instead of an explicit keyword argument to FileFinder 
I can't think of a better solution.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

Ah. I didn't realize that reload called load_module. I'll back out the change I 
just made, then.

My point was that the original call to load_module isn't made through the 
normal "a finder returned me a loader, so I'll call it" code path. It's always 
made through the "I know I have a NamespaceLoader" path.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Brett Cannon]

Brett Cannon  added the comment:

What do you mean the loader is only needed to set __loader__? You need the 
loader to create the module (or find it in sys.modules to reload), and set all 
the attributes properly. If you do this then reloading namespace modules will 
become a special case compared to other loaders as imp.reload() calls 
module.__loader__.load_module().

This also prevents the creation of an importlib.find_module() which would 
return the loader to replace imp.find_module() since you now split the API.

I realize the finder/loader dichotomy seems superfluous (and most of the time 
it is), but it has already been heavily exposed and relied on and deviating 
from it for namespace modules runs the risk of hurting introspection.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +Yury.Selivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

I'd really prefer something like:

  return load_ns_module(fullname, namespace_path)

The point being that load_module() as defined in PEP 302 will never be called 
on NamespaceLoader. The loader only needs to exist to set module.__loader__, 
and load_module() would never be called from there.

So we could pass in a callable named load_ns_module to PathFinder.

Then NamespaceLoader's load_module function could be named load_ns_module, made 
a class or static method.

I think I'll experiment with this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric Snow]

Changes by Eric Snow :


--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Brett Cannon]

Brett Cannon  added the comment:

Yeah, having to pass in the name to load_module is silly. I'm seriously 
considering making it optional for some loaders when the name was passed in to 
the constructor.

One thing I would like to see is that PathFinder take a new, keyword-only 
argument of 'namespace_loader' or something that takes an object which is 
called with the module name and the list of paths to use for __path__ (and thus 
__path__[0] becomes __file__). That way it can be controlled by users if 
desired. I'm also fine with it having a default value of NamespaceLoader to 
start since I don't see people needing to comprehend what they are allowing in 
this case as I do for general file loaders.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

I created the NamespaceLoader in the feature branch. It has a load_module, but 
it's only ever called by the code in PathFinder.load_module:

loader = NamespaceLoader(namespace_path)
return loader.load_module(fullname)

namespace_path is what will become module.__path__. In order to keep the 
load_module API (single fullname argument), I pass it in to the constructor. 
There's no particular need for it to follow that API, but it does.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

Eric V. Smith  added the comment:

Right, that's a typo. I meant load_module(). I'm currently working on 
implementing the loader for namespace modules, so my comment about the loader 
is premature.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Brett Cannon]

Brett Cannon  added the comment:

Loaders are not meant to have a find_module method; that is purely for finders 
which can be distinct objects. So having a namespace loader is expected and 
there is no expectation that it have a find_module method (actually almost all 
of the loaders in importlib lack a find_module method).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14660] Implement PEP 420: Implicit Namespace Packages

[Eric V. Smith]

New submission from Eric V. Smith :

I have created a branch features/pep-420 where I'll be developing a proof of 
concept implementation of PEP 420.

I've checked in a basic version, but it has these issues:

- We need to decide how finders communicate that they've found part of
a namespace package. Per Brett's suggestion, I'm currently returning a
string that means "the returned path is part of a namespace package".
I think that's an okay design.

- I guess we need to create a "namespace loader", so we can initialize 
__loader__. It's a little odd because it would be a loader for which there's no 
need for a find_module method. I'm currently setting __loader__ to the finder, 
which is completely wrong, but keeps things working.

- test_import and test_importlib both fail because they're checking
that imports with no __init__.py fail. Those tests need to be removed.

- There are no tests yet.

--
assignee: eric.smith
messages: 159131
nosy: barry, brett.cannon, eric.smith, jason.coombs
priority: normal
severity: normal
status: open
title: Implement PEP 420: Implicit Namespace Packages
type: enhancement
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com