[issue14729] test_faulthandler test is too specific to work on Windows

2012-05-06 Thread Roundup Robot

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 2e71f25912d4 by Vinay Sajip in branch 'default':
Closes #14729: Allowed test to pass on Windows by adjusting the test condition 
slightly to allow for a Windows-specific error message.
http://hg.python.org/cpython/rev/2e71f25912d4

--
nosy: +python-dev
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14729] test_faulthandler test is too specific to work on Windows

2012-05-05 Thread Vinay Sajip

New submission from Vinay Sajip vinay_sa...@yahoo.co.uk:

In test_faulthandler.test_check_fatal_error, the test expects a response which 
matches


^Fatal Python error: {name}

{header}:
  File string, line {lineno} in module$
.strip()

On Windows, some more information is appended to the end of the message, so the 
match fails because of the trailing $. I propose to remove this $, so that the 
match succeeds just on the basis of the prefix.

Patch attached; I'll apply it soon, assuming you don't object.

--
components: Tests
files: test_faulthandler.diff
keywords: patch
messages: 159986
nosy: haypo, vinay.sajip
priority: normal
severity: normal
status: open
title: test_faulthandler test is too specific to work on Windows
versions: Python 3.3
Added file: http://bugs.python.org/file25460/test_faulthandler.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14729] test_faulthandler test is too specific to work on Windows

2012-05-05 Thread STINNER Victor

STINNER Victor victor.stin...@gmail.com added the comment:

 On Windows, some more information is appended to the end of the message (...)

Which information? What do write these information?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14729] test_faulthandler test is too specific to work on Windows

2012-05-05 Thread Vinay Sajip

Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:

 Which information? What do write these information?

The Windows error message has the same beginning, but an additional

This application has requested the Runtime to terminate it in an unusual 
way.\nPlease contact the application's support team for more information.

I believe this is added by Microsoft libraries - it's doesn't come from Python 
AFAIK.

See #9116 for a similar problem (look only at the initial report - most of the 
following comments go off at a tangent about preventing debugger popups).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14729] test_faulthandler test is too specific to work on Windows

2012-05-05 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

Vinay's patch solves the problem. +1 for committing.

--
nosy: +skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com