[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

Changes by R. David Murray :


--
title: Enhance Policy framework in preparation for adding "eamil6" policy as 
provisional -> Enhance Policy framework in preparation for adding email6 
policies as provisional

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Hynek Schlawack]

Changes by Hynek Schlawack :


--
nosy: +hynek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

Changes by R. David Murray :


--
components: +email

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Éric Araujo]

Éric Araujo  added the comment:

A few thoughts:

- If policies are intended to be expanded with the clone method, I think the 
classes (here Compat32) don’t need to be made public.

- IIUC the policy framework supersedes various arguments like manglefrom or 
max_line_length, right?  If so there could be a bit of doc explaining how to 
switch from old-style usage to new policy goodness.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Éric Araujo]

Éric Araujo  added the comment:

Oh and a minor thing to avoid whitespace-only commits later: our rst docs use 
three-space indents.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

R. David Murray  added the comment:

I checked the indent fix into the wrong branch in my repo.  It's in the other 
patch.  I could fix that if desired.

The reason for making the base class public is to allow subclassing.  Perhaps 
that is not needed for Compat32, though.

I don't think that the policy argument obsoletes the existing method options.  
It is easier to write:

  gen.flatten(msg, linesep='\r\n')

than it is to write

  gen.flatten(msg, policy=msg.policy.clone(linesep='\r\n'))

That is, when you want to make a change in just one method call, as opposed to 
globally, then the existing arguments are more convenient.

That said, a section in What's New describing when it might be a good idea to 
move to a global policy setting vs using the existing arguments may be 
worthwhile.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 9388c671d52d by R David Murray in branch 'default':
#14731: refactor email policy framework.
http://hg.python.org/cpython/rev/9388c671d52d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

R. David Murray  added the comment:

I decided to keep the Compat32 class public both because it simplifies the 
documentation and because there doesn't seem to be a good reason to hide it.

I'm leaving this issue open pending adding some discussion to What's New.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

Changes by R. David Murray :


--
assignee:  -> r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 8ba99b810b40 by R David Murray in branch 'default':
#14731: add preliminary What's New entry for policy framework.
http://hg.python.org/cpython/rev/8ba99b810b40

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[R. David Murray]

Changes by R. David Murray :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 09e97829ed1e by R David Murray in branch 'default':
Add news entries for #14731 and #12586.
http://hg.python.org/cpython/rev/09e97829ed1e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com