[issue14814] Implement PEP 3144 (the ipaddress module)
Georg Brandl added the comment: Please keep in mind that this should be committed before next weekend if it is to make 3.3. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Changes by Georg Brandl ge...@python.org: -- priority: deferred blocker - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: I'm just waiting for a review. If Nick has no time for that, perhaps I can commit anyway since this is just adding documentation. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: I'm at the pyconau sprints for the next couple of days - I'll make sure this is dealt with. On Aug 19, 2012 10:07 PM, Eli Bendersky rep...@bugs.python.org wrote: Eli Bendersky added the comment: I'm just waiting for a review. If Nick has no time for that, perhaps I can commit anyway since this is just adding documentation. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Changes by Nick Coghlan ncogh...@gmail.com: -- assignee: - ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset 258558e36d8a by Nick Coghlan in branch 'default': Issue #14814: document the Interface APIs and fix various problems with the string representations (initial patch by Eli Bendersky). http://hg.python.org/cpython/rev/258558e36d8a -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset 811d91591f73 by Nick Coghlan in branch 'default': Close #14814: Avoid depending on struct by using newer features. Also use enumerate where appropriate (patch by Serhiy Storchaka). Declaring PEP 3144 final at this point - any further changes to code or docs can go in new issues. http://hg.python.org/cpython/rev/811d91591f73 -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Here's a patch adding documentation to the *Interface classes. I must say I'm not very psyched about the with_* methods. Their outputs are inconsistent, unlike in *Network, where all return strings. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Changes by Eli Bendersky eli...@gmail.com: Added file: http://bugs.python.org/file26736/ipaddr_refdoc_interface.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody added the comment: There's no reason why IPv?Network().with_prefixlen can't return str(self). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: pmoody - you mean IPv?Interface, right? The network classes consistently return strings in with_* methods -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody added the comment: sorry, yes, I meant the interface classes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Attaching a new patch that fixes the with_* methods to be more consistent, and the relevant tests too. The doc is now consistent as well. For some reason IPv6Interface.with_netmask also returned the prefixlen representation. The test justified it by quoting RFC3513/2.3 but I did not see anything there that really forces us to do that. Perhaps the with_netmask/with_hostmask representations are nonsensical for v6 and we keep them for v4 compatibility, but in that case let them be compatible! -- Added file: http://bugs.python.org/file26754/ipaddr_interface.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset b513ad06d1fa by Nick Coghlan in branch 'default': Issue 14814: Docs work showed some more cases of networks pretending to be addresses and highlighted the weird approach to implementing the 'is_whatever' properties. Impl now illustrates far more clearly that networks have a property if both their network and broadcast addresses have that property http://hg.python.org/cpython/rev/b513ad06d1fa -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Nick, your commit incorporates my latest patch (ipaddr_refdoc_network.2.patch), right? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: It actually wasn't meant to, as I only meant to commit the code changes (I was still working on the docs, using your patch as a starting point). However, it makes more sense to just finish my changes and commit them rather than reverting anything. (Good attempt by the way, but it was your 'networks have all the attributes of addresses' that got me digging deeper, since that isn't meant to be true any more) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset cf8d42596a44 by Nick Coghlan in branch 'default': Issue #14814: Finish review of ipaddress network object docs (initial patch was by Eli Bendersky) http://hg.python.org/cpython/rev/cf8d42596a44 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset cf9526db1a7e by Nick Coghlan in branch 'default': Issue #14814: Remove redundant property from interface objects - prefixlen can be accessed via the associated network object http://hg.python.org/cpython/rev/cf9526db1a7e -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: I'm still not overjoyed with the this isn't documented here, go read it over there situation. However, duplicating the text everywhere isn't ideal either. So, let's finish it up with my current approach: explicitly listing the methods and attributes on each class where the documentation is elsewhere. For Interface objects, there's no need to repeat the documentation for the corresponding Address object, since there's a real inheritance relationship there. Fortunately, that makes the list of attributes still to be documented fairly short: ip (raw address with no network info) network (the network definition) with_prefixlen with_hostmask with_netmask -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset abbae7314b52 by Nick Coghlan in branch 'default': Issue #14814: Attempt to clarify network address and broadcast address for less experienced users http://hg.python.org/cpython/rev/abbae7314b52 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Attaching an updated patch that completes the documentation of network objects (attributes, methods and operations). Additionally, inserted the provisional package note and a new in 3.3 notice. -- Added file: http://bugs.python.org/file26643/ipaddr_refdoc_network.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment:
I'm looking at the docs. Started with the HOWTO (Doc/howto/ipaddress.rst)
This example:
net4 = ipaddress.ip_network('192.0.2.0/24')
for x in net4.iterhosts():
print(x)
Seems to be wrong:
...
Traceback (most recent call last):
File stdin, line 1, in module
AttributeError: 'IPv4Network' object has no attribute 'iterhosts'
I wonder if it simply needs to iterate the net4 object itself.
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14814
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: P.S. I intend to prepare patch(es) eventually, but I will document the problems I find here, in case anyone is interested to discuss. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Ah, probably hosts() replaced iterhosts() -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Attaching a patch for the howto -- Added file: http://bugs.python.org/file26612/ipaddr_howto.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: FWIW I would prefer this HOWTO to be part of the document itself. Splitting a document to two parts and keeping them separated is problematic exactly for the same reasons as external documentation in general - it can be forgotten when things get updated. HOWTOs are good to discuss concepts that don't pertain to a specific modules, and so there is no other natural place to place them. Tutorials that only discuss a single module belong in its doc page together with the reference - I think there are plenty of examples in the stdlib docs where this is the case. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: The docs don't mention that addresses can also be packed in bytes -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: No, the HOWTO should be separate. Having them in the same document makes for something that is worse as both a tutorial and as an API reference (just look at argparse). Yes, that means there are three places to update (code, reference, tutorial). There are three places to update regardless - the only question is whether two of those places are jammed awkwardly into the same file. Handling this will hopefully become more natural as the howto/tutorial section of the docs grows larger. The main problem with the ipadddress docs at the moment is extracting the docstrings for the methods and including them in the reference docs in a sane way (i.e. without excessive duplication of material, as Terry and I discussed above). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Serhiy Storchaka added the comment: If this issue is not yet closed, here are a patch with few edits: using int.to_bytes/from_bytes instead struct.pack/unpack and using enumerate() instead range(len()). -- Added file: http://bugs.python.org/file26620/ipaddress-modernize.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: I disagree about the HOWTO vs. doc thing, but I don't see it as a major issue so I won't dwell on it. I'm now in the process of throwing together a patch for the reference doc - also bundling the address objects together, the network objects together, etc. BTW I saw there was disagreement about whether packed bytes should be accepted as addresses. ATM they are in the code, so should this be documented? I want to provide a precise documentation of what exactly is a valid address. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Alright, attaching an attempt at improving the reference docs. This only handles the address objects for now: 1. Grouping address objects together, network objects together, interface objects together 2. Explain that everything IPv4Address exposes is also exposed by IPv6Address 3. Document v4's attributes in a generic manner 4. Document v6's specific attributes 5. Document operators 6. Precisely define the address format(s) accepted by the constructors If this looks good to folks, I can commit and then proceed to similarly explaining the network and interface objects. -- Added file: http://bugs.python.org/file26621/ipaddr_refdoc.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: Thanks Eli, that looks like a great start to me. And yeah, the separate vs integrated tutorial argument is an ongoing one that isn't going to be resolved by this issue :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Thanks Nick. I've addressed your review comments and will be pushing the doc update. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset 586eb57e06ba by Eli Bendersky in branch 'default': Issue #14814: reorganize ipaddress documentation and document all attributes of IPv[46]Address objects http://hg.python.org/cpython/rev/586eb57e06ba -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot added the comment: New changeset 07ddf5ecaafa by Eli Bendersky in branch 'default': Issue #14814: fix some typos in howto/ipaddress.rst http://hg.python.org/cpython/rev/07ddf5ecaafa -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: By the way, Nick, was not this module intended to be introduced as provisional in 3.3? At least PEP 411 lists it as one of the candidates. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Eli Bendersky added the comment: Attaching part 1 of the patch for documenting the network objects. Contains general introduction, detailed documentation of constructors and all attributes. Left to document: methods, operations (like iterating, in, comparison operators) -- Added file: http://bugs.python.org/file26626/ipaddr_refdoc_network.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan added the comment: Yes, the module docs should have the provisional notice. Good catch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Georg Brandl ge...@python.org added the comment: IIUC only docs are missing now? That's not a b2 blocker then. -- priority: release blocker - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Unassigning for the moment - I'm busy fighting fires in pkgutil (which is actually broken due to the import changes). If someone else has time to flesh out the method and data attribute documentation for the ipaddress classes, that would be great. -- assignee: ncoghlan - components: +Documentation -Library (Lib) stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 18c1d4d60bdf by Nick Coghlan in branch 'default': Issue 14814: Further error case testing coverage and cleanups http://hg.python.org/cpython/rev/18c1d4d60bdf -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Serhiy Storchaka storch...@gmail.com added the comment: _get_prefix_length now used only in test. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 45265ecaa3e4 by Nick Coghlan in branch 'default': Issue 14814: Remove dead function (noticed by Serhiy Storchaka) http://hg.python.org/cpython/rev/45265ecaa3e4 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 7aa75ea4116d by Nick Coghlan in branch 'default': Issue 14814: The new systematic tests aren't just about error reporting any more - change names accordingly. Added and tweaked some example to ensure they were covering the intended code paths http://hg.python.org/cpython/rev/7aa75ea4116d -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 16ff4889a858 by Nick Coghlan in branch 'default': Issue 14814: Provide more informative error messages in ipaddress, and ensure that errors are caught as expected http://hg.python.org/cpython/rev/16ff4889a858 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: There's actually one semantic change in that last patch: IPv4Address (et al) will now accept leading zeroes in those cases where they're *not* ambiguous (i.e. values less than 8, which have identical representations in both decimal and octal notation). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Also, I noted the provisional API status in the NEWS message, but I wonder if it would make more sense to leave that kind of note for the commit messages. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset af4ae710daf3 by Nick Coghlan in branch 'default': Issue 14814: Make the ipaddress code easier to follow by using newer language features (patch by Serhiy Storchaka) http://hg.python.org/cpython/rev/af4ae710daf3 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Many of Serhiy's tweaks were also micro-optimisations, but I committed them mainly because I found them easier to read. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset d03dbc324b60 by Nick Coghlan in branch 'default': Issue 14814: Explain how to get more error detail in the ipaddress tutorial, and tweak the display for octet errors in IPv4 (noticed the formatting problem when adding to the docs) http://hg.python.org/cpython/rev/d03dbc324b60 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 86d3b4067f74 by Nick Coghlan in branch 'default': Issue 14814: Further clean ups to the ipaddress tutorial http://hg.python.org/cpython/rev/86d3b4067f74 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 2e9cba1d1554 by Nick Coghlan in branch 'default': Issue 14814: Correctly return NotImplemented from ipaddress._BaseNetwork.__eq__ http://hg.python.org/cpython/rev/2e9cba1d1554 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 9b359b6c9a39 by Nick Coghlan in branch 'default': Issue 14814: Ensure ordering semantics across all 3 entity types in ipaddress are consistent and well-defined http://hg.python.org/cpython/rev/9b359b6c9a39 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Serhiy Storchaka storch...@gmail.com added the comment: Should do _version and _max_prefixlen be instance members? Or they can be class members as _HEX_DIGITS? -- nosy: +storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: My guess would be that they're intended as a micro-optimisation (instance lookups should be faster than class attribute lookups). You do lose on the memory front though, since they make the instances bigger. Without a micro benchmark of any kind, I'm not inclined to mess with them at this point. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: FWIW, if we *were* going to micro-optimise ipaddress, one of the first places I'd start is using __slots__ to try to bring the instance size down (since any application using the module is likely to end up creating a *lot* of these objects). There are more significant things to worry about at this stage, though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Éric Araujo mer...@netwok.org added the comment: Any reason for not using functools.total_ordering? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Yup, it's broken (doesn't handle NotImplemented correctly) and Raymond isn't keen on fixing it. I should add a link to the relevant tracker issue in a comment, though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset b7cfdb48af62 by Nick Coghlan in branch 'default': Issue 14814: Better handling of cases where octet/hextet parsing fails, including ensuring that tracebacks are still clean even when calling class constructors directly http://hg.python.org/cpython/rev/b7cfdb48af62 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 30e8f2242190 by Nick Coghlan in branch 'default': Issue 14814: Eliminate bytes warnings from ipaddress by correctly throwing an exception early when given bytes data of the wrong length. Also removes 2.x backwards compatibility code from associated tests. http://hg.python.org/cpython/rev/30e8f2242190 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset d9c98730e2e8 by Nick Coghlan in branch 'default': Issue 14814: %s implies coercion with str() - remove a lot of redundant str() calls from the ipaddress implementation http://hg.python.org/cpython/rev/d9c98730e2e8 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Just letting people know I'm working on a patch that updates the class constructors to give meaningful error messages for malformed addresses, instead of assuming that users can figure it out just by looking at the address. I'm also updating the test suite to check that these more detailed errors are being reported as expected. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody pyt...@hda3.com added the comment: Reported externally, ipaddress tries to parse 4 character strings as bytes. https://groups.google.com/forum/?hl=en_USfromgroups#!topic/ipaddr-py-dev/j6FkeJtsBz4 -- Added file: http://bugs.python.org/file26210/ipaddress-bytes-str.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody pyt...@hda3.com added the comment: one more patch, superseding the last patch. also reported externally, the v6 parser would incorrectly parse some v6 addresses. http://code.google.com/p/ipaddr-py/issues/detail?id=97 -- Added file: http://bugs.python.org/file26211/ipaddress-bytes-str-v6-parsing.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: Try running the test like: ./python[.exe] -bb -Wd -m test test_ipaddress -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody pyt...@hda3.com added the comment: Hynek, I don't see that error when I run the tests on a freshly built python. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Georg Brandl ge...@python.org added the comment: Moving back to blocker for beta2. -- priority: deferred blocker - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment:
Currently, we get the following warnings:
[ 26/369] test_ipaddress
/home/vagrant/default/Lib/ipaddress.py:1401: BytesWarning: str() on a bytes
instance
addr = str(address).split('/')
/home/vagrant/default/Lib/ipaddress.py:2004: BytesWarning: str() on a bytes
instance
addr = str(address).split('/')
/home/vagrant/default/Lib/ipaddress.py:1258: BytesWarning: str() on a bytes
instance
Hadn't time yet to look into it, I might update the ticket as soon as I had.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14814
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: Ok I looked into it. It uses str() to convert objects into text representation which it then parses. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: And the origin of the bytes seems to be: # Compatibility function to cast str to bytes objects _cb = lambda bytestr: bytes(bytestr, 'charmap') -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Terry J. Reedy tjre...@udel.edu added the comment: the interfaces of the v4 and v6 variants are deliberately very similar I am hoping that means 'identical, once the obvious translations are made': v4 to v6, xxx.xxx.xxx.xxx to whatever the v6 notation is, and anything else? documenting everything twice seems like a rather user hostile thing to do. Agreed. Please factor out common stuff. I see two choices. 1. Document in parallel after an intro explaining the translations 4(args) 6(args) Return ... (either in 4 terms which user translate for 6 or generic terms). # This might be better if you expect people to be doing one type of thing with both v4 and v6. 2. Document serially, first v4 stuff then v6 stuff (at present, though order might be reversed in the future ;-). v4 stuff --- 4(args) Return ... v6 stuff --- The following v6 functions are the same as the v4 functions above, except that ipv4address'es become ipv6address'es etc. 6(args) # This might be better if you expect people to be doing multiple things with either v4 or v6, but not both. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: My current thoughts are to avoid the usual approach of embedding the method and property definitions in the class definitions, and instead have separate sections under [1] for IP Addresses IP Interfaces IP Networks Inside each of those sections, document the constructors directly under the section heading, and then separate out these subsections: Common IP kind properties and methods IPv4 kind properties and methods (if any) IPv6 kind properties and methods (if any) [1] http://docs.python.org/dev/library/ipaddress#representing-ip-addresses-and-networks -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
pmoody pyt...@hda3.com added the comment: I'm not sure if this is still an issue, but returning the address in a packed format was an early issue (http://code.google.com/p/ipaddr-py/issues/detail?id=14). No objections from me for removing it from the network objects or for removing the packed constructor (I'm assuming there isn't any python-ism about being able to copy-construct an object from any valid representation of said object) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: I looked into the idea of treating networks as containers of interface objects rather than addresses - it turns out it gets messy very quickly, because you definitely want your network address and broadcast address to be ordinary addresses, so making the host addresses interfaces instead of ordinary addresses would lead to inconsistent behaviour. 739f5c725958 is the result of that investigation (I forgot to mention this issue in the checkin message) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset cacf3b1e20da by Nick Coghlan in branch 'default': Issue #14814: Add first draft of PEP 3144 ipaddress module documentation (initial patch by Sandro Tosi) http://hg.python.org/cpython/rev/cacf3b1e20da -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: OK, dropping to deferred blocker status, as I think the docs are now good enough for beta 1. We still want to get the public methods and properties for the various objects documented during the beta period, though. I'm not sure how best to handle that, though - the interfaces of the v4 and v6 variants are deliberately very similar, so documenting everything twice seems like a rather user hostile thing to do. -- priority: release blocker - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Éric Araujo mer...@netwok.org added the comment: A small markup error in the doc: in “.. exception:: Custom(ValueError)” (as in “.. class:: SomeThing(BaseThing)”), the parens are supposed to contain the signature for the constructor, not the base classes. (Sorry I’m not replying to the python-checkins email; my diff colorizer extension was disabled due to mailer version update so I delete the -checkins messages and to read changesets on hgweb now.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Éric Araujo mer...@netwok.org added the comment: Forgot the reference: http://sphinx.pocoo.org/domains.html#directive-py:exception -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 4aeb5b9b62d7 by Hynek Schlawack in branch 'default': #14814: Remove redundant code from ipaddress.IPv6Network http://hg.python.org/cpython/rev/4aeb5b9b62d7 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset cca2a1cc9598 by Hynek Schlawack in branch 'default': #14814: ipaddress: refactor dup code, minor janitoring, bump coverage http://hg.python.org/cpython/rev/cca2a1cc9598 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: So one more issue from me: as indicated, the constructor using packed of IPv6Networks is broken (wrong indent). The question is whether we want to be able to construct using packed at all. Also the strict check doesn't make any sense because the net mask is ALL_ONES so if the construction of the IPv6Address succeeds, there's no way the check can fail. -- Added file: http://bugs.python.org/file25829/ipaddress-ipv6network-constructor.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 6808a72fc9ec by Hynek Schlawack in branch 'default': #14814: Use correct comparison for IP addresses http://hg.python.org/cpython/rev/6808a72fc9ec -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset df6d1a4d83fa by Hynek Schlawack in branch 'default': #14814: Remove dead code from ipaddress http://hg.python.org/cpython/rev/df6d1a4d83fa -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: Dear friends of ip addresses, I made something: refactor dup code, minor janitoring, bump coverage - remove duplicate netmask/hostmask code (it was identical in ipv4address interface) - make two ifs more pythonic - Refactor and fix packed property for ipv6 addresses and networks. Apparently nobody has ever used this. :) - Test coverage is now at 97%, the rest are mostly unreachable safeguards. Please have a look at it if you will. The test suite passes of course. That said, I'm pretty sure the constructor for IPv6Network is broken (particularly constructing from int and packed – also the the strict tests in these two cases don't make any sense as net mask is always ALL_ONES). I'll be dreaming of ip addresses tonight. ;) -- Added file: http://bugs.python.org/file25824/ipaddress-refactor-and-bump-coverage.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Hynek's latest patch mostly looks good to me, but I think the packed property on network definitions just needs to go away. The original ipaddr API that is the basis for ipaddress doesn't really have a clear distinction between network definitions and IP addresses, and I think the current network code is still showing some of the legacies of that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Also noting a TODO item here: currently, the address-producing operations on network objects just produce vanilla address objects of the appropriate version. My question is, should we have those operations create interface objects instead? My current thought is that the latter would lose less information, since you can easily strip the network details later if desired. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: With a cross link from the header of the module reference to the howto guide, I think what Sandro posted is good enough for a first draft. Once the basic content is checked in, then I'll tinker a bit to figure out a more logical order (and possibly move some details from the current howto guide into the module reference). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset facdca62aa68 by Sandro Tosi in branch 'default': Issue #14814: minor spelling fixes http://hg.python.org/cpython/rev/facdca62aa68 New changeset 4b4044292d09 by Sandro Tosi in branch 'default': Issue #14814: use print() function http://hg.python.org/cpython/rev/4b4044292d09 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Sandro Tosi sandro.t...@gmail.com added the comment: Attached is a draft of the module documentation. I didn't commit yet cause we might want to rework it deeply. Else we can just commit the patch and let the comments coming as additional diffs. -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Sandro Tosi sandro.t...@gmail.com added the comment: and the patch... -- Added file: http://bugs.python.org/file25800/ipaddress_module_doc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: As discussed on IRC, please: - add a link to the tutorial - add some typical use cases to the header of the api - change the name of the tutorial from Howto to HOWTO or a more descriptive title that doesn't contain the word how to at all. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 0eb63de72e96 by Hynek Schlawack in branch 'default': #14814: Remove 2.x's new-style classes syntax from ipaddress http://hg.python.org/cpython/rev/0eb63de72e96 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 000cc4e0e1cd by Hynek Schlawack in branch 'default': #14814: Fix errror message creation in ipaddress.collapse_addresses http://hg.python.org/cpython/rev/000cc4e0e1cd -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: It's funny how raising the test coverage _always_ uncovers lurking bugs in obscure branches. :) Patch attached, let me know if I got it wrong – would commit otherwise. A few quick side-note: does the __version__ variable make sense in stdlib? -- Added file: http://bugs.python.org/file25775/fix-type-error.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset bd2c2def77a7 by Hynek Schlawack in branch 'default': #14814: Remove stale __hex__ method from ipaddress http://hg.python.org/cpython/rev/bd2c2def77a7 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 7d252dbfbee3 by Eli Bendersky in branch 'default': Issue 14814: Add namespaces keyword arg to find(*) methods in _elementtree. http://hg.python.org/cpython/rev/7d252dbfbee3 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 63d2c9affb11 by Hynek Schlawack in branch 'default': #14814: Some PEP8 adjustments and dead code weeding http://hg.python.org/cpython/rev/63d2c9affb11 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Hynek Schlawack h...@ox.cx added the comment: One last wish: could we curb the copyright header a bit? I don't know the exact policy on that but as other modules don't have that I presume we could do without/with a shorter one. If we have one, I'd rather add something like based on the original ipaddress module by Peter Moody. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Nick Coghlan ncogh...@gmail.com added the comment: Yeah, only the first two lines of the copyright header are really needed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14814] Implement PEP 3144 (the ipaddress module)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset f70e12499d05 by Nick Coghlan in branch 'default': Issue #14814: In the spirit of TOOWTDI, ditch the redundant version parameter to the factory functions by using the appropriate direct class references instead http://hg.python.org/cpython/rev/f70e12499d05 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14814 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
