[issue14817] pkgutil.extend_path has no tests

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
nosy:  -nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Windson Yang]

Windson Yang  added the comment:

I added some tests in the PR. Actually, there are some tests for extend_path 
already (see 
https://github.com/python/cpython/blob/master/Lib/test/test_pkgutil.py#L235). 
However, I didn't test every line of the code in the extend_path function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Windson Yang]

Change by Windson Yang :


--
keywords: +patch
pull_requests: +12795
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

@Windson please open a PR for review with your code.

--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Windson Yang]

Windson Yang  added the comment:

My base idea would be some unittests for the function like:

class ExtendPathBaseTests(unittest.TestCase):
def test_input_string(self):
path = 'path'
name = 'foo'
self.assertEqual('path', pkgutil.extend_path(path, name))

def test_parent_package_raise_key_error(self):
path = ['path']
# sys.modules['foo'] raise KeyError
name = 'foo.bar'
self.assertEqual(['path'], pkgutil.extend_path(path, name))

def test_parent_package_raise_attr_error(self):
path = ['path']
# datetime module don't have __path__ attr
name = 'datetime.date'
self.assertEqual(['path'], pkgutil.extend_path(path, name))

I would move forward if we agreed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Windson Yang]

Windson Yang  added the comment:

I would like to work on this and make a PR.

--
nosy: +Windson Yang
type:  -> enhancement
versions: +Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Mark Lawrence]

Mark Lawrence added the comment:

@Eric will you pick this up again?

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Antoine Pitrou]

Antoine Pitrou  added the comment:

This has broken all 3.x buildbots.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Eric V. Smith]

Eric V. Smith  added the comment:

This code does not clean up correctly. It needs to remove the added modules in 
sys.modules. I'll eventually clean it up, once issue 14715 is addressed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Eric V. Smith]

Eric V. Smith  added the comment:

I'm going to leave this open until better tests are added. The one I did add it 
very simple, but it's good enough for the changes I'm about to make.

--
nosy:  -python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 48cb6b67d306 by Eric V. Smith in branch '3.2':
Issue #14817: Add rudimentary tests for pkgutil.extend_path.
http://hg.python.org/cpython/rev/48cb6b67d306

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14817] pkgutil.extend_path has no tests

[Eric V. Smith]

New submission from Eric V. Smith :

Subject says it all.

There are also no tests of .pkg files.

--
components: Tests
keywords: easy
messages: 160751
nosy: eric.smith
priority: normal
severity: normal
status: open
title: pkgutil.extend_path has no tests

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com