[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Fixed in issue2175.

--
resolution:  - out of date
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[A.M. Kuchling]

Changes by A.M. Kuchling a...@amk.ca:


--
nosy:  -akuchling

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy:  -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
dependencies: +Expat parser parses strings only when XML encoding is UTF-8

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[A.M. Kuchling]

Changes by A.M. Kuchling li...@amk.ca:


--
assignee: akuchling - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

There's a one line patch in msg57749 and some unit tests are attached so would 
a committer take a look please.  Also note that #2174 and #2175 are related.

--
nosy: +BreamoreBoy
stage:  - patch review
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Terry J. Reedy]

Terry J. Reedy tjre...@udel.edu added the comment:

Are this and the other issues still problems in 2.7 (rc out now) and 3.1?

--
nosy: +tjreedy
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[A.M. Kuchling]

A.M. Kuchling added the comment:

Could you please provide a simple little test case for the bug?  I'd
like to add a test when I commit the change, but you can probably boil
the problem down into a test faster than I can.

--
nosy: +akuchling

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1483
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Yitz Gale]

Yitz Gale added the comment:

Oops, obvious typo, sorry:

-if source.getByteStream() is None:
+if source.getCharacterStream() is None and source.getByteStream() is 
None:

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1483
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1483] xml.sax.saxutils.prepare_input_source ignores character stream in InputSource

[Yitz Gale]

New submission from Yitz Gale:

In the documentation for xml.sax.xmlreader.InputSource objects
(section 8.12.4 of the Library Reference) we find that
users of InputSource objects should use the following
sequence to get their input data:

1. If the InputSource has a character stream, use that.
2. Otherwise, if the InputSource has a byte stream, use that.
3. Otherwise, open a URI connection to the system ID.

prepare_input_source() skips step 1.

This is a one-line fix in Lib/xml/sax/saxutils.py:
-if source.getByteStream() is None:
+if source.getCharacterStream is None and source.getByteStream() is 
None:

--
components: Library (Lib)
messages: 57737
nosy: ygale
severity: normal
status: open
title: xml.sax.saxutils.prepare_input_source ignores character stream in 
InputSource
versions: Python 2.5

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1483
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com