[issue14879] invalid docs for subprocess exceptions with shell=True

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Irit Katriel]

Irit Katriel  added the comment:


New changeset d0c61753036dcae292d49aa8ddac555062da6b76 by Miss Islington (bot) 
in branch '3.10':
bpo-14879: [doc] clarify how to check for errors from subprocess.Popen(..., 
shell=True) (GH-26755) (GH-27288)
https://github.com/python/cpython/commit/d0c61753036dcae292d49aa8ddac555062da6b76


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 5ffbb05f1c3c952588ba5c1927da0e8223f5aaa7 by Miss Islington (bot) 
in branch '3.9':
bpo-14879: [doc] clarify how to check for errors from subprocess.Popen(..., 
shell=True) (GH-26755) (GH-27289)
https://github.com/python/cpython/commit/5ffbb05f1c3c952588ba5c1927da0e8223f5aaa7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[miss-islington]

Change by miss-islington :


--
pull_requests: +25831
pull_request: https://github.com/python/cpython/pull/27289

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 8.0 -> 9.0
pull_requests: +25830
pull_request: https://github.com/python/cpython/pull/27288

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 50ffbe3dafcae7826d114df61d56c7ac45a6358c by Jack DeVries in 
branch 'main':
bpo-14879: [doc] clarify how to check for errors from subprocess.Popen(..., 
shell=True) (GH-26755)
https://github.com/python/cpython/commit/50ffbe3dafcae7826d114df61d56c7ac45a6358c


--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Jack DeVries]

Change by Jack DeVries :


--
keywords: +patch
nosy: +jack__d
nosy_count: 6.0 -> 7.0
pull_requests: +25340
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26755

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +easy
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.2, Python 
3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Nick Coghlan]

Nick Coghlan  added the comment:

I would add a simple note to the exceptions section:

"Note, when "shell=True", OSError will be raised by the child only if the 
selected shell itself cannot be found. To determine if the shell failed to find 
the requested application, it is necessary to check the return code or output 
from the subprcess."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +eric.araujo, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[R. David Murray]

R. David Murray  added the comment:

Heh.  Maybe what we ought to do is drop the shell argument and make everyone 
build their own shell invocations :)

Actually, an API refactor where a shell call looks like this might be kind of 
cool:

  Popen(shell_cmd('echo magic'))

where shell would return a list.

As for the ValueError, yeah, it's vague, but I think that the only information 
that sentence is trying to convey is that ValueError is one of the exceptions 
you might get when calling Popen.  Exactly what you get it for is pretty much 
an implementation detail.  If someone wants to grovel through the code and 
figure out all the things that can raise ValueError, we could see if there's 
any sensible way to turn that into a sentence, but it might not be easy.  Short 
of that, perhaps we could  drop the existing qualifier and just say "Popen may 
also raise ValueError."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Chris Rebert]

Chris Rebert  added the comment:

The term "invalid arguments" in "A ValueError will be raised if Popen is called 
with invalid arguments." is still vague. One could well argue that a 
nonexistent executable or bad command is "invalid". Anything resulting in an 
OSError can be considered "invalid" in a sense. The ValueError sentence should 
use a different descriptor or else include a qualifier.

+1 on calling out the shell=True case.
(My but how the `shell` argument complicates everything...)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[R. David Murray]

R. David Murray  added the comment:

I don't think that those additions make anything clearer, I'm afraid.

"child python process" would seem to imply raised in the new python running in 
the child process, which is clearly not true.

Hmm.  I seem to remember having this discussion before.  The current statement 
is in fact exactly correct.  When shell=True the new program being run is 'sh' 
(or similar).  So the error message is coming from the program being run 
successfully by subprocess.  End of story.

So, we could add a clarfication: "If shell=True, the 'new program' being run is 
the shell, which may generate its own errors based on the shell command passed 
to it (such as command not found).  These will not result in exceptions."

--
nosy: +r.david.murray
versions:  -Python 2.6, Python 3.1, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[Chris Rebert]

Chris Rebert  added the comment:

Eh, just needs clarification along the lines of:

"Exceptions raised in the child ++Python++ process"

"A ValueError will be raised if Popen is called with invalid arguments
++whose validity is not dependent upon the state of the environment++."

--
nosy: +cvrebert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14879] invalid docs for subprocess exceptions with shell=True

[anatoly techtonik]

New submission from anatoly techtonik :

http://docs.python.org/library/subprocess.html#exceptions documentation is 
wrong at least for the case when shell=True on Linux. An attempt to execute a 
non-existent file with:

  process = subprocess.Popen("sdfsdf", shell=True, stdout=subprocess.PIPE, 
stderr=errpipe)
  out, err = process.communicate()
  print out

Results in a message "/bin/sh: sfs: command not found" with no exceptions. 
Other statements may be invalid too.

--
assignee: docs@python
components: Documentation, Library (Lib)
messages: 161329
nosy: docs@python, techtonik
priority: normal
severity: normal
status: open
title: invalid docs for subprocess exceptions with shell=True
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com