[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Irit Katriel]

Irit Katriel  added the comment:

The code in urllib is different now but I see that a test very similar to the 
one in the patch exists, so was this fixed?

https://github.com/python/cpython/blob/e68c67805e6a4c4ec80bea64be0e8373cc02d322/Lib/test/test_urllib.py#L813

--
nosy: +iritkatriel
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Senthil Kumaran]

Senthil Kumaran  added the comment:

> so was this fixed?

Irit, not really. This is adding another hook called "progress hook" in 
addition to the "report hook". We need to evaluate if this is really required.

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Irit Katriel]

Change by Irit Katriel :


--
stage: test needed -> 
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Rafael Zanella]

Rafael Zanella  added the comment:

Simple (lazy) test case added.

It just replicates one test case of reporthook to work with progresshook.

The testcases assume the hard-coded value of blocksize on urllib, maybe it 
should become a public property.

Also commented on diff: http://bugs.python.org/review/1490929/show

--
nosy: +zanella
Added file: http://bugs.python.org/file21766/test_urllib.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Mark Lawrence]

Changes by Mark Lawrence :


--
versions: +Python 3.2 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
assignee:  -> orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Krzysztof Pawlik]

Krzysztof Pawlik <[EMAIL PROTECTED]> added the comment:

Attached patch adds new argument: progresshook - it will be passed two
arguments: count of downloaded bytes and total file size (or -1 if it's
not available).

Introducing new argument instead of modifying reporthook maintains
backwards compatibility, also allows removal of reporthook at one point
in the future.

This patch is against r30 SVN tag.

--
keywords: +patch
nosy: +nelchael
Added file: http://bugs.python.org/file12271/progresshook.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Daniel Diniz]

Daniel Diniz  added the comment:

Patch has docs, tests needed.

--
nosy: +ajaksu2, orsenthil
stage:  -> test needed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[akira]

akira added the comment:

Related issue 16409

--
nosy: +akira

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1490929] urllib.retrieve's reporthook called with non-helpful value

[Daniel Diniz]

Changes by Daniel Diniz :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com