[issue15067] Clean up the sqlite3 docs
Roundup Robot added the comment: New changeset 2e13f0d49b8e by Zachary Ware in branch '2.7': Issue #15067: Remove reference to a rejected PEP. http://hg.python.org/cpython/rev/2e13f0d49b8e New changeset 4a2dabac976d by Zachary Ware in branch '3.4': Issue #15067: Port 2.7 sqlite3 docs to 3.4 http://hg.python.org/cpython/rev/4a2dabac976d New changeset 2c7ebb930b64 by Zachary Ware in branch 'default': Closes #15067: Merge port of 2.7 sqlite3 docs. http://hg.python.org/cpython/rev/2c7ebb930b64 -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file27829/sqlite3_cleanup_2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file27830/sqlite3_cleanup_3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Zachary Ware added the comment: Coming back to this 5 months later and looking into it myself, I find that the sqlite3 docs really need a bit of a cleanup all around, especially in all three 3.x branches. Several minor changes were made by Raymond Hettinger in d229032dc213 and a few subsequent changesets 6 months ago in the 2.7 branch, but none of those ever made it to 3.x. (Raymond, those changes in the past are why I made you nosy on this one) To address the offending sentence that brought this issue about in the first place, after rereading it and thinking about it some more, what's there does make sense: this module uses the recipe of PEP 246, regardless of that PEP's status. However, I don't think it's helpful to mention it in the documentation, as it kind of gives the impression that this feature was rejected for the whole of Python, but this stdlib module goes ahead and does it anyway. For that reason, I propose to just drop that two-line paragraph entirely. Everything about that feature still makes sense without that paragraph, even though the 'protocol' bit seems a bit weird. I wonder though, should that feature be deprecated on the basis of using a rejected PEP as well as TOOWTDI violation (or should I open another issue to that effect anyway)? In the same vein as Raymond's earlier 2.7 changes (namely the SQL cleanup and capitalization he did), the 2.7 patch I've attached goes through and does the same for all of the included scripts in Doc/includes/sqlite3 as well as removing the bit about PEP 246. The 3.2 patch does everything in the 2.7 patch, plus bringing the 3.2 docs in line with the 2.7 docs. I do have a question, though; the footnote about enabling loadable extensions is different in the 2.7 and 3.2 docs. Which one is right, or are both right for their respective versions? Thanks, Zach -- keywords: +patch nosy: +rhettinger title: sqlite3 docs reference PEP 246, which was rejected - Clean up the sqlite3 docs versions: +Python 3.4 Added file: http://bugs.python.org/file27829/sqlite3_cleanup_2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file27830/sqlite3_cleanup_3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Zachary Ware added the comment: I failed to mention, the 3.2 patch also removes the line (and comment) about db_row based solutions since it seems from a quick Google search that db_row is a library created back in the 2.2 days that I didn't quickly see a 3.x version for. Also, the comment made it seem like that line wouldn't be missed too much anyway :). I left it in the 2.7 version though; as I assume it would be reasonably easy to get db_row to work with 2.7 if someone wanted to. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Ezio Melotti added the comment: I think it would be better to keep the capitalization of the queries separate from the rest of the patch. -- nosy: +ezio.melotti stage: - patch review type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file27834/issue15067_2.7_dead_pep.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file27835/issue15067_2.7_sql_capitalization.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file27836/issue15067_3.2_updates.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15067] Clean up the sqlite3 docs
Zachary Ware added the comment: Ok then, here's the split patches. 3.2_updates does have a few SQL capitalization changes, but most of those are already present in 2.7, and splitting out the rest would be more work than it's worth, I think. -- Added file: http://bugs.python.org/file27837/issue15067_3.2_sql_capitalization.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
