[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Roundup Robot added the comment: New changeset 975d1e180689 by Senthil Kumaran in branch 'default': merge from 3.3 http://hg.python.org/cpython/rev/975d1e180689 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Senthil Kumaran added the comment: Fixed in 3.3 and cpython. 3.2 is security fix mode and patches are not backported. This does not apply to 2.7. Thanks for the patch. -- resolution: - fixed status: open - closed versions: -Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
samwyse added the comment: Look good. I'd fix the last line, however: sent the quote_plus - sent to the quote_plus function, maybe. On Fri, Sep 28, 2012 at 6:18 AM, Brian Brazil rep...@bugs.python.org wrote: Brian Brazil added the comment: How does the attached patch look? I also reworded the first line to be a bit clearer, and be under 80 chars. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file27329/issue15350.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Brian Brazil added the comment: How does the attached patch look? I also reworded the first line to be a bit clearer, and be under 80 chars. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file27329/issue15350.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti, orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Changes by Senthil Kumaran sent...@uthcode.com: -- assignee: - orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
New submission from samwyse samw...@gmail.com: The doc string for url encode states: The query arg may be either a string or a bytes type. When query arg is a string, the safe, encoding and error parameters are sent to the quote_via function for encoding IMHO, this implies that the argument can be a string. Note that the preceding paragraphs starts out with If the query arg is a sequence of two-element tuples. I think that it should read: The components of the query arg may be either a string or a bytes type. When query arg is a string, the safe, encoding and error parameters are sent to the quote_via function for encoding. -- components: Library (Lib) messages: 165440 nosy: samwyse priority: normal severity: normal status: open title: {urllib,urllib.parse}.urlencode.__doc__ is unclear type: behavior versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear
Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: - needs patch type: behavior - enhancement versions: -Python 2.6, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com