[issue15467] Updating __sizeof__ tests
Serhiy Storchaka added the comment: Patches updated. Simplified struct __sizeof__ testing for 2.7 and 3.2 and fixed (using 'n' for Py_ssize_t) for 3.3. -- nosy: +meador.inge Added file: http://bugs.python.org/file26561/sizeof_tests-3.3_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26562/sizeof_tests-3.2_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26563/sizeof_tests-2.7_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file26541/sizeof_tests-3.3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file26542/sizeof_tests-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file26543/sizeof_tests-2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Roundup Robot added the comment: New changeset efade142ef01 by Martin v. Löwis in branch '3.2': Issue #15467: Move helpers for __sizeof__ tests into test_support. http://hg.python.org/cpython/rev/efade142ef01 New changeset d43ff8eb4cb3 by Martin v. Löwis in branch 'default': Issue #15467: Merge 3.2 http://hg.python.org/cpython/rev/d43ff8eb4cb3 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Roundup Robot added the comment: New changeset fa95b04e67fd by Martin v. Löwis in branch '2.7': Issue #15467: Move helpers for __sizeof__ tests into test_support. http://hg.python.org/cpython/rev/fa95b04e67fd -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Martin v. Löwis added the comment: I wasn't aware that test_support isn't public API. The patches are fine then; committed. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Meador Inge mead...@gmail.com: -- stage: - committed/rejected type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Serhiy Storchaka storch...@gmail.com added the comment: I asked in Python-Dev, and if I understood the answers correctly, we can make changes to 2.7 and 3.2 without fear. For 3.3 risk is higher, so we need to be more attentive. However patch for 3.3 contains not only the potential improvements for other tests, but also bug fixes (I think these bugs should cause tests failure on the platforms where sizeof(Py_ssize_t) != sizeof(long) or sizeof(Py_ssize_t) != sizeof(void*)). Of cause, if Georg Brandl not vetoes this. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
New submission from Serhiy Storchaka storch...@gmail.com: The proposed patches move to test.support some functions, which will be useful for testing __sizeof__. The next few patches will use it. Also in 3.3 some bugs have fixed, now n is used for Py_ssize_t and Py_hash_t (which is not long now). -- components: Tests files: sizeof_tests-3.3.patch keywords: patch messages: 166574 nosy: loewis, storchaka priority: normal severity: normal status: open title: Updating __sizeof__ tests versions: Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file26541/sizeof_tests-3.3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26542/sizeof_tests-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26543/sizeof_tests-2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Martin v. Löwis mar...@v.loewis.de added the comment: The problem is that this adds new features to test_support, which can only be done in 3.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Serhiy Storchaka storch...@gmail.com added the comment: Can we get around this by renaming check_sizeof into _check_sizeof? Or would we have to duplicate these auxiliary functions in every test file with __sizeof__ test? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15467] Updating __sizeof__ tests
Martin v. Löwis mar...@v.loewis.de added the comment: Not sure: that's for release managers to decide. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15467 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
