[issue15655] PEP 384 Refactoring applied to json module

[Antoine Pitrou]

Change by Antoine Pitrou :


--
nosy:  -pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[STINNER Victor]

STINNER Victor  added the comment:

Issue fixed in Python 3.9 with:

commit 33f15a16d40cb8010a8c758952cbf88d7912ee2d
Author: Dong-hee Na 
Date:   Fri Mar 27 19:59:59 2020 +0900

bpo-40077: Convert _json module to use PyType_FromSpec() (GH-19177)

Replace statically allocated types with heap allocated types:
use PyType_FromSpec().

Add a module state to store the Scanner and Encoder types.
Add traverse, clear and free functions to the module.

--
nosy: +corona10, vstinner
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Andrew Svetlov]

Changes by Andrew Svetlov andrew.svet...@gmail.com:


--
nosy: +asvetlov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

Robin Schreiber added the comment:

Removed C++ comment and corresponding codesnipped. Also changed bad-style macro 
definition.

--
Added file: http://bugs.python.org/file26818/_json_pep384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the json module!

--
components: Extension Modules
files: _json_pep384_v0.patch
keywords: patch
messages: 168222
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 384 Refactoring applied to json module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26809/_json_pep384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Antoine Pitrou]

Antoine Pitrou added the comment:

+// in case init is called multiple times within one interpreter,
+// we do not have to repeat all of the initialization

First, you shouldn't use C++-style comments (//).
Second, I find this comment a bit weird. Even if init is called a second time, 
surely clear would have been called in-between, and therefore the module state 
has to be initialized again?

Review comments from issue15653 also apply here.

--
nosy: +loewis, pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

Robin Schreiber added the comment:

Hey Antoine,

This comment describes exactly what I intended with the dance in issue15653. 
For example the json testsuite issued multiple calls to the init function 
before unloading and consequently clearing the module.
However it seems as if the behavior this code dealt with,
has been a bug inside the import lib.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

Robin Schreiber added the comment:

Incidentally, I am deeply sorry for the C++-Style comments. I thought those 
would be detected by the patchcheck.py.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com