[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: All patches seems already applied. Should we close this issue? -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Brian Curtin cur...@acm.org added the comment: Closed. I created #9332 for the remaining side issues. -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Antoine Pitrou pit...@free.fr added the comment: This has broken all non-Windows buildbots. Can you take a look? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: I'm building now and will report back shortly... -- Added file: http://bugs.python.org/file17920/smime.p7s ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ smime.p7s Description: S/MIME cryptographic signature ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Also, GetFinalPathNameByHandle() is called 5 times with VOLUME_NAME_DOS, and once with VOLUME_NAME_NT. This one looks suspect to me. [I noticed this because these symbols are not defined with the SDK shipped with VS8.0. I'll propose another patch for this] -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: Here's a patch to address the posix failures: - test_posixpath seems to have lost the creation of one test file. - WindowsError doesn't exist on other platforms, so it can't be caught directly (in tarfile.py). I've written a work-around, but I don't particularly like it (catches all exceptions and tests the name). There were three other tests that reported BAD for me. test_os and test_subprocess were reporting bad due to skipped tests. I presume this will not break the buildbots? test_readline is failing on readline.clear_history because it appears that attribute doesn't exist. I suspect this error is not related to the symlink patch. -- Added file: http://bugs.python.org/file17921/posix-failures.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file17920/smime.p7s ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Hm, the patch could be more pythonic. Something like: symlink_exception = (AttributeError,) try: symlink_exception += (NotImplementedError, WindowsError) except NameError: pass try: ... except symlink_exception: ... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Antoine Pitrou pit...@free.fr added the comment: Hm, the patch could be more pythonic. Something like: symlink_exception = (AttributeError,) try: symlink_exception += (NotImplementedError, WindowsError) except NameError: pass Probably better as: symlink_exception = (AttributeError, NotImplementedError) try: symlink_exception += (WindowsError,) except NameError: pass -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Brian Curtin cur...@acm.org added the comment: Committed Jason's patch with Antoine's twist as r82743 after running on Arch Linux. Thanks for catching and looking into this stuff. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Brian Curtin cur...@acm.org added the comment: Committed in r82659. I'm leaving this open until a few other issues are fleshed out. 1. Document privilege escalation and/or expose some method to do so. 2. Test execution, e.g., buildbots Once I get a few more things off my plate I should be able to finish setting up #2, the buildbot slave I've got almost up and running. I'd like to safely set it up so that this can be tested there, as none of the other buildbots are likely to run any of these tests. -- resolution: - fixed stage: patch review - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: This patch includes a routine that adds the directory of the python executable to the path before attempting to run a symlinked executable (in test_platform). -- Added file: http://bugs.python.org/file16821/windows symlink draft 28.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Martin v. Löwis mar...@v.loewis.de added the comment: The patch has now missed the window for 2.7, so backporting it won't be necessary. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: In the last patch, I addressed test_platform running a test under a symlinked Python. I then found the same error resulting from essentially the same code in test_sysconfig. So I refactored those methods into a generator method in test.support. This is patch 29. -- Added file: http://bugs.python.org/file16824/windows symlink draft 28.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Added file: http://bugs.python.org/file16825/windows symlink draft 29.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16809/windows symlink draft 27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16821/windows symlink draft 28.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16824/windows symlink draft 28.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Added file: http://bugs.python.org/file16833/admin results - no patch.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Added file: http://bugs.python.org/file16834/admin results - patch 29.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: With patch 29, I believe all patch-related test failures are corrected. The remaining failures in some modules (namely test_tarfile, test_glob, test_mailbox, test_warnings) can be demonstrated to occur in unpatched builds. Since some failures are transient, I created repeat_test, which I used to demonstrate that test_glob, test_tarfile, and test_mailbox will fail on a clean build. Additionally, I'm including test output for 32- and 64-bit builds on the unpatched build, the patched build running under administrator, and the patched build running under guest. The test output was generated in an automated fashion to guarantee a clean build. The build process can be found by easy_installing jaraco.develop==1.1.1 and running test-python-symlink-patch.py (VS9, GNU patch, and svn required). -- Added file: http://bugs.python.org/file16832/repeat_test.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Added file: http://bugs.python.org/file16835/guest results - patch 29.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16202/guest results.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16203/admin results.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: It seems issue7443 discusses the cause of the transient failures. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: While trying to reproduce the transient test_tarfile errors, I found two more tests that appear to be failing when symlinks cannot be created, now skipped by patch 27. -- Added file: http://bugs.python.org/file16809/windows symlink draft 27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: I've been fighting a failing test in test_platform (when test.support.can_symlink() is True). Turns out the problem is caused by the fact that the Python DLL cannot be resolved when the executable isn't in the same directory (which is the case when launched from a symlink). I've created issue8342 to track this behavior. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16196/windows symlink draft 25.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Changes by Jason R. Coombs jar...@jaraco.com: Removed file: http://bugs.python.org/file16761/windows symlink draft 26.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: My initial troubleshooting indicated to me that the intermittent test_tarfile problem exists independent of the symlink patch, so it was not relevant to this issue. I've tried to do some more thorough troubleshooting, and this continues to be my finding, and somewhat consistent with Brian's finding. I've created issue8317 to track the trouble with test_tarfile. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Jason R. Coombs jar...@jaraco.com added the comment: This latest patch (26) only merges the latest changes from the repo. -- Added file: http://bugs.python.org/file16761/windows symlink draft 26.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Brian Curtin cur...@acm.org added the comment: One last issue to solve before this goes in and I start the backport...test_tarfile.test_extract_hardlink is intermittently failing for me, which was an issue for Eric and I on an earlier version of Jason's patch. Sometimes it fails when run as a part of the whole test suite, and then it'll pass when run by itself. Thoughts, anyone? I've spent some time on it and I'm not sure what I'm missing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Brian Curtin cur...@acm.org added the comment: Anyone opposed to this being checked in? Other than some style issues which I'll fix on checkin, I believe this is ready to go. I'd like to get it in so I can backport it to 2.7 before the beta on Saturday. -- assignee: eric.smith - brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Eric Smith e...@trueblade.com added the comment: I had some style issues at one point, but I haven't looked at it closely recently. I won't have time to look at this before next week, so proceed without me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
sorin sorin.sbar...@gmail.com added the comment: For me the patch worked. It would be really nice to have it in 2.7 - I really hate Python functions that are not working on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1578269] Add os.symlink() and os.path.islink() support for Windows
Eric Smith e...@trueblade.com added the comment: At the language summit we okay'd using ctypes in the tests for standard lib modules, specifically for this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
