[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Roundup Robot]

Roundup Robot added the comment:

New changeset b907f99272c5 by Georg Brandl in branch 'default':
Port #16012 fix: parameter parsing regression in pyexpat parser UseForeignDTD() 
method.
http://hg.python.org/cpython/rev/b907f99272c5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Georg Brandl]

Georg Brandl added the comment:

Fixed in release clone as b907f99272c5.

--
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Christian Heimes]

Christian Heimes added the comment:

Erich, thank you very much for your bug report. Your report made it right in 
time for the upcoming 3.3.0 final release.

Here you are, Georg.

--
assignee:  -> georg.brandl
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Roundup Robot]

Roundup Robot added the comment:

New changeset 22ddf77e0497 by Christian Heimes in branch '3.2':
Issue #16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/22ddf77e0497

New changeset 3e0d632ce910 by Christian Heimes in branch '2.7':
Issue #16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/3e0d632ce910

New changeset 0f55ad9b07c8 by Christian Heimes in branch 'default':
Issue #16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/0f55ad9b07c8

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Christian Heimes]

Christian Heimes added the comment:

Don't feel bad. The final hasn't been released yet. :)

Here is a slightly different patch for 3.2 and 2.7.

--
Added file: http://bugs.python.org/file27275/issue16012_py32.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Antoine Pitrou]

Antoine Pitrou added the comment:

Ah, that's true. Too bad it wasn't tested for :(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Christian Heimes]

Christian Heimes added the comment:

I've created a patch with a simple test case.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file27274/issue16012.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Ezio Melotti]

Ezio Melotti added the comment:

This seems to be the changeset that introduced the regression b878df1d23b1.

--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Christian Heimes]

Christian Heimes added the comment:

Confirmed!

In Ubuntu's Python 2.7.3 and 3.2.3 UseForeignDTD() can be called without an 
argument. The hg versions of 2.7, 3.2 and 3.3 require one argument. The change 
smells like a regression for all affected Python versions.

Antoine, it looks like you committed the modification.

--
keywords: +3.2regression, 3.3regression
nosy: +benjamin.peterson, christian.heimes, georg.brandl, pitrou
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16012] pyexpat: Argument for UseForeignDTD should be optional

[Erich Seifert]

New submission from Erich Seifert:

It seems the recent changes to Modules/pyexpat.c made the boolean 'flag' for 
UseForeignDTD mandatory although it was optional in previous Python releases.

According to the docs the usage is UseForeignDTD([flag]), but calling 
UseForeignDTD without arguments leads to an error::

  >>> from xml.parsers import expat
  >>> parser = expat.ParserCreate('utf8')
  >>> parser.UseForeignDTD()
  Traceback (most recent call last):
File "", line 1, in 
  TypeError: UseForeignDTD() takes exactly 1 argument (0 given)

This was tested with version bfdf366a779a from hg repository.

--
components: Extension Modules
messages: 171108
nosy: eseifert
priority: normal
severity: normal
status: open
title: pyexpat: Argument for UseForeignDTD should be optional
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com