[issue16113] Add SHA-3 (Keccak) support

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Dror Levin]

Changes by Dror Levin :


--
nosy: +spatz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Björn Edström]

Björn Edström added the comment:

Remember that FIPS202 slightly change some parts of the Keccak that won the 
competition, so test results are different. I updated my stand alone SHA3 
module, for anyone who is interested in using this now in Python 2 and 3.

https://github.com/bjornedstrom/python-sha3

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
priority: release blocker -> normal
resolution: fixed -> 
stage: commit review -> 
status: closed -> open
title: SHA-3 (Keccak) support may need to be removed before 3.4 -> Add SHA-3 
(Keccak) support
versions: +Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Larry Hastings added the comment:

*sigh* fine.  But the title of the issue is no longer accurate.

And, Christian, I generate the 3.4 maintenance branch during the release 
process, not before.  So if you have to remove sha3 you're going to have to 
remove it from trunk.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Tim Peters]

Tim Peters added the comment:

@Larry, you seem to be misreading this.  They're not saying 3.4 can't be 
released until this feature is added.  It's _already_ been added.  They're 
saying 3.4 possibly can't be released until this feature is _removed_ - but 
whether it needs to be removed is outside of our control, and is not yet known.

> "release blocker" means "the release cannot go out until this
> issue is solved"

Yes - and this issue has not been solved yet.  It should indeed be solved 
before 3.4 is released, so "release blocker" is spot on.

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Larry Hastings added the comment:

You guys are making me cranky.  Please stop adding me to this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis added the comment:

Here "release blocker" would mean that if SHA-3 specification is not finished, 
then "the release cannot go out until SHA-3 is deleted".

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Changes by Larry Hastings :


--
nosy:  -larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Larry Hastings added the comment:

"release blocker" means "the release cannot go out until this issue is solved". 
 Adding SHA-3, while nice, is simply not something I am going to hold up 3.4 
for, full stop.

Please stop marking this issue as a "release blocker".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Larry:
I have marked this new feature as release blocker because I may have to remove 
it and reschedule its addition for 3.5. I'd like to remove it after you have 
branched off the 3.4 branch.

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

I'm tracking the SHA-3 progress closely. I'm prepared to pull the plug if there 
is any doubt about the final version of SHA-3 before beta 2 is released on Jan 
5th.

Larry:
I have marked this new feature as release blocker because I may have to remove 
it and reschedule its addition for 3.5. I'd like to remove it after you have 
branched off the 3.4 branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Changes by Larry Hastings :


--
nosy:  -larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Larry Hastings]

Larry Hastings added the comment:

Victor: a "new feature" is not a "release blocker".

--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +larry
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[haakon]

haakon added the comment:

Please make sure that the currently committed code is not released as part of 
Python 3.4. SHA-3 is not standardised yet, and NIST has said that they intend 
to make some changes to the Keccak SHA-3 submission before standardisation as a 
FIPS.

The links englabenny posted have a good overview of the SHA-3 timeline and the 
proposed changes.

It would be very confusing if hashlib in Python 3.4 came with a "sha3" that was 
incompatible with the final standard.

--
nosy: +haakon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Donald Stufft]

Changes by Donald Stufft :


--
nosy: +dstufft

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Mark Kubacki]

Changes by Mark Kubacki :


--
nosy: +markk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Aaron Gallagher]

Aaron Gallagher added the comment:

https://pypi.python.org/pypi/cykeccak/ is what I've written to do this, for 
reference. 

Honestly I hope that the Keccak sponge is directly exposed in openssl (or any 
other SHA-3 implementation) because of its utility beyond SHA-3. If the source 
of some other implementation is going to be bundled with python anyway, it 
shouldn't be difficult to expose the sponge bits.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Hi Aaron,

it's a tempting idea but I have to decline. The API is deliberately limited to 
the NIST interface. Once OpenSSL gains SHA-3 support we are going to use it in 
favor for the reference implementation. I don't expect OpenSSL to provide the 
full sponge API.

I also like to keep all options open so I can switch to a different and perhaps 
smaller implementation in the future. The reference implementation is huge and 
the binary is more than 400 KB. For comparison the SHA-2 384 + 512 module's 
binary is just about 60 KB on a 64bit Linux system.

Once a a new API has been introduced it's going to take at least two minor 
Python release and about four to five years to remove it.

But I could add a more flexible interface to Keccak's sponge to my standalone 
sha3 module https://pypi.python.org/pypi/pysha3 ...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Aaron Gallagher]

Aaron Gallagher added the comment:

As long as the reference Keccak code is going to live in the python stdlib 
anyway, I would /greatly/ appreciate it if the Keccak sponge function was 
directly exposed instead of just the fixed parameters used for SHA-3. 

A Keccak sponge can have a much wider range of rates/capacities, and after 
absorption can have any number of bytes squeezed out. The ability to get an 
unbounded number of bytes out is very useful and I've written some code that 
uses that behavior. I ended up having to write my own Keccak python library 
since none of the other SHA-3 libraries exposed this either.

--
nosy: +habnabit

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[englabenny]

englabenny added the comment:

NIST has published a tentative schedule for SHA-3 standardization. They expect 
to publish in the second quarter of 2014.

See http://csrc.nist.gov/groups/ST/hash/sha-3/timeline_fips.html  

and http://csrc.nist.gov/groups/ST/hash/sha-3/sha-3_standardization.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Ulrik Sverdrup]

Ulrik Sverdrup added the comment:

Please do not go forward until NIST publishes its SHA-3 specification document. 
We don't know yet what parameters they will finally choose when making Keccak 
SHA-3.

--
nosy: +englabenny

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

The module is rather large (about 190 KB) because the optimized SHA-3 
implementation isn't optimized for size. For this reason I like to keep the 
module out of the main binary for now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Richard Oudkerk]

Richard Oudkerk added the comment:

> 6cf6b8265e57 and 8172cc8bfa6d have fixed the issue on my VM. I didn't 
> noticed the issue as I only tested hashlib with the release builds, not 
> the debug builds. Sorry for that.

Ah.  I did not even notice there was _sha3.vcxproj.

Is there any particular reason for not making it part of python3.dll like 
_sha1, _sha256, _sha512 are?  (I thought it was only modules with special link 
requirements that became separate DLLs.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Andrew Svetlov]

Changes by Andrew Svetlov :


--
nosy: +asvetlov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

6cf6b8265e57 and 8172cc8bfa6d have fixed the issue on my VM. I didn't noticed 
the issue as I only tested hashlib with the release builds, not the debug 
builds. Sorry for that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

I've pushed a fix about 5 minutes ago. The module wasn't compiled in debug 
builds due to an error in the project file. Please update your copy and try 
again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Richard Oudkerk]

Richard Oudkerk added the comment:

_sha3 is not being built on Windows, so importing hashlib fails

>>> import hashlib
ERROR:root:code for hash sha3_224 was not found.
Traceback (most recent call last):
  File "C:\Repos\cpython-dirty\lib\hashlib.py", line 109, in 
__get_openssl_constructor
f = getattr(_hashlib, 'openssl_' + name)
AttributeError: 'module' object has no attribute 'openssl_sha3_224'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Repos\cpython-dirty\lib\hashlib.py", line 154, in 
globals()[__func_name] = __get_hash(__func_name)
  File "C:\Repos\cpython-dirty\lib\hashlib.py", line 116, in 
__get_openssl_constructor
return __get_builtin_constructor(name)
  File "C:\Repos\cpython-dirty\lib\hashlib.py", line 104, in 
__get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha3_224
...

--
nosy: +sbt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Michele Orrù]

Changes by Michele Orrù :


--
nosy: +maker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

The code has landed in default. Let's see how the build bots like my patch and 
the reference implementation.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Roundup Robot]

Roundup Robot added the comment:

New changeset 11c9a894680e by Christian Heimes in branch 'default':
Issue #16113: integrade SHA-3 (Keccak) patch from 
http://hg.python.org/sandbox/cheimes
http://hg.python.org/cpython/rev/11c9a894680e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Gregory P. Smith]

Gregory P. Smith added the comment:

don't worry about optimization settings in python itself for now.  the 
canonical optimized version will be in a future openssl version.  now that it 
has been declared the standard it will get a *lot* more attention in the next 
few years.

as it is, we _may_ want to replace this reference implementation with one from 
libtomcrypt in the future when it gets around to implementing it just so that 
the code for all of our bundled hash functions comes from the same place.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

New patch. I've removed the dependency on uint64 types. On platforms without a 
uint64 type the module is using the 32bit implementation with interleave tables.

By the way the SSE / SIMD instructions aren't useful. They are two to four 
times slower.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Added file: http://bugs.python.org/file27441/521e85a613bf.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Removed file: http://bugs.python.org/file27438/622009fb6192.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Removed file: http://bugs.python.org/file27431/49a949116245.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Removed file: http://bugs.python.org/file27426/44920b1d9db1.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Added file: http://bugs.python.org/file27438/622009fb6192.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

I've documented the optimization options of Keccak. The block also contains a 
summarization of my modifications of the reference code.

http://hg.python.org/sandbox/cheimes/file/57948df78dbd/Modules/_sha3/sha3module.c#l22

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

The hightlights of the next patch are

* release the GIL
* more test vectors
* remove bgr_endian.h
* move typedef UINT64 to sha3module
* declare more globals as static

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Added file: http://bugs.python.org/file27431/49a949116245.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Please review the latest patch. 

I've included Gregory as he is the creator of hashlib.

--
nosy: +gregory.p.smith
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Added file: http://bugs.python.org/file27426/44920b1d9db1.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Removed file: http://bugs.python.org/file27423/79e3fb1838ce.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Added file: http://bugs.python.org/file27423/79e3fb1838ce.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Antoine pointed out that the code contains C++ comments and exports a lot of 
functions. The latest patch has all // comments replaced, marks all functions 
and globals as static and #includes the C files directly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


Removed file: http://bugs.python.org/file27419/4509ef9b28a0.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Antoine Pitrou]

Antoine Pitrou added the comment:

Good, you can click the "create patch" button when it's ready :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Changes by Christian Heimes :


--
keywords: +patch
Added file: http://bugs.python.org/file27419/4509ef9b28a0.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

How about a sandbox repos?

--
hgrepos: +152

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Antoine Pitrou]

Antoine Pitrou added the comment:

> Please review Modules/sha3module.c

Can't you post a patch here?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Release 0.1 of pysha3 [1] is out. I've tweaked the C module to make it 
compatible with Python 2.6 to 3.4. The module and its tests run successfully 
under Linux and Windows. So far I've tested Linux X84_64 (2.7, 3.2, 3.3, 3.4), 
Windows X86 (2.6, 2.7, 3.2, 3.3) and Windows X86_64 (2.6, 2.7, 3.2, 3.3).

Please review Modules/sha3module.c and ignore all version specific #if blocks. 
For Python 3.4 I'm going to remove all blocks for Python < 3.3.

[1] http://pypi.python.org/pypi/pysha3/0.1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

Hello Björn,

thanks for the information. Your package didn't turn up on Google when I 
started with my experiment. Perhaps it's too new?

Your code and mine have lots of similarities. I was amused when I saw that you 
had the same issue with the block size attribute. At first I set it to 200 
(1600 / 8) but eventually I didn't implement it.

My code does everything in C with a separate constructor for each flavor of 
SHA-3. It's compatible to Python 2.6 to 3.4 and uses the optimized code for 32 
and 64bit platforms.

Oh, and my code is now working properly. Feel free to review the module. I'll 
upload the test code later.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Björn Edström]

Björn Edström added the comment:

For what it's worth, I've built a working C-based sha3-module that is available 
here: https://github.com/bjornedstrom/python-sha3

Note that I've only tested this on Python 2, for Python 3 YMMV.

Best regards
Björn

--
nosy: +bjornedstrom

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

Christian Heimes added the comment:

I've done some experiments with the reference implementation and adopted code 
of sha1module.c for sha3: https://bitbucket.org/tiran/pykeccak

So far the code just compiles (64bit only) but doesn't work properly yet. I may 
need to move away from the NIST interface and use the sponge interface directly.

--
assignee:  -> christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Jesús Cea Avión]

Jesús Cea Avión added the comment:

We have MD5, SHA1, sha256, sha512 implemented, to use when openssl is not 
available. Can we do the same with sha-3?. I would suggest to adopt the 
reference implementation without extensive optimizations, since we will have 
them when openssl has them.

So we might implement SHA-3 now and integrate OpenSSL implementation later, 
when available. This is interesting, for instance, because many users of Python 
3.4 will have a non "up to date" OpenSSL system library.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16113] Add SHA-3 (Keccak) support

[Christian Heimes]

New submission from Christian Heimes:

Today the latest crypto hash function was announced by NIST [1]. I suggest that 
we include the new hash algorithm in 3.4 once it lands in OpenSSL.

The Keccak site also has a reference implementation in C and Assembler [2]. It 
may take some effort to integrate the reference implementation as it contains 
several optimized backends for X86, X86_64, SIMD and various ARM platforms.

[1] http://www.nist.gov/itl/csd/sha-100212.cfm
[2] http://keccak.noekeon.org/

--
components: Extension Modules
messages: 171848
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Add SHA-3 (Keccak) support
type: enhancement
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com