[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

I settled on 'transform_children' for the new function. #31461 is the master 
issue for improving the browsers.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset fa1cae5832cbcfafedc4b1879c2abc85452f4edd by Terry Jan Reedy in 
branch '3.6':
 [3.6] bpo-1612262: IDLE: Class Browser shows nested functions, classes 
(GH-2573)  (#3702)
https://github.com/python/cpython/commit/fa1cae5832cbcfafedc4b1879c2abc85452f4edd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3686

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 058de11360ea6816a6e978c7be0bcbea99a3f7da by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-1612262: IDLE: Class Browser shows nested functions, classes (#2573)
https://github.com/python/cpython/commit/058de11360ea6816a6e978c7be0bcbea99a3f7da


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am revising the codecontext patch to use comprehensions and the sort key 
option.  I will rename the new function 'collect_objects' (GPolo) / 
'_traverse_node' (CSabella) as 'list_children' and have it return the 
name-object list, ordered by line number, needed by the tree widget.

[The input is a dictionary of children of a node, rather than a node, because 
pyclbr returns the dictionary of the children of the root module node of the 
tree, rather than a root node itself.  Sorting is not actually needed for 3.6/7 
because the dicts are already ordered, but pyclbr does not guarantee this by 
using OrderedDict.  Proposing these two changes is a separate potential issue.]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Nick Coghlan]

Nick Coghlan added the comment:

I think a bundled copy as idlelib._pyclbr in the 3.6 branch would be within the 
intent of PEP 434.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

Would it make any difference if the module were renamed? and made to only work 
with IDLE?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

Nick, this over-due improvement to IDLE depends on the over-due improvement to 
pyclbr in 3.7.  I would like to backport the IDLE improvement by putting a copy 
of 3.7 pyclbr in 3.6 idlelib.  Do you agree that PEP434 allows this?

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
dependencies: +IDLE: add docstrings to browser.py
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Cheryl Sabella]

Cheryl Sabella added the comment:

I added a more complete set of unit tests to the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Cheryl Sabella]

Cheryl Sabella added the comment:

I created issue 30881 to add docstrings to browser.py to make creating user 
tests easier.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +2644

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

I believe the patch for #6691 will also add detection of nested functions.  If  
so, the IDLE patch must also make use of that new information.

If the patch for #6691 is only applied to 3.7, I want to put a temporary copy 
of the revised pyclbr in 3.6 idlelib, perhaps as _pyclbr, and change the 3.6 
import accordingly.

--
assignee:  -> terry.reedy
nosy: +csabella
priority: normal -> high
versions: +Python 3.7 -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

Class Browser is now a module browser as it includes functions not in classes. 
I guess pyclbr does this. Enhancing this for current versions would require 
adding a private copy of enhanced pyclbr to idlelib.

--
nosy: +terry.reedy
priority: low -> normal
versions: +Python 2.7, Python 3.5, Python 3.6 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Tal Einat]

Changes by Tal Einat :


--
nosy:  -taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Mark Lawrence]

Changes by Mark Lawrence :


--
versions: +Python 3.2 -Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Guilherme Polo]

Changes by Guilherme Polo :


Removed file: http://bugs.python.org/file14699/show_nested_objects.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Guilherme Polo]

Guilherme Polo  added the comment:

I've removed the previous patch from here and attached an updated one on
issue6691.

Now the patch attached here only contains changes related to
idlelib.ClassBrowser.

--
dependencies: +Support for nested classes and function for pyclbr
Added file: http://bugs.python.org/file14706/classbrowser_nesting_support.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Guilherme Polo]

Guilherme Polo  added the comment:

The attached patch adds support for nested objects in pyclbr and also in
ClassBrowser.

I have yet to find an optimal way to test this on test_pyclbr (I did
some things here, none very nice), so you will notice tests are missing
on this patch.

--
keywords: +patch
nosy: +gpolo
Added file: http://bugs.python.org/file14699/show_nested_objects.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Roger Serwy]

Roger Serwy  added the comment:

The class browser relies on the pyclbr module to scan the code. This
module doesn't support classes within classes. Both pyclbr and IDLE's
class browser need to be modified.

--
nosy: +serwy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Daniel Diniz]

Daniel Diniz  added the comment:

Confirmed on trunk and py3k.

--
nosy: +ajaksu2
priority: normal -> low
stage:  -> test needed
type:  -> feature request
versions: +Python 2.7, Python 3.1 -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com