[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +905

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Roundup Robot]

Roundup Robot added the comment:

New changeset 96a9992d1003 by Xavier de Gaye in branch 'default':
Issue #16255: subrocess.Popen uses /system/bin/sh on Android as the shell,
https://hg.python.org/cpython/rev/96a9992d1003

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

For some reason the following notifications have not all been received (yet):
remote: added 1 changesets with 2 changes to 2 files
remote: buildbot: change(s) sent successfully
remote: sent email to roundup at rep...@bugs.python.org
remote: notified python-check...@python.org of incoming changeset 
96a9992d1003

But the buildbots have processed the build request.
Closing the issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

New patch using sys.getandroidapilevel() that is only defined for Android.
getandroidapilevel() is only available in 3.7, so only 3.7 is being fixed.

--
assignee:  -> xdegaye
dependencies:  -add function to os module for getting path to default shell
versions: +Python 3.7 -Python 3.6
Added file: http://bugs.python.org/file45860/unix_shell_16255_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

New patch that does not call sysconfig.get_config_var() on platforms that have 
'/bin/sh'.

--
Added file: http://bugs.python.org/file43809/unix_shell_16255_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Stefan Krah]

Stefan Krah added the comment:

Apparently sysconfig.get_config_var() is already called in site.py anyway,
so in principle I'm fine with using it here.

In the stdlib it seems to be the first use outside site.py though, and
site.py can be disabled by using "python -S", so perhaps we should be
extra careful, set UNIX_SHELL unconditionally to "/bin/sh" and move
the Android conditional inside a try/except.


But perhaps I'm being irrational here.  Victor, what do you think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

The attached patch fixes the issue. There is at least already an existing test 
case: test_subprocess.MiscTests.test_getoutput calls 
subprocess.getstatusoutput() that runs a Popen instance with shell=True.

--
stage:  -> patch review
Added file: http://bugs.python.org/file43795/unix_shell_16255.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

> The list of locations where '/bin/sh' is hard coded in the standard library:

I have entered issue 27472.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Stefan Krah]

Stefan Krah added the comment:

I've also opened a feature request here:

https://code.google.com/p/android/issues/detail?id=210812

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Xavier de Gaye]

Xavier de Gaye added the comment:

The list of locations where '/bin/sh' is hard coded in the standard library:

Lib/distutils/tests/test_build_scripts.py|68 col 31| ("#!/bin/sh\n"
Lib/distutils/tests/test_install_scripts.py|57 col 38| write_script("shell.sh", 
("#!/bin/sh\n"
Lib/distutils/tests/test_spawn.py|34 col 37| self.write_file(exe, 
'#!/bin/sh\nexit 1')
Lib/distutils/tests/test_spawn.py|45 col 37| self.write_file(exe, 
'#!/bin/sh\nexit 0')
Lib/subprocess.py|611 col 24| >>> check_output(["/bin/sh", "-c",
Lib/subprocess.py|1450 col 26| args = ["/bin/sh", "-c"] + args
Lib/test/test__osx_support.py|46 col 24| f.write("#!/bin/sh\n/bin/echo OK\n")
Lib/test/test__osx_support.py|58 col 24| f.write("#!/bin/sh\n/bin/echo 
ExpectedOutput\n")
Lib/test/test__osx_support.py|149 col 28| f.write("#!/bin/sh\n/bin/echo " + 
c_output)
Lib/test/test__osx_support.py|205 col 24| f.write("#!/bin/sh\nexit 255")
Lib/test/test_os.py|673 col 42| @unittest.skipUnless(os.path.exists('/bin/sh'), 
'requires /bin/sh')
Lib/test/test_os.py|677 col 24| with os.popen("/bin/sh -c 'echo $HELLO'") as 
popen:
Lib/test/test_os.py|681 col 42| @unittest.skipUnless(os.path.exists('/bin/sh'), 
'requires /bin/sh')
Lib/test/test_os.py|684 col 14| "/bin/sh -c 'echo \"line1\nline2\nline3\"'") as 
popen:
Lib/test/test_subprocess.py|1563 col 31| fobj.write("#!/bin/sh\n")
Lib/test/test_subprocess.py|1611 col 31| fobj.write("#!/bin/sh\n")
Lib/test/test_subprocess.py|1629 col 15| sh = '/bin/sh'

--
nosy: +xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Roman Evstifeev]

Changes by Roman Evstifeev :


--
nosy: +Roman.Evstifeev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Stefan Krah]

Stefan Krah added the comment:

It seems that Android is the only known platform that deviates from
/bin/sh. So perhaps we should simply set a variable to either
/bin/sh or /system/bin/sh rather than waiting for #16353 to settle.

--
nosy: +skrah
versions: +Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Matt Frank]

Matt Frank added the comment:

Assuming issue16353 is fixed using 
http://bugs.python.org/file36196/os.get_shell_executable.patch the appropriate 
way to find the path to the default shell is by calling 
os.get_shell_executable().

This is the 1-liner patch that uses os.get_shell_executable() in Popen() 
instead of the hard-coded string /bin/sh.

--
keywords: +patch
Added file: http://bugs.python.org/file37139/popen-no-hardcode-bin-sh.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Matt Frank]

Changes by Matt Frank matthew.i.fr...@intel.com:


--
nosy: +WanderingLogic

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Gregory P. Smith]

Gregory P. Smith added the comment:

$SHELL is up to the user and not guaranteed to be anything remotely /bin/sh
compatible.
On Jul 31, 2014 4:14 PM, Antoine Pitrou rep...@bugs.python.org wrote:


 Antoine Pitrou added the comment:

 Why not simply use $SHELL?

 --
 nosy: +pitrou

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue16255
 ___


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Antoine Pitrou]

Antoine Pitrou added the comment:

Why not simply use $SHELL?

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Andrew Svetlov]

Changes by Andrew Svetlov andrew.svet...@gmail.com:


--
dependencies: +add function to os module for getting path to default shell

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Andrew Svetlov]

Changes by Andrew Svetlov andrew.svet...@gmail.com:


--
versions:  -Python 2.7, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Ezio Melotti]

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Chris Jerdonek]

Chris Jerdonek added the comment:

I created issue 16353 for adding a function to the os module for getting the 
path to the default shell.

The current issue 16255 could be addressed in 3.4 by calling such a function 
from the subprocess module.  For earlier versions (since enhancements are not 
allowed), the current issue could perhaps be addressed by backporting the logic 
in such a function directly into the subprocess module (i.e. without adding a 
new function to the os module).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Andrew Svetlov]

Andrew Svetlov added the comment:

Chris, agree with you.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Chris Jerdonek]

Chris Jerdonek added the comment:

It occurs to me that logic for detecting the shell might make sense for being 
part of the os module, e.g. os.getdefaultshell().

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Éric Araujo]

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Andrew Svetlov]

Andrew Svetlov added the comment:

Is there some document describing procedure for 
building/installing/running_tests at Android device?

I have Samsung Galaxy Tab and would to work on the issue.
But my android experience is limited to installing Scripting Layer for Android 
from Google Play and running python3 scripts.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Chris Jerdonek]

Chris Jerdonek added the comment:

 It seems simple enough for us to make the default configurable

This seems good to do in any case (as opposed to having the string be 
hard-coded), and we can test it independently of Android.  There is a 
recently added test in the 3.x branches that can be modified: test method 
test_executable_replaces_shell which checks that the executable argument 
replaces the default shell for non-Windows.

I would suggest implementing Gregory's two suggested measures as two separate 
patches.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Ben Rousch]

Ben Rousch added the comment:

 Is there some document describing procedure for 
 building/installing/running_tests at Android device?

I'm using the android-python27 project, but you can also reproduce it under 
SL4A:

Start SL4A
Menu - View - Interpreters
Python 2.6.2 or Python 3

 from subprocess import Popen
 p = Popen(ls, shell=True)
*Fails* OSError: [Error 2] No such file or directory
 p = Popen(ls shell=True, executable=/system/bin/sh)
*Works*

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Ben Rousch]

New submission from Ben Rousch:

The subprocess.Popen function uses /bin/sh in Unix environments. Android is 
detected as a Unix environemnt, but has moved that executable to 
/system/bin/sh. This can be worked around by adding a parameter 
executable='/system/bin/sh' to the call, but it is impractical to do this for 
every call to Popen in every library and codebase. For subprocess.Popen to work 
on Android, Popen needs to be able to detect if /bin/sh is not there and try 
/system/bin/sh instead.

--
components: Library (Lib)
messages: 173093
nosy: brousch
priority: normal
severity: normal
status: open
title: subrocess.Popen needs /bin/sh but Android only has /system/bin/sh
type: crash
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[R. David Murray]

R. David Murray added the comment:

Android really should not be breaking the standards that way.  We do want to 
support Android, but have you submitted a bug report to them?

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Roumen Petrov]

Roumen Petrov added the comment:

...Applications should note that the standard PATH to the shell cannot be 
assumed to be either /bin/sh or /usr/bin/sh, and should be determined by 
interrogation of the PATH returned by getconf PATH , ensuring that the returned 
pathname is an absolute pathname and not a shell built-in

--
nosy: +rpetrov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Ben Rousch]

Ben Rousch added the comment:

@rpetrov thanks for finding that - I was having trouble hunting down what the 
standard is. I think you're quoting from 
http://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[R. David Murray]

R. David Murray added the comment:

We should do that, then, if /bin/sh doesn't exist.

--
nosy: +gregory.p.smith
type: crash - behavior
versions: +Python 3.2, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Chris Jerdonek]

Changes by Chris Jerdonek chris.jerdo...@gmail.com:


--
nosy: +asvetlov, chris.jerdonek

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[Gregory P. Smith]

Gregory P. Smith added the comment:

I wouldn't blame android for this; I doubt Android claims to support whatever 
standard you are holding it to.

It seems simple enough for us to make the default configurable (a public module 
level constant that anyone can override in their code after importing the 
module to change the default) or to otherwise query the system for where the 
default shell is at import time.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

[R. David Murray]

R. David Murray added the comment:

Well, posix; but I was wrong about what posix required, as Roumen pointed out.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com