[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

> Hmm, which of the two initial licenses should I choose? Which one do
> you rather want me to choose?

Whichever you prefer. They should be equivalent in their terms
(non-copyleft free licenses).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

Hmm, which of the two initial licenses should I choose? Which one do you rather 
want me to choose?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

Will do (later today).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

You're welcome! We're always happy to have new contributors.

I've forgotten something: could you sign a contributor agreement?
You'll find instructions at http://www.python.org/psf/contrib/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

Great!

Feels awesome to have my first bit of code contributed to the Python project. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

I've committed your patch after having made the few very minor changes 
mentioned in the review. Thank you very much!

--
assignee: orsenthil -> 
resolution:  -> invalid
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Roundup Robot]

Roundup Robot added the comment:

New changeset a182367eac5a by Antoine Pitrou in branch 'default':
Issue #16423: urllib.request now has support for ``data:`` URLs.
http://hg.python.org/cpython/rev/a182367eac5a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

> On 11/18/2012 12:36 AM, Antoine Pitrou wrote:
> >
> > - the patch needs a test (and docs too)
> > - are you sure ignoring POSTed data is the right thing to do? Shouldn't we 
> > forbid it instead?
> 
> Btw.: The file:// protocol handler also just ignores posted data, so I think 
> the data url handler 
> shouldn't deviate from that. Either both raise an error when data is posted 
> or none.

Ah, fair enough, then. Thanks for the updated patch, I'll take a look
(unless someone beats me to it).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Changes by Mathias Panzenböck :


Removed file: http://bugs.python.org/file27994/urllib.request-data-url.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Changes by Mathias Panzenböck :


Added file: http://bugs.python.org/file28018/urllib.request-data-url.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Changes by Mathias Panzenböck :


Removed file: http://bugs.python.org/file28017/urllib.request-data-url.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

Ok, I've added a documentation and some tests. Is it ok this way? More tests? 
More/other documentation?

--
Added file: http://bugs.python.org/file28017/urllib.request-data-url.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

On 11/18/2012 12:36 AM, Antoine Pitrou wrote:
>
> - the patch needs a test (and docs too)
> - are you sure ignoring POSTed data is the right thing to do? Shouldn't we 
> forbid it instead?

Btw.: The file:// protocol handler also just ignores posted data, so I think 
the data url handler 
shouldn't deviate from that. Either both raise an error when data is posted or 
none.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

> > - are you sure ignoring POSTed data is the right thing to do? Shouldn't we 
> > forbid it instead?
> > - I think it would be nice to reference the RFC number somewhere
> > - not sure why you raise IOError on a bad URL; I would say ValueError is 
> > the right exception here
> >
> 
> I did that because that's what the old URLopener code does (ignoring POSTed 
> data and raising an 
> IOError). The comment is actually a 1:1 copy of the old code.

Ok. I think it's better to take a fresh start here :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

On 11/18/2012 12:36 AM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> A couple of comments:
>
> - the patch needs a test (and docs too)

Will do (when I have time).

> - are you sure ignoring POSTed data is the right thing to do? Shouldn't we 
> forbid it instead?
> - I think it would be nice to reference the RFC number somewhere
> - not sure why you raise IOError on a bad URL; I would say ValueError is the 
> right exception here
>

I did that because that's what the old URLopener code does (ignoring POSTed 
data and raising an 
IOError). The comment is actually a 1:1 copy of the old code.

> +1 on the general idea, by the way.
>
> --
> nosy: +pitrou
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Antoine Pitrou]

Antoine Pitrou added the comment:

A couple of comments:

- the patch needs a test (and docs too)
- are you sure ignoring POSTed data is the right thing to do? Shouldn't we 
forbid it instead?
- I think it would be nice to reference the RFC number somewhere
- not sure why you raise IOError on a bad URL; I would say ValueError is the 
right exception here

+1 on the general idea, by the way.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> patch review
versions:  -Python 3.1, Python 3.2, Python 3.3, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL

[Mathias Panzenböck]

Changes by Mathias Panzenböck :


--
components: +Library (Lib) -Documentation
title: urllib data URL recipe -> urllib data URL
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL recipe

[Mathias Panzenböck]

Mathias Panzenböck added the comment:

New patch. Instead of adding the data URL support to the doc as a recipe I 
added it to urllib.request directly. I think this is better and justified, 
because the old legacy URLopener had (some kind) of support for data URLs.

OT: I think that the legacy URLopener has bugs. It only unquotes the data if 
it's base64 encoded, but it should be unquoted in any case. Also it returns a 
StringIO and decodes the content as latin-1. This is wrong, the content is a 
binary string. It could be text encoded in any kind of charset or not text at 
all (e.g. an image).

--
Added file: http://bugs.python.org/file27994/urllib.request-data-url.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL recipe

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
assignee: docs@python -> orsenthil
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16423] urllib data URL recipe

[Mathias Panzenböck]

New submission from Mathias Panzenböck:

I think it would be really helpful if urllib would support data URLs. However, 
I was told on the python-ideas mailing list that it would probably only added 
as recipe in the documentation. The attached patch adds such an recipe to the 
urllib.request documentation. I've never written a doc patch (or any patch) for 
python before, so I don't know if I added it at the right place in the right 
format.

--
assignee: docs@python
components: Documentation
files: doc-urllib.request-data-url-recipe.patch
hgrepos: 160
keywords: patch
messages: 175041
nosy: docs@python, panzi
priority: normal
severity: normal
status: open
title: urllib data URL recipe
versions: Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5
Added file: 
http://bugs.python.org/file27914/doc-urllib.request-data-url-recipe.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com