[issue16655] IDLE list.append calltips test failures
Roundup Robot added the comment: New changeset 779e5511d803 by Terry Jan Reedy in branch '2.7': Issue #16655: Explain why Idle's test_calltips has 'fragile' tests of builtins. http://hg.python.org/cpython/rev/779e5511d803 New changeset 4a505a901b2e by Terry Jan Reedy in branch '3.3': Issue #16655: Explain why Idle's test_calltips has 'fragile' tests of builtins. http://hg.python.org/cpython/rev/4a505a901b2e New changeset c4a2d0538441 by Terry Jan Reedy in branch 'default': Issue #16655: Explain why Idle's test_calltips has 'fragile' tests of builtins. http://hg.python.org/cpython/rev/c4a2d0538441 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
Terry J. Reedy added the comment: When I moved tests from CallTips.py to test_calltips.py, I reduced but did not eliminate the use of builtins. I decided instead to explain in the file why there is no substitute for the real thing, and how to fix a simple mismatch like that reported here. -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Move CallTips tests to idle_tests ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3, Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
Chris Jerdonek added the comment: Could you mock or monkey-patch what you are getting a tool tip for (i.e. set the external string you are checking for)? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
Terry J. Reedy added the comment: In 3.2.3 list.append.__doc__ 'L.append(object) -- append object to end' In 3.3.0 list.append.__doc__ 'L.append(object) - None -- append object to end' I checked the other 6 pure mutation methods. .sort, .extend, .remove, and the new .clear have the same new addition of ' - None'. .insert and .reverse do not (but it seems they should). It seems I pushed the June 7 #12510 patch -- msg162510 -- which added the .append tests, without properly testing in 3.2. A fix for 3.2 is easy, but the deeper issue is the fragility of comparing external text to hard-coded expected text. I knew when I wrote the tests that that could and would be a problem in the future, but did not notice that it already was. One solution is not to compare again external strings; but then how do we know that the tooltips work with such? Another is to fetch the external string in the test code, but that amounts to duplicating the code in the tooltip function and testing it against itself; so is it really a test? The third option is to leave the tests vulnerable and patch them in a version specific manner when they break. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16655] IDLE list.append calltips test failures
New submission from Chris Jerdonek: There are three IDLE test failures in the 3.2 branch: $ ./python.exe Lib/idlelib/CallTips.py list.append - expected 'L.append(object) - None -- append object to end' - but got 'L.append(object) -- append object to end' [].append - expected 'L.append(object) - None -- append object to end' - but got 'L.append(object) -- append object to end' List.append - expected 'L.append(object) - None -- append object to end' - but got 'L.append(object) -- append object to end' 3 of 41 tests failed -- components: IDLE messages: 177253 nosy: chris.jerdonek, kbk priority: normal severity: normal status: open title: IDLE list.append calltips test failures type: behavior versions: Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
