[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky alexander.belopol...@gmail.com added the comment: I've simplified Paul's patch by removing timegm and mktimetz functions. Also, platforms that don't support tm_zone are unaffected. -- stage: patch review - commit review Added file: http://bugs.python.org/file26002/issue1667546.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Paul Boddie p...@boddie.org.uk added the comment: On Wednesday 13 June 2012 23:51:25 Alexander Belopolsky wrote: Alexander Belopolsky alexander.belopol...@gmail.com added the comment: I've simplified Paul's patch by removing timegm and mktimetz functions. Also, platforms that don't support tm_zone are unaffected. I think you may have forgotten to remove docstring references to those functions. Nice to see some progress on the issue, though, and it's probably good to solve one problem at a time in this way, too. Paul -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky alexander.belopol...@gmail.com added the comment: On Wed, Jun 13, 2012 at 7:08 PM, Paul Boddie rep...@bugs.python.org wrote: I think you may have forgotten to remove docstring references to those functions. Good catch. BTW, did you write the additional tests for strptime? This is the only thing that I want to add before committing. -- nosy: +Alexander.Belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 3b5545ba6432 by Alexander Belopolsky in branch 'default': Issue #1667546: On platforms supporting tm_zone and tm_gmtoff fields http://hg.python.org/cpython/rev/3b5545ba6432 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Changes by Alexander Belopolsky alexander.belopol...@gmail.com: -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky alexander.belopol...@gmail.com added the comment: Reopening. given the uncertainty with #9527, this issue may result in getting the TZ-aware local time support in stdlib sooner. -- resolution: duplicate - stage: committed/rejected - patch review status: closed - open versions: +Python 3.3 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
anatoly techtonik techto...@gmail.com added the comment: IIUC #9527 is about datetime and this request is about time.localtime, i.e. about making the API more intuitive for users. I don't think this issue should be closed. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Tue, Jan 11, 2011 at 5:06 AM, anatoly techtonik rep...@bugs.python.org wrote: .. IIUC #9527 is about datetime and this request is about time.localtime, This is correct, but did you notice what I wrote in my last message? In order to properly implement #9527 in datetime.py, some kind of tm_gmtoff support will need to be added to the time module, but I don't want this to become a feature that is exclusively available from the time module. I am not rejecting this request, I am trying to consolidate two closely related issues. Can you explain why you believe this functionality should be provided exclusively through the time module and not be available in datetime? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: I am going to close this as superseded by #9527. In order to properly implement #9527 in datetime.py, some kind of tm_gmtoff support will need to be added to the time module, but I don't want this to become a feature that is exclusively available from the time module. -- resolution: - duplicate stage: patch review - committed/rejected status: open - pending superseder: - Add aware local time support to datetime module ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: I have updated time-4.diff patch for py3k. Code changes are minimal, mostly due to string to unicode conversion. I have not attempted to fix anything beyond passing supplied unittest, but I did noticed a few missing error return tests. I was not able to make the final test in test_mktimetz pass because I did not completely understand its logic. Georg, I am trying to consolidate and bring to resolution a number to timezone related issues. Would you like me to take this issue from you or do you want to continue to own it? -- Added file: http://bugs.python.org/file17578/time-4-py3k.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Georg Brandl ge...@python.org added the comment: (Hi Alexander, sorry for not answering on IRC, I got a phonecall and was distracted for a while.) Please take on this issue -- I've simply not had energy enough to fight it through. -- assignee: georg.brandl - belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
anatoly techtonik techto...@gmail.com added the comment: Yet another timezone issue. =/ Seems like it is too complicated. Should we try to organize a dedicated sprint during EuroPython? Do we need some easy to read research on the problem? Should PSF define bounty for that? Should we try to approach this with some other entrypoint like high level user story? I can play the role of the dumb user. Please, add your replies to this Wave https://wave.google.com/wave/waveref/googlewave.com/w+FbjMbPbEA so that we can develop the story. -- nosy: +techtonik ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Paul Boddie p...@boddie.org.uk added the comment: Speaking for myself, I'm not sure whether I'm really the person to push this further, at least, although others may see it as a worthy sprinting topic. In principle, adding the extra fields is the right thing to do, merely because it exposes things from struct tm which were missing and which influence the other functions depending on it. The only things remaining are to make sure that existing code doesn't change its behaviour with these new fields, and that the new fields work together with the time functions as expected. Thus, testing is the most important thing now, I think. For the bigger picture, which shouldn't be discussed here, Python's way of handling times and dates probably needs improvement - this has been discussed already (a reference for anyone not involved is Anatoly's initial message in one recent discussion: http://mail.python.org/pipermail/python-dev/2010-February/097710.html) - and I think usage of pytz is a step in the right direction, although it does not eliminate the need to learn about time zones (UTC, CET...), time regimes (Europe/Oslo, America/New_York...), floating times, and zone transitions (and ambiguous times). Extending Python library support is potentially a sprinting topic, but not really a topic for discussion around this patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- stage: - patch review type: - feature request versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Georg Brandl ge...@python.org added the comment: To be honest, I forgot about it :( ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1667546] Time zone-capable variant of time.localtime
Antoine Pitrou pit...@free.fr added the comment: What is the status of this? -- nosy: +pitrou versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1667546 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
