[issue16845] warnings.simplefilter should validate input

[Daniël van Noord]

Daniël van Noord  added the comment:

I have submitted the path by @berker.peksag with one additional test case in a 
new PR.

@nanjekyejoannah I saw you responded to the other PR, but that died down. Would 
you mind taking a look at mine? I'm happy to help land this :)

--
nosy: +danielnoord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Roundup Robot]

Change by Roundup Robot :


--
nosy: +python-dev
nosy_count: 5.0 -> 6.0
pull_requests: +30073
pull_request: https://github.com/python/cpython/pull/31983

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

@Bonifacio2, As commented on the PR, I think opening a PR with a patch close to 
what @berker.peksag suggested looks more elaborate, IMHO.

Thanks for your contribution.

--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Bonifacio]

Change by Bonifacio :


--
keywords: +patch
nosy: +Bonifacio2
nosy_count: 3.0 -> 4.0
pull_requests: +25281
pull_request: https://github.com/python/cpython/pull/26696

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +easy -patch
versions: +Python 3.10 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Brett Cannon]

Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Berker Peksag]

Berker Peksag added the comment:

Here's a patch that uses the same approach as in issue 16382.

--
components: +Library (Lib)
nosy: +berker.peksag
stage:  - patch review
versions: +Python 3.5
Added file: http://bugs.python.org/file35773/issue16845.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Vajrasky Kok]

Vajrasky Kok added the comment:

Here is the patch to add the validation in simplefilter with the test.

--
keywords: +patch
nosy: +vajrasky
Added file: http://bugs.python.org/file32131/add_assert_in_simplefilter.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Georg Brandl]

Changes by Georg Brandl ge...@python.org:


--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16845] warnings.simplefilter should validate input

[Sebastian Berg]

New submission from Sebastian Berg:

`warnings.simplefilter` does not validate that the category passed in is 
actually a class. This means that an invalid category leads to a `TypeError` 
whenever a warning would otherwise occur due to `issubclass` check failing.

It is a very small thing, but for usability it would be clearer if this was 
checked right away.

--
messages: 178867
nosy: seberg
priority: normal
severity: normal
status: open
title: warnings.simplefilter should validate input
type: enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com