[issue1721083] Add File - Reload

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Recent edits to iomenu.IOBinding.loadfile were intended to preserve the option 
of reloading a non-empty editor.

--
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Terry J. Reedy]

Terry J. Reedy  added the comment:

All open files, up to the most recent 21 (and that could be increased) are in 
the recent file list.  Clicking on any name loads that file, unless it is 
already loaded.  The exception enforced in filelist.FileList.open, lines 29-32:

if key in self.dict:
edit = self.dict[key]
edit.top.wakeup()
return edit

I believe that we just need to ask, before the return, "Replace editor content 
with file content?" and if yes, call edit.io.loadfile(filename).

--
priority: low -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#1175686 was not a dependency, but a duplicate closed in favor of this issue, 
because gpolo attached the diff here.

This is obviously not a high priority, but I still want to consider it.  The 
addition would no longer be an extension, but likely a method in iomenu.

--
assignee: roger.serwy -> terry.reedy
nosy:  -Nashev, gpolo, kbk, roger.serwy
versions: +Python 3.10 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Terry J. Reedy]

Terry J. Reedy added the comment:

Notepad++ has 'Reload from disk' right after New and Open, and I like that 
explicit wording. 'Revert' is a bit esoteric for beginners. (And I do not see 
that on the menu now.)

Kurt's argument applies to Notepad++ also -- one could close the file and 
reload from the recent files list, but there it is. There is a subtle 
psychological factor: reloading may mean 'I messed up and want to start over'. 
In that state, a simple direct reload is tension defuser.

Quite separately, Notepad++ check file modification times when it gets the 
focus and if the disk copy is newer, it pops up a box saying so and asking if 
one wants to reload. (Or perhaps it check for OS notifications at this time.) 
This is the feature directed at catching reverts and merges.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Roger Serwy]

Roger Serwy added the comment:

Raymond, I can pick this up. I might as well work on #6699 at the same time.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Raymond Hettinger]

Raymond Hettinger added the comment:

Roger, can you pick this one up?

Adding a reload option to the file menu benefits IDLE in two ways.  First, it 
allows users to easily discard changes.  Second, it helps IDLE play well with 
reverts and updates in version control systems.  In the absence of this 
feature, users have to close their current file without saving and then re-open 
it from disk.

--
assignee: rhettinger - roger.serwy
nosy: +roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Raymond Hettinger]

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
assignee: kbk - rhettinger
keywords: +needs review -patch
versions: +Python 3.3 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

msg91213 states that there are two problems with the patch.  Could we have 
comments from IDLE users please.

--
nosy: +BreamoreBoy
stage: unit test needed - patch review
versions: +Python 3.2 -Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Guilherme Polo]

Guilherme Polo ggp...@gmail.com added the comment:

Kurt, there is now a patch on issue 6699 which adds your suggested feature:

Adding a warning when saving that the file has changed on disk is a
good emacs feature which has saved my bacon a number of times.  That
would be a good feature to add to IDLE, but that's a different request.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Guilherme Polo]

Guilherme Polo ggp...@gmail.com added the comment:

I have done a very initial patch in an attempt to define where we should
go with this feature. There are several different proposals around this
issue and the superseded one, I opted to implement the simplest one
which is to add a 'Revert' entry in the file menu which re-reads the
file currently open.

There are at least two problems with this patch. First, I don't think
there is a non-hacky way to place a command on a menu in a specific
place by using an idle extension, so, the 'Revert' entry is the last
entry in the file menu right now. I guess this would be solved by not
making this an extension and then proceed to manually remove the menu
entry while creating the shell window (similarly to what it is done when
running under mac osx). The second problem happens when reverting the
file, I'm not sure if it should be done differently but this seems to
cause some problem with Multicall.

--
keywords: +patch
Added file: http://bugs.python.org/file14635/idle_filerevert.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Daniel Diniz]

Changes by Daniel Diniz aja...@gmail.com:


--
dependencies: +add reload function to IDLE
nosy: +gpolo
stage:  - test needed
versions: +Python 2.7, Python 3.1 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Terry J. Reedy]

Terry J. Reedy [EMAIL PROTECTED] added the comment:

This appears to me to duplicate and supercede
http://bugs.python.org/issue1175686
If so, could that be closed as superceded?

--
nosy: +tjreedy

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Nashev]

Nashev added the comment:

There are command in menu is called Revert.

P.S.: for knowing that file changed, programs in windows can register OS
callback for this event and just react on it. In Mac i think too, but i
don't know how with it on unix and python.

_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1721083
_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1721083] Add File - Reload

[Nashev]

Nashev added the comment:

It is very nice feature, that exists in many advanced and professional
GUI-based editors on the Windows and Mac. For example, i can fast name
TextWrangler, HomeSite, Flash, PhotoShop and it is only first names in
mind. It feature for simplify tool's usage, it is improve GUI usability.

--
nosy: +Nashev

_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1721083
_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com