[issue17446] doctest test finder doesnt find line numbers of properties

2019-10-28 Thread daniel hahler 


daniel hahler  added the comment:

The PR appears to need a better test according to 
https://github.com/python/cpython/pull/3419#issuecomment-350570083.

--
nosy: +blueyed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2017-10-04 Thread Michael Cuthbert 

Michael Cuthbert  added the comment:

A pull request has been in for about a month -- is it possible to review or 
merge or comment?  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2017-09-06 Thread Michael Cuthbert 

Changes by Michael Cuthbert :


--
pull_requests: +3416

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2017-05-15 Thread Michael Cuthbert 

Michael Cuthbert added the comment:

just poking to see if this patch is worth trying to get into 3.7

--
versions: +Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-03-21 Thread Michael Cuthbert 

Michael Cuthbert added the comment:

Here's a rather obscure bug that I was able to catch before we put this into 
action: doctests inside the __doc__ for namedtuples (and perhaps all 
namedtuples?) are instances of property, have .fget, but do not have 
.fget.__code__.  Thus one more check is needed:

if (lineno is None and 
isinstance(obj, property) and
obj.fget is not None and 
hasattr(obj.fget, '__code__')):
obj = obj.fget.__code__
lineno = getattr(obj, 'co_firstlineno', None)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-03-08 Thread Michael Cuthbert 

Michael Cuthbert added the comment:

looks like we're stuck on a style change (backslash to parens; ironic: I chose 
backslash to match surrounding code; I never use them myself). tuxtimo - could 
you fix this? (or I'll do once the move to github is done).  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-02-04 Thread Michael Cuthbert 

Michael Cuthbert added the comment:

The test looks great to me.  Does anyone on nosy know the proper way to request 
a patch review?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-02-04 Thread Emanuel Barry 

Emanuel Barry added the comment:

Left a comment on Rietveld. I don't have time right now to check the test, but 
I suspect you tested it before submitting the patch, so it should probably be 
fine.

--
nosy: +ebarry
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-02-04 Thread Timo Furrer 

Timo Furrer added the comment:

Yes, I've tested it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-01-31 Thread Michael Cuthbert 

Michael Cuthbert added the comment:

this is my first contribution to Python core so I really have no idea how to do 
this, but I have found a solution (works in Py3.4, 2.7):

in doctest.py after line 1087 ("lineno = getattr(obj, 'co_firstlineno', 
None)-1")  add these lines:

if lineno is None and isinstance(obj, property) and \
obj.fget is not None:
obj = obj.fget.__code__
lineno = getattr(obj, 'co_firstlineno', None) 
# no need for -1 because of decorator. 

I can try to make a patch file for this, but just want to be sure I'm on the 
right track for contributing first.  I know how to do a Git pull, but not 
hg/patch.

(p.s., I think the current code "lineno = getattr(obj, 'co_firstlineno', 
None)-1" has an error; if the getattr does not find 'co_firstlineno', it will 
return None and then subtract 1 from None which is a TypeError).

--
nosy: +Michael Cuthbert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-01-31 Thread Mark Lawrence 

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2016-01-31 Thread Timo Furrer 

Timo Furrer added the comment:

I took the ideas from @Michael.Cuthbert and wrote a proper test. It's my first 
patch so I hope everything's fine with it. If not I'm happy for feedback :)

--
keywords: +patch
nosy: +Timo Furrer
Added file: http://bugs.python.org/file41769/fix_issue_17446.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2014-10-01 Thread Mark Lawrence 

Mark Lawrence added the comment:

@Ronny can you provide a patch for this?

--
nosy: +BreamoreBoy
type:  - behavior
versions: +Python 2.7, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17446
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2013-03-17 Thread Ronny Pfannschmidt 

New submission from Ronny Pfannschmidt:

examples that are found on a property dont detect the line number

class example(object):
  @property
  def me(self):
   
1/0
   
   pass

--
messages: 184384
nosy: Ronny.Pfannschmidt
priority: normal
severity: normal
status: open
title: doctest test finder doesnt find line numbers of properties

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17446
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17446] doctest test finder doesnt find line numbers of properties

2013-03-17 Thread R. David Murray 

Changes by R. David Murray rdmur...@bitdance.com:


--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17446
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com