[issue17483] In urlopen the check_hostname variable can never be False.

2013-03-19 Thread Daniel Wozniak

New submission from Daniel Wozniak:

In the urllib.request.urlopen on line 154 the code path that sets 
check_hostname to False will never run. I'm not sure what the desired behavior 
is. If we want to have a way to tell urlopen not to check the hostname for 
https connections it looks as though there needs to be some re-factoring.

--
components: Library (Lib)
files: comments.diff
keywords: patch
messages: 184650
nosy: dwoz, giampaolo.rodola, janssen, pitrou
priority: normal
severity: normal
status: open
title: In urlopen the check_hostname variable can never be False.
type: behavior
versions: Python 3.4
Added file: http://bugs.python.org/file29482/comments.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17483] In urlopen the check_hostname variable can never be False.

2013-03-19 Thread Jeff Knupp

Jeff Knupp added the comment:

Was this discovered when you were trying to tell urlopen not to check the 
hostname for https connections? If so, that should be reflected in the title 
so others know what the observable effect is. Referencing specific variables is 
less useful both for searching later and because the fix may not touch that 
part at all (as you alluded to, it may require refactoring).

--
nosy: +jeffknupp

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com