[issue17554] Compact output for regrtest

[STINNER Victor]

STINNER Victor  added the comment:

This issue has no activity for 5 years. regrtest output evolved a lot since 
that one. I like "verbose" output on buildbots to be able to debug when 
something goes wrong.

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8c337b4a8811 by Berker Peksag in branch 'default':
Issue #17554: Print "fetching  ..." messages only in verbose mode.
https://hg.python.org/cpython/rev/8c337b4a8811

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Berker Peksag]

Berker Peksag added the comment:

issue17554-urlfetch.diff LGTM.

--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Florent Xicluna]

Changes by Florent Xicluna :


--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Ezio Melotti added the comment:

Attached patch shows the "Fetching  ..." only in verbose mode.

--
Added file: http://bugs.python.org/file29670/issue17554-urlfetch.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Ezio Melotti added the comment:

The tests enabled by -uall (and probably -unetwork) use open_urlresource, and 
open_urlresource has a "print('\tfetching %s ...' % url, 
file=get_original_stdout())".  This should probably be printed only when -v is 
passed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[R. David Murray]

R. David Murray added the comment:

-uall shouldn't produce more output by itself, it just runs more tests.  Do you 
mean that some *output* is actually conditionalized on whether a certain 
resource is enabled?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Ezio Melotti added the comment:

I fixed all the tests that were producing extra output on my machine, but there 
are probably some left on other machines.  Using -uall also produces extra 
output, and I haven't decided how to deal with that yet (maybe it should be 
silenced as well).
Getting this right might require to introduce e.g. a new 
regrtest/support.print() function though...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ned Deily]

Ned Deily added the comment:

There definitely needs to be an option to continue to include the normal 
progress list in the output.  This is essential for comparing test runs.  I'm 
+0 on whether it be the default or not.  Actually, what is really needed for 
automated analysis of test runs is getting the complete output of a regrtest 
run in a standard serialized format, perhaps YAML, including the test name, 
test result, stdout, and stderr for each test. But that's a separate issue.  
I've attached a the output from a current OS X run with the proof-of-concept 
patch.  One issue that I see is that there are a number of tests that normally 
produce messages of various sorts to stderr and/or stdout without the test 
failing.  Suppressing the passed test names makes it difficult to figure out 
from which tests these messages are coming from.

--
nosy: +ned.deily
Added file: http://bugs.python.org/file29601/patched_regrtest_output.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Ezio Melotti added the comment:

They will still see the test names and the counter that increases.  I would 
also say that having the whole output fitting in a screen is less intimidating 
than a few screens filled with a wall of text.  It also makes easier to notice 
skipped and failing tests, and that might mitigate the common question "why it 
says that test_xxx was skipped?" (when the test is actually skipped, a reason 
is usually presented, but that's lost in the output, and not repeated at the 
end).
Maybe we should ask on core-mentorship what version they like more?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Antoine Pitrou]

Antoine Pitrou added the comment:

One reason I think the full list is better is that it's easier for beginners to 
understand and review what's happening (and also get a taste of the contents of 
the test suite). Experienced contributors wouldn't care that much admittedly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Ezio Melotti added the comment:

I would prefer to have it by default with a flag to disable it, since IMHO the 
full list of passed tests is just noise, but other devs don't seem to like the 
idea.
Another option would be to save the flags in a config file or in an envvar, so 
that it won't be necessary to repeat them every time, but that's another issue 
(and on a related note, people don't seem to specify -Wd either when they run 
the tests, even if they should)...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Brett Cannon]

Brett Cannon added the comment:

I say move forward and put it behind a flag (w/ quiet is fine, maybe some arg 
to specify quietness or -qq much like -vv?).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[R. David Murray]

R. David Murray added the comment:

No, what I'd prefer is that the current "print it as it runs" behavior not 
change, but that the list of skip reasons be displayed at the end. after all 
the tests have completed.  This is probably not a realistic request, so I'm 
fine with just having Ezio's version as an option.  

To be clear: I don't have any use for the list of passed tests other than it 
keeping me informed of the test run progress, and for that use I want it to 
scroll up my display, not overwrite on one line.

That said, I don't have *strong* feelings about this :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Brett Cannon]

Brett Cannon added the comment:

So are you saying you want both the short-form output while running but then 
the whole output upon completion, David? I can understand wanting the summaries 
still in order to sort the skipped tests vs. failures, but not outputting every 
test that succeeded since you can figure that out through a process of 
elimination w/o much issue.

I think instead it would serve us better to have a command to write the tests 
that were run and what happened to a file for use with the -f with successes 
commented out, skips commented out along with the skipped message, and then 
only failures left uncommented for easier re-running of the tests in the same 
order.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[R. David Murray]

R. David Murray added the comment:

Oh, by 'looks good' I was referring to the output, not the patch, which I 
haven't looked at yet.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[R. David Murray]

R. David Murray added the comment:

I would like both the normal (non-overwritten) progress list and the summary at 
the end :)

I would not like the overwriting mode to be the default, but otherwise it looks 
good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

Changes by Ezio Melotti :


Added file: http://bugs.python.org/file29586/regroutput.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17554] Compact output for regrtest

[Ezio Melotti]

New submission from Ezio Melotti:

The attached patch is a proof of concept that changes the output of regrtest so 
that the "[xxx/yyy] test_zz" is updated in place instead of printing each 
test on a separate line.  Failures, skips, and the final report are printed 
normally, making it easier to find what failed without having to scroll for 
400+ lines of output.
The patch works with and without -j, but I haven't tested it with other flags.

If people like the idea, this could be the default behavior, otherwise a new 
flag to enable the feature could be added (or it could be enabled with the 
already existing -q/--quiet).

Also attached a sample output of a full test run.

--
components: Tests
files: regr.diff
keywords: patch
messages: 185302
nosy: brett.cannon, chris.jerdonek, ezio.melotti, haypo, pitrou, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: Compact output for regrtest
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file29585/regr.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com