[issue17652] Add skip_on_windows decorator to test.support

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[STINNER Victor]

STINNER Victor added the comment:

It might be interesting to see a patch that converts current 
@skipIf(sys.platform == 'win32' or os.name == 'nt') instances to 
@skip_on_windows to see just what kind of difference it makes, but I'm 
honestly more interested in seeing how many different ways don't run this test 
on Windows is spelled currently.

I agree. Berker: are you interested to work on such patch?

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Zachary Ware]

Zachary Ware added the comment:

The patch looks fine, but I don't see a big gain from it; call me +0.  It might 
be interesting to see a patch that converts current @skipIf(sys.platform == 
'win32' or os.name == 'nt') instances to @skip_on_windows to see just what 
kind of difference it makes, but I'm honestly more interested in seeing how 
many different ways don't run this test on Windows is spelled currently.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Mark Lawrence]

Mark Lawrence added the comment:

I like the idea and the patch looks clean so can we have a commit review please.

--
nosy: +BreamoreBoy
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Berker Peksag]

Berker Peksag added the comment:

 Could you also propose places in the test to use this?

Sure.

- Lib/test/test_py_compile.py
- Lib/test/test_cmd_line.py
- Lib/test/test_faulthandler.py
- Lib/test/test_subprocess.py
- Lib/test/test_fileio.py
- Lib/test/test_io.py
- Lib/test/test_logging.py
- Lib/test/test_uuid.py
- Lib/test/datetimetester.py
- Lib/test/test_glob.py
- Lib/test/test_import.py
- Lib/test/test_multiprocessing.py
- Lib/test/test_signal.py
- Lib/test/test_site.py
- Lib/test/test_sysconfig.py

Here's an alternative patch that adds an optional reason parameter.

--
Added file: http://bugs.python.org/file30031/issue17652_v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Ezio Melotti]

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +brian.curtin
stage:  - patch review
type:  - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Brian Curtin]

Brian Curtin added the comment:

Could you also propose places in the test to use this? If we're going to add 
it, we should use it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17652] Add skip_on_windows decorator to test.support

[Berker Peksag]

New submission from Berker Peksag:

I saw a conversation about adding a @skip_on_windows decorator on #python-dev a 
couple of months ago.

Attached a patch with a documentation update.

(Added the participants of the conversation to nosy list.)

--
components: Tests
files: skip_on_windows.diff
keywords: patch
messages: 186226
nosy: berker.peksag, ezio.melotti, r.david.murray
priority: normal
severity: normal
status: open
title: Add skip_on_windows decorator to test.support
versions: Python 3.4
Added file: http://bugs.python.org/file29718/skip_on_windows.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com