[issue1776160] Buffer overflow when listing deeply nested directory

[Benjamin Peterson]

Change by Benjamin Peterson :


--
resolution:  -> wont fix
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Zackery Spytz]

Zackery Spytz  added the comment:

Python 2 is EOL.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Eryk Sun]

Eryk Sun  added the comment:

In Windows 7, FindFirstFileA uses a per-thread static buffer to decode the 
input bytes path to Unicode. This buffer limits the length to 259 characters 
(MAX_PATH - 1), even if a "\\?\" device path is used. Windows 8+ uses a dynamic 
buffer, but I don't see the point of switching to a  dynamic buffer on our side 
given Windows 7 is still so widely used and the documentation still requires 
Unicode for long "\\?\" paths. 

Ideally, I think 2.7 should raise the same exception as 3.5 does in this case 
[1]. For example:

>>> os.listdir(long_bytes_path)
Traceback (most recent call last):
  File "", line 1, in 
ValueError: listdir: path too long for Windows

[1]: https://github.com/python/cpython/blob/v3.5.7/Modules/posixmodule.c#L928

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Benjamin, what of the proposed options do you prefer?

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Mark Lawrence]

Mark Lawrence added the comment:

I suggest we close this as won't fix since I don't see how we can justify 
spending time working around a known limitation of Windows.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Martin v . Löwis]

Changes by Martin v. Löwis mar...@v.loewis.de:


--
nosy:  -loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Arno Bakker]

Arno Bakker added the comment:

Can somebody please look at this bug? It still appears in SCons 2.2.0 on 
Windows 7 when it tries to do a os.listdir on 

C:\Program Files\Microsoft Visual Studio 9.0\VC\ATLMFC\INCLUDE;C:\Program 
Files\Microsoft Visual Studio 9.0\VC\INCLUDE;C:\Program Files\Microsoft 
SDKs\Windows\v6.0A\include;\build\libevent-2.0.20-stable-debug\include;\build\libevent-2.0.20-stable-debug\WIN32-Code;\build\gtest-1.4.0\include;

--
nosy: +a...@cs.vu.nl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Arno Bakker]

Arno Bakker added the comment:

This is on Python 2.7.3 on Win7 32-bit, sorry.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Can you please report what Python version you are using?

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This issue is related to parsing of et# format which is used only in 
listdir() and _getfullpathname() under Windows. PyArg_ParseTuple() throws 
TypeError exception for multiple conversion errors (in this case it is an 
overflow of a static buffer). There are several ways to solve this issue:

1. Do nothing, close the issue as wont fix.  This is just the wrong exception 
in a very rare case only on 2.7 and only under Windows.  The issue will go away 
with 2.7.

2. Use under Windows dynamic buffer as under other platforms.  This will 
require not only dynamic memory allocation, but also reallocation for \*.* 
appending.

3. Do not use PyArg_ParseTuple().  Parse the singular argument manually.

4. If PyArg_ParseTuple() fails then check if the raised exception is TypeError 
and the error message matches (buffer overflow).  In this case raise the 
right exception.

5. Rewrite PyArg_ParseTuple() so that it will raise an appropriate type of 
exception (this will have to do anyway, but maybe later, in other issue).  In 
this case it will be OverflowError.  Then we can catch this error and raise the 
right exception.

Martin, what is your decision?

--
versions: +Python 2.7 -Python 2.6, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also issue4071.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Skip Montanaro]

Changes by Skip Montanaro s...@pobox.com:


--
nosy:  -skip.montanaro

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1776160] Buffer overflow when listing deeply nested directory

[Daniel Diniz]

Changes by Daniel Diniz aja...@gmail.com:


--
priority: normal - low
stage:  - test needed
type:  - behavior
versions: +Python 2.6, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1776160
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com