[issue17767] Fix test discovery for test_locale.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I combined two last Zachary's patches and added more robust locale test cleanup 
(old locale now restored even when print() in setUp() will failed).

Thank you for your patch Zachary.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3b883491a5f2 by Serhiy Storchaka in branch '3.3':
Issue #17767: test_locale now works with unittest test discovery.
http://hg.python.org/cpython/rev/3b883491a5f2

New changeset 60e72210683c by Serhiy Storchaka in branch 'default':
Issue #17767: test_locale now works with unittest test discovery.
http://hg.python.org/cpython/rev/60e72210683c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Zachary Ware]

Zachary Ware added the comment:

Here's a new patch addressing Serhiy's Rietveld comment.  This patch also 
includes the addition of 'flush=True' to the verbose print in 
BaseLocalizedTest.setUp to make output look a little nicer.

--
Added file: http://bugs.python.org/file30765/test_locale_discovery.v3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Zachary Ware]

Zachary Ware added the comment:

Looking at this one again, I missed removing the run_unittest import.  Here's a 
new patch.

--
Added file: http://bugs.python.org/file30631/test_locale_discovery.v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17767] Fix test discovery for test_locale.py

[Zachary Ware]

New submission from Zachary Ware:

This one actually had Failures rather than Errors; those failures arose from 
enUS_locale being None because it was being changed in test_main.  This patch 
attempts to fix things by adapting get_enUS_locale() to return a tuple of a 
suitable setting for enUS_locale and a reason for skipping the tests that were 
formerly ignored if enUS_locale was None.

--
components: Tests
files: test_locale_discovery.diff
keywords: patch
messages: 187117
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_locale.py
type: behavior
versions: Python 3.3, Python 3.4
Added file: http://bugs.python.org/file29891/test_locale_discovery.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com