[issue17778] Fix test discovery for test_multiprocessing.py
Roundup Robot added the comment: New changeset 8a922b28b97d by Richard Oudkerk in branch '3.3': Issue #17778: Fix test discovery for test_multiprocessing. (Patch by http://hg.python.org/cpython/rev/8a922b28b97d New changeset c704735487ae by Richard Oudkerk in branch 'default': Issue #17778: Fix test discovery for test_multiprocessing. (Patch by http://hg.python.org/cpython/rev/c704735487ae -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Richard Oudkerk added the comment: Thanks for the patches! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Zachary Ware added the comment: Since there's been another test added since the last version of this patch, here's a new patch again. I'll also be attaching a patch to 3.3, which includes backports of the 4 changesets mentioned in my last message, as well as the changes for this issue. -- Added file: http://bugs.python.org/file30878/test_multiprocessing_discovery.v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file30879/test_multiprocessing_discovery.v3-3.3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Changes by Richard Oudkerk shibt...@gmail.com: -- nosy: +sbt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Zachary Ware added the comment: Hmmm, it looks a couple of things have gone wrong. First, I didn't try the patch on 3.3, whose test_multiprocessing is significantly different than default's. This appears to be due largely to dd5e98ddcd39, but there have been other changes to only default since then as well. As it turns out, 3.3 passes default's test_multiprocessing, so is there any reason not to backport all of the changes to 3.3 to keep the two the same? FTR, the changesets not backported are (in order): dd5e98ddcd39, 7d69d04522e3, 2dc08789ad3e, and 2966e5a55396. Secondly, the patch doesn't apply to default because a new test was added shortly after I submitted the patch. The only real change to my patch to deal with this is the line numbers of hunk 2, and the removed testcases_other has an extra line removed. Here's a new version of the patch which applies cleanly to default. I'll leave 3.3 for now until it's decided whether or not to backport changes to it. -- Added file: http://bugs.python.org/file29941/test_multiprocessing_discovery.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
Ezio Melotti added the comment: The patch doesn't seem to apply cleanly on 3.3 (and on default too). -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17778] Fix test discovery for test_multiprocessing.py
New submission from Zachary Ware: I think this one only didn't work with discovery by accident: the only change necessary to make discovery pass was to make _TestPoll match all other _Test* classes by inheriting from BaseTestCase instead of unittest.TestCase. The remainder of the changes are to eliminate test_main by converting it instead to setUpModule. setUpModule is, I think, necessary on this one due to a failing test in WithProcessesTestLogging when the initial call to multiprocessing.get_logger().setLevel() (originally in test_main) is moved to top-level code. -- components: Tests files: test_multiprocessing_discovery.diff keywords: patch messages: 187181 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_multiprocessing.py type: behavior versions: Python 3.3, Python 3.4 Added file: http://bugs.python.org/file29905/test_multiprocessing_discovery.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
