[issue17791] PC/pyconfig.h defines PREFIX macro

2013-11-20 Thread Roundup Robot

Roundup Robot added the comment:

New changeset fbd856e817a1 by Christian Heimes in branch 'default':
Issue #17791: Drop PREFIX and EXEC_PREFIX definitions from PC/pyconfig.h
http://hg.python.org/cpython/rev/fbd856e817a1

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-11-20 Thread Christian Heimes

Changes by Christian Heimes :


--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-11-17 Thread Christian Heimes

Christian Heimes added the comment:

I'll remove the offending lines later.

--
assignee:  -> christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-10-23 Thread Christian Heimes

Christian Heimes added the comment:

Fantastic! Does anybody know anything about Cygwin builds? I expect that Cygwin 
uses autoconf to generate its own pyconfig.h.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-10-23 Thread Tim Golden

Tim Golden added the comment:

Ok by me: build and tests all ok.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-10-21 Thread Christian Heimes

Christian Heimes added the comment:

ping RMs and Windows devs

--
nosy: +brian.curtin, larry, tim.golden

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-06-24 Thread Christian Heimes

Christian Heimes added the comment:

It looks like we can drop PREFIX and EXEC_PREFIX from PC/pyconfig.h all along. 
Only Modules/getpath.c uses PREFIX and EXEC_PREFIX but MSVC build use 
PC/getpathp.c instead of Modules/getpath.c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17791] PC/pyconfig.h defines PREFIX macro

2013-04-18 Thread Christian Heimes

New submission from Christian Heimes:

The pyconfig.h file of the Windows build environment defines at least two 
macros without a Py/PY prefix:

PC/pyconfig.h:#define PREFIX ""
PC/pyconfig.h:#define EXEC_PREFIX ""

This has caused multiple issues in the past. For example libexpat uses PREFIX, 
too. When I was working on my XML patches it took me about half an hour to fix 
the build on Windows. PyLucence's JCC has run into the same issue, too. 
http://mail-archives.apache.org/mod_mbox/lucene-pylucene-dev/201304.mbox/browser

Can we change the name of PREFIX to PY_PREFIX nad EXEC_PREFIX to PY_EXEC_PREFIX?

--
components: Build, Windows
messages: 187284
nosy: christian.heimes, loewis
priority: normal
severity: normal
stage: needs patch
status: open
title: PC/pyconfig.h defines PREFIX macro
type: compile error
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com