[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Change by Mark Roseman :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Mark Roseman  added the comment:

have updated/cleaned up the previous patch, and there's a new PR. i realize 
this is unfortunately a somewhat monolithic change which might make reviewing 
it a bit tough...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Change by Mark Roseman :


--
pull_requests: +21864
pull_request: https://github.com/python/cpython/pull/22947

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Terry J. Reedy]

Terry J. Reedy  added the comment:

IDLE now uses ttk unconditionally by requiring tk 8.5.  The patch can therefore 
be simplified accordingly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Changes by Mark Roseman :


--
pull_requests: +2510

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
stage: needs patch -> patch review
versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Mark Roseman added the comment:

Please go ahead with any of the patches I submitted earlier, credit is 
absolutely not an issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Terry J. Reedy]

Terry J. Reedy added the comment:

Mark, Python now uses git and pull requests.  Can you, and do you wish to, 
rebase and convert to a pull request, any of your patches we wish to 
investigate further, yourself, or should we go ahead and do so?  Silence for a 
week will be taken as the latter.  The main difference is being the author of 
the pull request, versus 'merely' being credited in the commit message, as 
before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Louie Lu]

Louie Lu added the comment:

Rebase markroseman patch to latest version, I own no credit on this patch.

Just want to check the effect about the patch.

--
Added file: http://bugs.python.org/file46884/0001-WIP.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Louie Lu]

Louie Lu added the comment:

Mark, do you mind to rebase your patch to the latest version?

--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Mark Roseman added the comment:

Have attached debugger-ui.patch, which greatly updates the user interface for 
the existing debugger.  

This also relies on some images that should be downloaded and unpacked into the 
'Icons' directory: http://www.tkdocs.com/images/debugicons.zip

Summary of changes:
 * works with both Tk 8.4 and 8.5+
 * paned window separates left and right, allowing adjusting relative sizes
 * on left, toolbar with graphical/text buttons, plus message, and stack
 * on right, local and global variables of selected stack frame
 * running program can be interrupted via 'stop' button
 * stack and variables use listbox (8.4) or tree (with resizable columns)
 * removed locals, globals, and stack 'view' options
 * source option changed to auto-open windows to see source
 * can always view source by double-clicking or context menu in stack
 * full value of variable can be seen via tooltip in variable list
 
In future, this will also replace the 'stack viewer' feature for displaying
exceptions, but this has not yet been integrated.

--
keywords: +patch
Added file: http://bugs.python.org/file40551/debugger-ui.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Mark Roseman added the comment:

Have attached debugpanel.py, implementing a ttk-based mockup of one possible 
redesign of the debugger UI, as seen in 
http://bugs.python.org/file40234/newtabs.png

--
Added file: http://bugs.python.org/file40266/debugpanel.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17942
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Changes by Mark Roseman m...@markroseman.com:


--
nosy: +markroseman

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17942
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Terry J. Reedy]

Terry J. Reedy added the comment:

With more debugger use experience, I decided that there are many possible small 
improvements that would make it easier to use for beginners.

0. The window strikes me as overall 'blah', if not ugly. The difference between 
inactive and active could be brighter.

1. There are 5 action buttons: They could be labelled as such, and maybe spaced 
out a big.  They could all use an explanatory popup.  [quit], for instance, 
means quit the current session *without* closing the window.

2. There are 4 display checkboxes. They could be labelled as such on a line 
under the action buttons. The buttons could then be spread out a bit.

3. In the middle of the gray field, I see, for instance,
  tem.py:1 module0  # or
  pyshell#0:1 module0  # if enter statement interactively
'tem.py' is the file name, either 0 or 1 or both are line numbers (Python 0, tk 
1). module seems redundant here as nothing else can be run,  unless importing 
another module in an open window would 

4. The first line in the Stack box (not labelled, unlike Locals and Globals 
boxes), always has 
'bdb'.run(), line 431: exec(cmd, globals, locals)
This seems like noise, better suppressed if possible. Next line:
'__main__'.module0, line 1: pass

5. If one only has [locals], globals == module-level locals is displayed in a 
'locals' box. If one hits [globals], that box is relabeled 'globals' and an 
empty 'locals' box open above.  Perhaps the initial box should be 
'globals/locals' and relabeled to either when stepping into a class or function.

--
title: IDLE Debugger: names, values misaligned - IDLE Debugger: Improve GUI

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17942
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Terry J. Reedy]

Terry J. Reedy added the comment:

6. The offset with my current screen is two pixels, as determined by 
___='__' and not as bad as I remember it.  Probably due to padding 
differences.

7. The font and fontsize of Debug Control are fixed, as with dialogs.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17942
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com