[issue18010] pydoc search chokes on import errors

2015-11-06 Thread Martin Panter 

Changes by Martin Panter :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-06 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 1ab20d3c9dc6 by Martin Panter in branch '2.7':
Issue #18010: Fix pydoc GUI search to handle package exceptions
https://hg.python.org/cpython/rev/1ab20d3c9dc6

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-05 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

gui-search.patch LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-05 Thread Martin Panter 

Martin Panter added the comment:

In Python 2, it looks like instead of the web server search function there is a 
GUI search function. Here is a patch to fix the equivalent problem there. 
However I am not volunteering to make a test case; there does not seem to be 
any GUI tests to start with.

--
stage: commit review -> patch review
Added file: http://bugs.python.org/file40959/gui-search.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-05 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 9098731de840 by Martin Panter in branch '3.4':
Issue #18010: Fix pydoc web server search to handle package exceptions
https://hg.python.org/cpython/rev/9098731de840

New changeset 8702efa1feb4 by Martin Panter in branch '3.5':
Issue #18010: Merge pydoc web search fix from 3.4 into 3.5
https://hg.python.org/cpython/rev/8702efa1feb4

New changeset d86ff708f545 by Martin Panter in branch 'default':
Issue #18010: Merge pydoc web search fix from 3.5
https://hg.python.org/cpython/rev/d86ff708f545

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-05 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-05 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Oh, I were not expected that the test will be so complex, and now I'm not sure 
that want it. :-(  But looks it can't be written simpler. The patch LGTM in any 
case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-11-01 Thread Martin Panter 

Martin Panter added the comment:

Here is a test case. I had to insert a temporary directory into sys.path, based 
off my patch in Issue 25184. Let me know if it doesn’t look too evil :)

--
nosy: +martin.panter
stage: test needed -> patch review
Added file: http://bugs.python.org/file40924/pydoc_search_onerror.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-10-25 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Would be nice to have a test.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-10-25 Thread Raymond Hettinger 

Raymond Hettinger added the comment:

The patch looks good.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2015-10-25 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
stage: needs patch -> test needed
versions: +Python 3.5, Python 3.6 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2013-12-09 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
nosy:  -serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2013-05-18 Thread Antoine Pitrou 

Antoine Pitrou added the comment:

Patch attached.

--
keywords: +patch
Added file: http://bugs.python.org/file30306/pydoc_search_onerror.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2013-05-18 Thread Antoine Pitrou 

Antoine Pitrou added the comment:

Not exactly. issue10060 is about a crash when loading an extension module, not 
an exception being raised and propagated through pydoc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2013-05-18 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Isn't issue10060 related?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18010] pydoc search chokes on import errors

2013-05-18 Thread Antoine Pitrou 

New submission from Antoine Pitrou:

After installing Django, I get the following error in test_pydoc:

==
FAIL: test_url_requests (test.test_pydoc.PydocUrlHandlerTest)
--
Traceback (most recent call last):
  File "/home/antoine/cpython/finalize/Lib/test/test_pydoc.py", line 581, in 
test_url_requests
self.assertEqual(result, title, text)
AssertionError: 'Pydoc: Error - search?key=pydoc' != 'Pydoc: Search Results'
- Pydoc: Error - search?key=pydoc
+ Pydoc: Search Results

The reason is attempting to import a django.something module raises the 
following error:

django.core.exceptions.ImproperlyConfigured: Requested setting DATABASES, but 
settings are not configured. You must either define the environment variable 
DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings

... which isn't silenced by pydoc.

Now I agree this is fundamentally obnoxious on Django's part, but unfortunately 
it isn't the only package (IIRC) to behave in this way, meaning it would be 
nice from pydoc to silence all such errors when an import is attempted.

--
components: Library (Lib)
messages: 189536
nosy: pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: pydoc search chokes on import errors
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com