[issue18049] Re-enable threading test on OSX

[Ronald Oussoren]

Change by Ronald Oussoren :


--
pull_requests: +14543
pull_request: https://github.com/python/cpython/pull/14748

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Ronald Oussoren]

Ronald Oussoren  added the comment:

I have a patch for making the stack sizes the same in Issue34264.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

yes, maybe, could you provide a patch ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Ronald Oussoren]

Ronald Oussoren added the comment:

The patch increases the stack size for threads to slightly less than size as is 
used for the main thread, see this fragment in configure.ac:

   # Issue #18075: the default maximum stack size (8MBytes) is too
   # small for the default recursion limit. Increase the stack size
   # to ensure that tests don't crash
   LINKFORSHARED="-Wl,-stack_size,100 $LINKFORSHARED"

Maybe the patch should be updated to use the same size? 

The disadvantage of any increase of size is that this reduces the number of 
threads that can be used, in particular for 32-bit builds (64-bit builds have 
more than enough address space)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

for my part, I think you should use a #ifdef PY_DEBUG in your code and increase 
the default size of the stack for the threads, and only if you are on APPLE and 
PY_DEBUG mode.

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Ronald Oussoren]

Ronald Oussoren added the comment:

I intend to apply this patch to default (and only that branch) after running 
the testsuite and with a small change: the stack size will be 0x100 (double 
it current value) to sync it with the stack size for the main thread, which was 
recently set to that value in the default branch.

--
keywords: +needs review, patch
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on OSX

[Ronald Oussoren]

New submission from Ronald Oussoren:

I recently notied that 
test.test_threading.ThreadingExceptionTests.test_recursion_limit is disabled 
for debug builds. 

The attached patch re-enables this test case and fixes the crash be increasing 
the stack size for new threads. 

The disadvantage of the patch is that is increases the default stack size for 
all new threads on OSX from 5 to 8 megabytes (for threads created by Python) 
and that could affect program behavior as fewer threads can be created before 
running out of memory.

The patch could be updated to check for Py_DEBUG and only increase the stack 
size for --with-pydebug builds (which are the ones using -O0), as those builds 
need the increased stack size and debug builds already consume more memory that 
normal builds. That's not 100% reliable though, as users could also build the 
with CFLAGS set to -O0 without using --with-pydebug. 

I haven't found a way to detect the optimization level with clang or gcc using 
the preprocessor.

--
assignee: ronaldoussoren
components: Macintosh
files: reenable-threading-test.txt
messages: 189912
nosy: ned.deily, ronaldoussoren
priority: normal
severity: normal
stage: patch review
status: open
title: Re-enable threading test on OSX
type: behavior
Added file: http://bugs.python.org/file30359/reenable-threading-test.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com