[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Ned Deily  added the comment:


New changeset dcc0eb379613f279864af61023ea44c94aa0535c by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-14546)
https://github.com/python/cpython/commit/dcc0eb379613f279864af61023ea44c94aa0535c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Ned Deily  added the comment:


New changeset 782854f90ad5f73f787f68693d535f2b05514e13 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-14546) 
(GH-14549)
https://github.com/python/cpython/commit/782854f90ad5f73f787f68693d535f2b05514e13


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

miss-islington  added the comment:


New changeset bf82cd3124df94935c6e3190c7c40b76918d2174 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-14546)
https://github.com/python/cpython/commit/bf82cd3124df94935c6e3190c7c40b76918d2174


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

miss-islington  added the comment:


New changeset bd92b94da93198c8385c06ca908407f172c7e8b2 by Miss Islington (bot) 
in branch '3.8':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-14546)
https://github.com/python/cpython/commit/bd92b94da93198c8385c06ca908407f172c7e8b2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

Change by miss-islington :


--
pull_requests: +14366
pull_request: https://github.com/python/cpython/pull/14549

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Ned Deily  added the comment:


New changeset 5bbbc733e6cc0804f19b071944af8d4719e26ae6 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-14546)
https://github.com/python/cpython/commit/5bbbc733e6cc0804f19b071944af8d4719e26ae6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

Change by miss-islington :


--
pull_requests: +14364
pull_request: https://github.com/python/cpython/pull/14548

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

Change by miss-islington :


--
pull_requests: +14362
pull_request: https://github.com/python/cpython/pull/14547

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +14360
pull_request: https://github.com/python/cpython/pull/14546

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Ned Deily  added the comment:


New changeset fbe2a1394bf52f5a4455681e1b1f705a31559585 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011) 
(GH-13014)
https://github.com/python/cpython/commit/fbe2a1394bf52f5a4455681e1b1f705a31559585


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

Change by miss-islington :


--
pull_requests: +12937

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

miss-islington  added the comment:


New changeset 52a5b71063af68c42b048095c4e555e93257f151 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/52a5b71063af68c42b048095c4e555e93257f151


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Ned Deily  added the comment:


New changeset 883dfc668f9730b00928730035b5dbd24b9da2a0 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/883dfc668f9730b00928730035b5dbd24b9da2a0


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[miss-islington]

Change by miss-islington :


--
pull_requests: +12935

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +12933

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Łukasz Langa]

Changes by Łukasz Langa :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Roundup Robot]

Roundup Robot added the comment:

New changeset b07ad4b5e349 by Łukasz Langa in branch 'default':
Fixed #18075 - Infinite recursion tests triggering a segfault on Mac OS X
http://hg.python.org/cpython/rev/b07ad4b5e349

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ronald Oussoren]

Ronald Oussoren added the comment:

On 30 May, 2013, at 14:50, STINNER Victor  wrote:

> 
> STINNER Victor added the comment:
> 
>> The patch changes the maximum stack size from 8 to 16 MByte, neither of 
>> which is huge and shouldn't cause other problems.
> 
> On Mac OS X: Is the memory allocated at Python startup, or on demand,
> as the stack grows? If I am correct, the physical memory is allocated
> on demand on Linux.

Memory for the stack is allocated on demand, the parameter sets the maximum 
size that the stack can grow to. See also man ld(1).

Ronald

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[STINNER Victor]

STINNER Victor added the comment:

> The patch changes the maximum stack size from 8 to 16 MByte, neither of which 
> is huge and shouldn't cause other problems.

On Mac OS X: Is the memory allocated at Python startup, or on demand,
as the stack grows? If I am correct, the physical memory is allocated
on demand on Linux.

2013/5/30 Ronald Oussoren :
>
> Ronald Oussoren added the comment:
>
> I'd prefer to keep the default recursion limit the same as on Linux, changing 
> the recursion limit on OSX would just introduce an unnecessary difference 
> between the two platforms.
>
> The patch changes the maximum stack size from 8 to 16 MByte, neither of which 
> is huge and shouldn't cause other problems.
>
> I'd also like to increase the default stack size for newly created threads 
> (see #18049) and will update that patch to create a 16 MByte stack as well.
>
> --
>
> ___
> Python tracker 
> 
> ___

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ronald Oussoren]

Ronald Oussoren added the comment:

I'd prefer to keep the default recursion limit the same as on Linux, changing 
the recursion limit on OSX would just introduce an unnecessary difference 
between the two platforms.

The patch changes the maximum stack size from 8 to 16 MByte, neither of which 
is huge and shouldn't cause other problems.

I'd also like to increase the default stack size for newly created threads (see 
#18049) and will update that patch to create a 16 MByte stack as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[STINNER Victor]

STINNER Victor added the comment:

> Appearently the default maximum stack size isn't large enough for the default 
> value of the recursion limit.

Why not changing the recursion limit instead of the size of the stack?

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Brett Cannon]

Brett Cannon added the comment:

LGTM

--
assignee:  -> ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ronald Oussoren]

Ronald Oussoren added the comment:

The update fixes the name error mention in rietveld.

--
Added file: 
http://bugs.python.org/file30399/issue-18075-osx-stacksize-update.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ronald Oussoren]

Ronald Oussoren added the comment:

The attached patch fixes the problem on OSX by increasing the maximum stack 
size of the main thread from 8M (the default) to 16M. 

NOTE: The -Wl,-stack_size,... option cannot be added to LDFLAGS, ld errors out 
when that option is used when linking a shared library (such as the extensions 
or libpython.dylib)

--
stage:  -> patch review
Added file: http://bugs.python.org/file30397/issue-18075-osx-stacksize.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Ronald Oussoren]

Ronald Oussoren added the comment:

I can confirm the problem. It appears to be a stack overflow, when I increase 
the stack size of the main thead (by adding "-Wl,-stack_size,2faf000" to the 
link command for BUILDPYTHON) the crash in test_json goes away.

Appearently the default maximum stack size isn't large enough for the default 
value of the recursion limit.

An easy workaround (fix?) would be to add -Wl,-stack_size,VALUE to the link 
flags on OSX, for some sane value of VALUE. The value is the maximum size of 
the stack of the main thread and doesn't affect process size unless a process 
actually uses more stack space. It does affect the available free address 
space, and hence the maximum stack size shouldn't be increased too far 
(especially for 32-bit builds)

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18075] Infinite recursion tests triggering a segfault

[Brett Cannon]

New submission from Brett Cannon:

If you run any test that has infinite recursion (test_json test_exceptions 
test_sys test_runpy) it will segfault with a fresh checkout under OS X 10.8.3 
using Clang. Not sure how widespread this is.

I did check that I am using a clean checkout of the default branch.

--
components: Interpreter Core
messages: 190162
nosy: brett.cannon, larry
priority: release blocker
severity: normal
status: open
title: Infinite recursion tests triggering a segfault
type: crash
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com