[issue18093] Move main functions to a separate Programs directory
STINNER Victor added the comment: _testembed was moved from Modules to Programs but test_capi was not updated: it still looks for test_embed in Modules. $ ./configure --with-pydebug $ make $ ./python -m test -v test_capi ... test_forced_io_encoding (test.test_capi.EmbeddingTests) ... skipped '/home/haypo/prog/python/default/Modules/_testembed' doesn't exist test_subinterps (test.test_capi.EmbeddingTests) ... skipped '/home/haypo/prog/python/default/Modules/_testembed' doesn't exist ... -- nosy: +haypo resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
STINNER Victor added the comment: test_capi.patch fixes test_capi to be able to run _testembed in test_capi. -- Added file: http://bugs.python.org/file36720/test_capi.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Roundup Robot added the comment: New changeset c87e00a6258d by Nick Coghlan in branch 'default': Issue #18093: fix test_capi test skip due to _testembed move https://hg.python.org/cpython/rev/c87e00a6258d -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Nick Coghlan added the comment: Thanks for spotting that Victor - should be fixed by that last commit with your change. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Roundup Robot added the comment: New changeset 88a532a31eb3 by Nick Coghlan in branch 'default': Issue #18093: Factor out the programs that embed the runtime http://hg.python.org/cpython/rev/88a532a31eb3 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Roundup Robot added the comment: New changeset 7640af73c19d by Nick Coghlan in branch 'default': Add missing NEWS entry for issue #18093 http://hg.python.org/cpython/rev/7640af73c19d -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Nick Coghlan added the comment: Prompted to finally get back to this by the python-dev discussion about PEP 432 (as separating these out helps keep the moving parts clear when working on the startup sequence) In response to Eric's question, Modules/main.c is part of the CPython runtime, rather than a C application that embeds the runtime. The main in the name refers to the exported Py_Main, rather than a C main function. The *actual* C level main function now lives in Programs/python.c (previously Modules/python.c) and calls Py_Main after doing a bit of fiddling about with the command line arguments and the floating point settings. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Nick Coghlan added the comment: Zach, regarding the Windows executables - up to you if you want to open an issue to move them. These ones I particularly wanted to move because I found having them in Modules to be genuinely confusing when working on the startup code. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Roundup Robot added the comment: New changeset 766570a5d607 by Zachary Ware in branch 'default': Issue #18093: Give the Windows build _testembed.c's new location. http://hg.python.org/cpython/rev/766570a5d607 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Roundup Robot added the comment: New changeset 413017768dde by Ned Deily in branch 'default': Issue #18093: Create Programs directory in build location for http://hg.python.org/cpython/rev/413017768dde -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Eric Snow added the comment: Looks good to me. What else needs to be done in this area that will help with work on PEP 432? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Eric Snow added the comment: What about Modules/main.c? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Zachary Ware added the comment: I can confirm that the patch doesn't break building on Windows. Would it make any sense to move Windows-specific sources for things like kill_python.exe (PCbuild/kill_python.c), make_buildinfo.exe, make_versioninfo.exe, py.exe (PC/launcher.c) into Programs? Or better to keep them in PC or PCbuild (at least for now, until after this patch is approved)? -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Nick Coghlan added the comment: Note that the two patches are the same, I was just curious to see the difference in handling between them in terms of the review integration. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
New submission from Nick Coghlan: This patch moves the C level main functions for python, _testembed and _freeze_importlib to a new Programs directory. I added README files with my current understanding of the expected contents of the Python, Objects, Modules and Programs directories and also attempted to update the Windows builds (which don't appear to include _testembed at all). -- components: Build, Interpreter Core files: move_programs.diff keywords: patch messages: 190292 nosy: ncoghlan priority: normal severity: normal stage: patch review status: open title: Move main functions to a separate Programs directory type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file30408/move_programs.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Nick Coghlan ncogh...@gmail.com: Added file: http://bugs.python.org/file30409/move_programs.git.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Nick Coghlan ncogh...@gmail.com: Removed file: http://bugs.python.org/file30408/move_programs.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Nick Coghlan ncogh...@gmail.com: -- Removed message: http://bugs.python.org/msg190293 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Stefan Drees ste...@drees.name: -- nosy: +dilettant ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18093] Move main functions to a separate Programs directory
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18093 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
