[issue18248] fficonfig.py.in wrong for AIX

[Roundup Robot]

Roundup Robot added the comment:

New changeset 00082406e13f by Benjamin Peterson in branch '3.3':
fix libffi build on AIX (closes #18248)
http://hg.python.org/cpython/rev/00082406e13f

New changeset 974d4844d5a7 by Benjamin Peterson in branch 'default':
merge 3.3 (#18248)
http://hg.python.org/cpython/rev/974d4844d5a7

--
nosy: +python-dev
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18248] fficonfig.py.in wrong for AIX

[STINNER Victor]

Changes by STINNER Victor victor.stin...@gmail.com:


--
versions:  -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18248] fficonfig.py.in wrong for AIX

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
stage:  - patch review
versions:  -Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18248] fficonfig.py.in wrong for AIX

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc added the comment:

LGTM. I checked in Makefile.am, and the list of platform-specific files is the 
same.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18248] fficonfig.py.in wrong for AIX

[David Edelsohn]

New submission from David Edelsohn:

fficonfig.py.in incorrectly mixes source files intended for Linux with source 
files intended for AIX, causing a build failure.

AIX uses ffi_darwin.c not ffi.c

diff -r f6f70f1ab124 Modules/_ctypes/libffi.diff
--- a/Modules/_ctypes/libffi.diff   Mon Jun 17 22:02:14 2013 +0200
+++ b/Modules/_ctypes/libffi.diff   Mon Jun 17 22:18:44 2013 -0700
@@ -135,7 +135,7 @@
 +'M32R': ['src/m32r/sysv.S', 'src/m32r/ffi.c'],
 +'M68K': ['src/m68k/ffi.c', 'src/m68k/sysv.S'],
 +'POWERPC': ['src/powerpc/ffi.c', 'src/powerpc/sysv.S', 
'src/powerpc/ppc_closure.S', 'src/powerpc/linux64.S', 
'src/powerpc/linux64_closure.S'],
-+'POWERPC_AIX': ['src/powerpc/ffi.c', 'src/powerpc/aix.S', 
'src/powerpc/aix_closure.S'],
++'POWERPC_AIX': ['src/powerpc/ffi_darwin.c', 'src/powerpc/aix.S', 
'src/powerpc/aix_closure.S'],
 +'POWERPC_FREEBSD': ['src/powerpc/ffi.c', 'src/powerpc/sysv.S', 
'src/powerpc/ppc_closure.S'],
 +'ARM': ['src/arm/sysv.S', 'src/arm/ffi.c'],
 +'LIBFFI_CRIS': ['src/cris/sysv.S', 'src/cris/ffi.c'],
diff -r f6f70f1ab124 Modules/_ctypes/libffi/fficonfig.py.in
--- a/Modules/_ctypes/libffi/fficonfig.py.inMon Jun 17 22:02:14 2013 +0200
+++ b/Modules/_ctypes/libffi/fficonfig.py.inMon Jun 17 22:18:44 2013 -0700
@@ -16,7 +16,7 @@
 'M32R': ['src/m32r/sysv.S', 'src/m32r/ffi.c'],
 'M68K': ['src/m68k/ffi.c', 'src/m68k/sysv.S'],
 'POWERPC': ['src/powerpc/ffi.c', 'src/powerpc/sysv.S', 
'src/powerpc/ppc_closure.S', 'src/powerpc/linux64.S', 
'src/powerpc/linux64_closure.S'],
-'POWERPC_AIX': ['src/powerpc/ffi.c', 'src/powerpc/aix.S', 
'src/powerpc/aix_closure.S'],
+'POWERPC_AIX': ['src/powerpc/ffi_darwin.c', 'src/powerpc/aix.S', 
'src/powerpc/aix_closure.S'],
 'POWERPC_FREEBSD': ['src/powerpc/ffi.c', 'src/powerpc/sysv.S', 
'src/powerpc/ppc_closure.S'],
 'ARM': ['src/arm/sysv.S', 'src/arm/ffi.c'],
 'LIBFFI_CRIS': ['src/cris/sysv.S', 'src/cris/ffi.c'],

--
components: Extension Modules
messages: 191381
nosy: David.Edelsohn
priority: normal
severity: normal
status: open
title: fficonfig.py.in wrong for AIX
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18248] fficonfig.py.in wrong for AIX

[STINNER Victor]

Changes by STINNER Victor victor.stin...@gmail.com:


--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18248
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com