[issue18281] tarfile defines stat constants
Ethan Furman added the comment: Sounds like we have a consensus. If no objections I'll commit in four or five days (in time for the last alpha). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Christian Heimes added the comment: Yes, please commit your patch. I totally wanted to reply to your mail but I was distracted by other things. Sorry! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Ethan Furman added the comment: Cool, thanks! I didn't want to step on any toes. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Roundup Robot added the comment: New changeset 3d557da59c22 by Ethan Furman in branch 'default': Close #18281: superfluous stat constants removed from tarfile http://hg.python.org/cpython/rev/3d557da59c22 -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
STINNER Victor added the comment: issue18281.stoneleaf.01.patch looks good to me, please commit it! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Ethan Furman added the comment: Christian, do you mind if I get this patchd committed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Eli Bendersky added the comment: lgtm. kill 'em -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Changes by Ethan Furman et...@stoneleaf.us: -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file31707/issue18281.stoneleaf.01.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Ethan Furman added the comment: Interestingly enough, the two constants that are used are prefixed with `stat`. Patch attached. Adios! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Christian Heimes added the comment: OK, your proposal is more appealing. Any last words before the constants are gone for good? -- assignee: - christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
New submission from Christian Heimes: The tarfile module defines a bunch of stat constants: http://hg.python.org/cpython/file/4465f273a8a4/Lib/tarfile.py#l142 These constants aren't documented but they look like public API constants. I would like to replace them with values from the stat module: TUREAD = stat.S_IRUSR -- components: Library (Lib) messages: 191641 nosy: christian.heimes priority: low severity: normal stage: needs patch status: open title: tarfile defines stat constants type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18281] tarfile defines stat constants
STINNER Victor added the comment: Interesting commit: changeset: 76949:492e6c6a01bb user:Giampaolo Rodola' g.rod...@gmail.com date:Tue May 15 15:30:25 2012 +0200 files: Doc/library/stat.rst Doc/whatsnew/3.3.rst Lib/stat.py Lib/tarfile.py Lib/test/test_stat.py Misc/NEWS description: #14807: move undocumented tarfile.filemode() to stat.filemode(). Add tarfile.filemode alias with deprecation warning. I would like to replace them with values from the stat module I would prefer to simply drop all these constants. None is used by the tarfile module. *If* an application uses tarfile to get stat constants, this application must be fixed to use the stat module which contain thse constants since the creation of the stat module, something like 23 years ago... changeset: 20:118545312f3b branch: legacy-trunk user:Guido van Rossum gu...@python.org date:Sun Oct 21 16:17:08 1990 + files: Lib/stat.py description: Initial revision -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18281 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
