[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7272ef213b7c by Ronald Oussoren in branch 'default':
Also remove a (broken) leaker test for the code removed in issue #18393.
http://hg.python.org/cpython/rev/7272ef213b7c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Ronald Oussoren]

Ronald Oussoren added the comment:

I won't backport to 3.3 or 2.7, it is highly unlikely that the API will 
actually be removed anytime soon.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Roundup Robot]

Roundup Robot added the comment:

New changeset ccbaf6762b54 by Ronald Oussoren in branch 'default':
Issue #18393: Remove use of deprecated API on OSX
http://hg.python.org/cpython/rev/ccbaf6762b54

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 08.07.2013 14:08, Ronald Oussoren wrote:
> 
> Ronald Oussoren added the comment:
> 
> I had hoped to just drop it in 3.4.
> 
> To remove:
> 
> * extension _gestalt
> 
> * function platform._mac_ver_gestalt
> 
> * function platform._mac_ver_lookup (only used by ^^^)
> 
> * function platform._bcd2str (likewise)
> 
> To change:
> 
> * function platform.mac_ver: remove call to _mac_ver_gestalt

Fine with me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Ronald Oussoren]

Ronald Oussoren added the comment:

I had hoped to just drop it in 3.4.

To remove:

* extension _gestalt

* function platform._mac_ver_gestalt

* function platform._mac_ver_lookup (only used by ^^^)

* function platform._bcd2str (likewise)

To change:

* function platform.mac_ver: remove call to _mac_ver_gestalt

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Ronald Oussoren]

Ronald Oussoren added the comment:

Do we follow the deprecation procedure for private functions as well?

The patch removes a private and undocumented extension, and removes a private 
function that uses that extension. There is no change in the public API.

Also, as I mentioned before the removed code is effectively dead because it 
will never be called on systems that aren't totally broken.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 08.07.2013 13:55, Ronald Oussoren wrote:
> 
> Do we follow the deprecation procedure for private functions as well?
> 
> The patch removes a private and undocumented extension, and removes a private 
> function that uses that extension. There is no change in the public API.
> 
> Also, as I mentioned before the removed code is effectively dead because it 
> will never be called on systems that aren't totally broken.

Oh, I was under the impression that the API is public. I just did a
grep: the _gestalt module is not documented and neither is the
gestalt function, so I guess we can speed up the deprecation procedure
or even drop it right away in 3.4 :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 07.07.2013 11:11, Ronald Oussoren wrote:
> The easiest solution to avoid this deprecated API is therefore to drop the  
> _gestalt extension and remove its use in platform.mac_ver()

I think it should only be removed in case we no longer support
Mac OS X platforms that still have it. Otherwise, please simply
follow our standard procedure for deprecating public functions.

--
nosy: +lemburg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Ronald Oussoren]

Ronald Oussoren added the comment:

The attached patch removes the use of the Gestalt API.

The removed code is effectively dead, I yet have to find a machine were 
platform._mac_ver_xml does not work and the gestalt based code only gets used 
when the XML variant does not work.

--
keywords: +needs review, patch
stage: test needed -> patch review
Added file: http://bugs.python.org/file30861/issue-18393.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18393] Gestalt() is deprecated on OSX 10.8, remove support?

[Ronald Oussoren]

New submission from Ronald Oussoren:

In OSX 10.8 the Gestalt() funtion in CoreServices is deprecated. This function 
is used in the _gestalt extension and exported to Python code.

The only in-tree user of this (private) extension is the platform module, it 
uses gestalt as one of the alternatives to get the OSX release; and a fallback 
at that.

A stackoverflow user has done some sleuthing and discovered that the gestalt 
function uses the same XML file to determine the OSX release as is used by the 
primary alternative used by the platform module (see 
).
 The gestalt alternative will therefore likely be useful at all (it is only 
used when the file it reads is not available in the first place).

The easiest solution to avoid this deprecated API is therefore to drop the  
_gestalt extension and remove its use in platform.mac_ver()

--
assignee: ronaldoussoren
components: Macintosh
keywords: easy
messages: 192526
nosy: ned.deily, ronaldoussoren
priority: normal
severity: normal
stage: test needed
status: open
title: Gestalt() is deprecated on OSX 10.8, remove support?
type: behavior
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com