[issue18503] No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py
R. David Murray added the comment: Thanks, Vajrasky. -- resolution: - fixed stage: - committed/rejected status: open - closed type: - behavior versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18503 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18503] No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py
Roundup Robot added the comment: New changeset 61d9c561b63d by R David Murray in branch '3.3': #18503: small cleanups in test_email. http://hg.python.org/cpython/rev/61d9c561b63d New changeset be5f1f0bea09 by R David Murray in branch 'default': #18503: small cleanups in test_email. http://hg.python.org/cpython/rev/be5f1f0bea09 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18503 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18503] No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py
Vajrasky Kok added the comment: Okay, next time I'll separate the problems into different tickets. Here is the patch to clean up the test. -- Added file: http://bugs.python.org/file30988/small_clean_up_to_test_email.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18503 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18503] No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py
Vajrasky Kok added the comment: Another unused variable in line 2268 on function test_bad_multipart: def test_bad_multipart(self): eq = self.assertEqual msg1 = Message() msg1['Subject'] = 'subpart 1' msg2 = Message() msg2['Subject'] = 'subpart 2' r = MIMEMessage(msg1) self.assertRaises(errors.MultipartConversionError, r.attach, msg2) The variable eq is never used and can be removed. I have changed the title of the ticket to reflect the problem better. -- title: No assertion in test_del_param_on_nonexistent_header function - No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18503 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18503] No assertion in test_del_param_on_nonexistent_header function and unused variables in some places in test_email.py
R. David Murray added the comment: We prefer one ticket per issue. The line is fuzzy...I think it would be OK to fix these all at once since they are all small cleanups in test_email, but as you can tell from how complex the title got, they are not really conceptually related. The try/except/fail is a valid style. I prefer to just let the exception raise, and put in a comment to that effect, but it is definitely a personal style thing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18503 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
