[issue18517] xxlimited extension declared incorrectly in setup.py

2013-08-02 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset e5607874e8ff by Ned Deily in branch '3.3':
Issue #18517: Move definition of xxlimited extension to detect_modules().
http://hg.python.org/cpython/rev/e5607874e8ff

New changeset 1d832bc857e2 by Ned Deily in branch 'default':
Issue #18517: merge from 3.3
http://hg.python.org/cpython/rev/1d832bc857e2

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-08-02 Thread Ned Deily 

Ned Deily added the comment:

On further reflection, only building on a debug build partially defeats part of 
the reason for building xxlimited; the current setup.py skips building in the 
debug case.  Perhaps another approach would be to comment out the build in 
setup.py and instead add a new test case that builds xxlimited, similar to how 
test_distutils builds xxmodule. In any case, I've applied the original patch 
for 3.3.3 and 3.4.0 and closing this issue.  Feel free to reopen if anyone 
wants to pursue this further.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-08-01 Thread Martin v . Löwis 

Martin v. Löwis added the comment:

I would be fine with it being build only in a debug build. The rationale for 
the module is that it should test whether the header files actually compile 
under the limited API (or whether e.g. some functions are exposed that rely on 
unexposed structures). So the main test is really whether it compiles.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-08-01 Thread Arfrever Frehtes Taifersar Arahesis 

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-07-21 Thread Ned Deily 

New submission from Ned Deily:

In the top-level setup.py, the code to define the Extension instance for the 
xxlimited extension is currently incorrectly located near the end of 
detect_tkinter() rather than in its parent detect_modules(). This has the 
effect of skipping the build of xxlimited on OS X since detect_tkinter() 
shortcuts to detect_tkinter_darwin() there.  The attached patch corrects that.

However, it does raise the question of why xxlimited is built at all for 
normal installable builds, since xxlimited is a dummy template module.  The 
definition for the somewhat similar xx is commented out by default.  Perhaps 
xxlimited should be as well.  Or perhaps both should only be built for 
--with-pydebug configs.  Opinions?

--
components: Build
messages: 193428
nosy: loewis, ned.deily
priority: low
severity: normal
stage: patch review
status: open
title: xxlimited extension declared incorrectly in setup.py
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-07-21 Thread Ned Deily 

Changes by Ned Deily n...@acm.org:


--
keywords: +patch
Added file: http://bugs.python.org/file30993/issue_X_setup_xxlimited.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18517] xxlimited extension declared incorrectly in setup.py

2013-07-21 Thread R. David Murray 

R. David Murray added the comment:

My expectation would be that we want the tests to be runnable (and be run, not 
skipped) with Python installed, and thus we build the test module.  (Whether or 
not our tests actually *can* be run with Python installed is an open question, 
though.)  And skipping some tests when installed is probably OK, too, so if I'm 
right about the rationale we could still change our minds.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com