[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Roundup Robot added the comment: New changeset e8db1cbe416b by Serhiy Storchaka in branch '2.7': Issue #18518: timeit now rejects statements which can't be compiled outside https://hg.python.org/cpython/rev/e8db1cbe416b New changeset a5769fa55791 by Serhiy Storchaka in branch '3.4': Issue #18518: timeit now rejects statements which can't be compiled outside https://hg.python.org/cpython/rev/a5769fa55791 New changeset b0a686260b5d by Serhiy Storchaka in branch 'default': Issue #18518: timeit now rejects statements which can't be compiled outside https://hg.python.org/cpython/rev/b0a686260b5d -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
STINNER Victor added the comment: Buildbots are unhappy. Example: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%202.7/builds/837/steps/test/logs/stdio 1 test failed: test_timeit Re-running test 'test_timeit' in verbose mode test test_timeit crashed -- type 'exceptions.ImportError': No module named support Traceback (most recent call last): File ./Lib/test/regrtest.py, line 901, in runtest_inner File /usr/home/buildbot/python/2.7.koobs-freebsd10/build/Lib/test/test_timeit.py, line 8, in module from test.support import run_unittest ImportError: No module named support [44296 refs] *** Error code 1 -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Serhiy Storchaka added the comment: Already fixed in 617c226da195. Needs time for buildbots to rerun tests. I didn't noticed error when backported tests because there was local file support.py in my workspace. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Serhiy Storchaka added the comment: If there are no objections I'm going to commit the patch. -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Changes by A.M. Kuchling a...@amk.ca: -- nosy: -akuchling ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Serhiy Storchaka added the comment: May be add a guard against statements which can confuse timeit? These are not only return, but yield, and break and continue outside of a loop. Proposed patch checks that testing code can be compiled outside of a function. -- assignee: docs@python - components: +Library (Lib) -Documentation nosy: +serhiy.storchaka stage: - patch review versions: +Python 3.5 -Python 3.3 Added file: http://bugs.python.org/file37577/timeit_reject_invalid_statements.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
jonathan ferretti added the comment: Added note to timeit function briefly explaining how to avoid it the issue and the cause -- keywords: +patch nosy: +jonathan.ferretti type: enhancement - behavior Added file: http://bugs.python.org/file34823/timeit.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Roundup Robot added the comment: New changeset 7e2708484ea5 by Andrew Kuchling in branch '3.4': #18518: mention that including a return statement changes/breaks the behaviour http://hg.python.org/cpython/rev/7e2708484ea5 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
R. David Murray added the comment: The suggestion was to make this a footnote, not a note. Also, it should probably say that the stmt is executed inside a function, meaning that instead of being a syntax error it changes the return value of the internal timeit function. I understand Raymond's desire not to clutter the docs, but I consider the footnote worth it, not to pre-inform the user, but to let them know that it is not a bug if they check the docs *after* things don't work right. It may be naive of me to think that they would do so. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
A.M. Kuchling added the comment: BTW, this change is also relevant to 2.7. Previously I wouldn't have bothered to commit it to 2.7 since the branch was largely closed, but now we're talking about some corporate maintainer eventually going through and backporting fixes to the newly-extended 2.7 branch. So should I go ahead and apply it to 2.7? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
A.M. Kuchling added the comment: I dislike footnotes and prefer to put things in the text whenever possible. The text for this change struck as relevant enough -- it notes a property of the *stmt* parameter -- that it doesn't belong in a footnote. (I'd be happy to just make it a paragraph instead of a highlighted note: I dislike notes too!) -- nosy: +akuchling ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
R. David Murray added the comment: OK, if you think it is worthwhile in the text, then sure. But yeah, not as a ..note. And yes, I think we should keep backporting relevant doc patches. Especially since Google results still land one on the 2.7 docs... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Changes by Ramchandra Apte maniandra...@gmail.com: -- title: return-ing within timeit.timeit causes wrong return value of timeit.timeit - return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
R. David Murray added the comment: I'm inclined to agree with Ramchandra. It might be worth a doc footnote, though. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - docs@python components: +Documentation -Library (Lib) nosy: +docs@python type: behavior - enhancement versions: +Python 2.7, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Raymond Hettinger added the comment: Agreed this should be closed as won't fix. -- nosy: +rhettinger resolution: - wont fix status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
R. David Murray added the comment: Rather than closing it, we converted it to a documentation issue. I think it is worth a footnote in the docs, since it is not obvious (without reading the source code) that a return statement will cause timeit to return an invalid result instead of raising a syntax error. -- resolution: wont fix - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit
Raymond Hettinger added the comment: Go ahead and add a footnote, but do consider that such footnotes are mostly just clutter. It doesn't help someone at the moment there is an invalid return value -- instead it just makes it so that afterward someone can say that it is documented. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18518 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
